Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(firefox): use bypassServiceWorker flag for storage state pages (#42741)

Dmitry Gozmanbb78937f196a
diff --git a/packages/playwright-core/src/server/firefox/ffNetworkManager.ts b/packages/playwright-core/src/server/firefox/ffNetworkManager.ts
index e17afd5c45..b6b52620fd 100644
--- a/packages/playwright-core/src/server/firefox/ffNetworkManager.ts
+++ b/packages/playwright-core/src/server/firefox/ffNetworkManager.ts
@@ -51,9 +51,9 @@ export class FFNetworkManager {
eventsHelper.removeEventListeners(this._eventListeners);
}
- async setRequestInterception(enabled: boolean) {
+ async setRequestInterception(enabled: boolean, bypassServiceWorker: boolean) {
await Promise.all([
- this._session.send('Network.setRequestInterception', { enabled }),
+ this._session.send('Network.setRequestInterception', { enabled, bypassServiceWorker }),
this._session.send('Page.setCacheDisabled', { cacheDisabled: enabled }),
]);
}
diff --git a/packages/playwright-core/src/server/firefox/ffPage.ts b/packages/playwright-core/src/server/firefox/ffPage.ts
index f343bb3c64..c2cf6cc4b9 100644
--- a/packages/playwright-core/src/server/firefox/ffPage.ts
+++ b/packages/playwright-core/src/server/firefox/ffPage.ts
@@ -416,7 +416,7 @@ export class FFPage implements PageDelegate {
}
async updateRequestInterception(): Promise<void> {
- await this._networkManager.setRequestInterception(this._page.needsRequestInterception());
+ await this._networkManager.setRequestInterception(this._page.needsRequestInterception(), this._page.isStorageStatePage);
}
async updateFileChooserInterception() {