Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

test(bidi): unskip new websocket header tests (#42130)

Holger Benlbcbdff0b2e6d
diff --git a/tests/library/browsercontext-locale.spec.ts b/tests/library/browsercontext-locale.spec.ts
index c6b5b39182..b9780fe43e 100644
--- a/tests/library/browsercontext-locale.spec.ts
+++ b/tests/library/browsercontext-locale.spec.ts
@@ -241,8 +241,8 @@ it('should send Accept-Language header on WebSocket handshake', {
it('should send Accept-Language header on WebSocket handshake from a worker', {
annotation: [{ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/13919' }],
-}, async ({ browser, server, browserName, browserMajorVersion }) => {
- it.fixme(browserName === 'firefox', 'Firefox does not associate a WebSocket opened inside a worker with its browsing context');
+}, async ({ browser, server, browserName, browserMajorVersion, isBidi }) => {
+ it.fixme(browserName === 'firefox' && !isBidi, 'Firefox/Juggler does not associate a WebSocket opened inside a worker with its browsing context');
it.fixme(browserName === 'chromium' && browserMajorVersion < 151, 'Chromium before 151 sends the browser Accept-Language instead of the emulated locale on WebSocket handshake');
const context = await browser.newContext({ locale: 'en-GB' });
diff --git a/tests/library/web-socket.spec.ts b/tests/library/web-socket.spec.ts
index 79fd8f9608..ddc6bca903 100644
--- a/tests/library/web-socket.spec.ts
+++ b/tests/library/web-socket.spec.ts
@@ -259,9 +259,9 @@ it('should send extra HTTP headers on WebSocket handshake', {
it('should send extra HTTP headers on WebSocket handshake from a worker', {
annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/28948' },
-}, async ({ page, server, browserName, browserMajorVersion }) => {
+}, async ({ page, server, browserName, browserMajorVersion, isBidi }) => {
it.fixme(browserName === 'chromium' && browserMajorVersion < 151, 'Chromium before 151 does not send extra HTTP headers on WebSocket handshake');
- it.fixme(browserName === 'firefox', 'Firefox does not associate a WebSocket opened inside a worker with its browsing context');
+ it.fixme(browserName === 'firefox' && !isBidi, 'Firefox/Juggler does not associate a WebSocket opened inside a worker with its browsing context');
await page.setExtraHTTPHeaders({ foo: 'bar' });
await page.goto(server.EMPTY_PAGE);