Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(chromium): disable AvoidCorsURLLoaderRestartOnRedirect (#43249)

Pavel Feldmanbcecebc303ac
diff --git a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts b/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
index 65d568e917..32c3375c96 100644
--- a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
+++ b/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
@@ -37,6 +37,9 @@ const disabledFeatures = [
// Chromium 149 rejects re-applying the `origin` header on a redirect (as request interception
// does) with net::ERR_INVALID_ARGUMENT. See https://github.com/microsoft/playwright/issues/41690
'BlockOriginHeaderModificationOnRedirect',
+ // Chromium 155 aborts preflighted cross-origin redirects with net::ERR_ABORTED while
+ // Fetch interception is enabled. See https://github.com/microsoft/playwright/issues/43242
+ 'AvoidCorsURLLoaderRestartOnRedirect',
// See https://github.com/microsoft/playwright/issues/16126
'Translate',
// See https://issues.chromium.org/u/1/issues/435410220
diff --git a/tests/page/page-route.spec.ts b/tests/page/page-route.spec.ts
index 9463430a78..cc3a007e43 100644
--- a/tests/page/page-route.spec.ts
+++ b/tests/page/page-route.spec.ts
@@ -15,6 +15,7 @@
* limitations under the License.
*/
+import type * as http from 'http';
import type { Route } from 'playwright-core';
import { test as it, expect } from './pageTest';
@@ -870,6 +871,42 @@ it('should support cors with credentials', async ({ page, server }) => {
expect(resp).toEqual(['electric', 'gas']);
});
+it('should not abort preflighted cross-origin redirect when a route is registered', {
+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/43242' },
+}, async ({ page, server, isAndroid }) => {
+ it.skip(isAndroid, 'No cross-process on Android');
+
+ const allowCors = (request: http.IncomingMessage, response: http.ServerResponse) => {
+ response.setHeader('Access-Control-Allow-Origin', request.headers.origin || '*');
+ response.setHeader('Access-Control-Allow-Credentials', 'true');
+ response.setHeader('Access-Control-Allow-Headers', 'x-app-version');
+ if (request.method !== 'OPTIONS')
+ return false;
+ response.writeHead(204);
+ response.end();
+ return true;
+ };
+ server.setRoute('/download', (request, response) => {
+ if (allowCors(request, response))
+ return;
+ response.writeHead(302, { location: `${server.PREFIX}/file` });
+ response.end();
+ });
+ server.setRoute('/file', (request, response) => {
+ if (allowCors(request, response))
+ return;
+ response.end('file contents');
+ });
+
+ await page.goto(server.EMPTY_PAGE);
+ await page.route('**/never-matches', route => route.continue());
+ const result = await page.evaluate(async url => {
+ const response = await fetch(url, { credentials: 'include', headers: { 'X-App-Version': '1.2.3' } });
+ return `${response.status} ${await response.text()}`;
+ }, server.CROSS_PROCESS_PREFIX + '/download');
+ expect(result).toBe('200 file contents');
+});
+
it('should reject cors with disallowed credentials', async ({ page, server }) => {
await page.goto(server.EMPTY_PAGE);
await page.route('**/cars', async route => {