Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(breaking): do not include hidden elements in aria snapshot (#35684)
Pavel Feldmanbd89ddaca43f
diff --git a/packages/injected/src/ariaSnapshot.ts b/packages/injected/src/ariaSnapshot.tsindex af310747aa..7f7b72c356 100644--- a/packages/injected/src/ariaSnapshot.ts+++ b/packages/injected/src/ariaSnapshot.ts@@ -17,7 +17,7 @@import { Map, Set } from '@isomorphic/builtins';import { escapeRegExp, longestCommonSubstring, normalizeWhiteSpace } from '@isomorphic/stringUtils';-import { getElementComputedStyle, getGlobalOptions } from './domUtils';+import { getElementComputedStyle, getGlobalOptions, isElementVisible } from './domUtils';import * as roleUtils from './roleUtils';import { yamlEscapeKeyIfNeeded, yamlEscapeValueIfNeeded } from './yaml';@@ -86,6 +86,10 @@ export function generateAriaTree(rootElement: Element, generation: number): Aria}}+ // Skip all the leaf nodes that are not visible as they can't be interacted with.+ if (!ariaChildren.length && !isElementVisible(element))+ return;+addElement(element);const childAriaNode = toAriaNode(element);if (childAriaNode)diff --git a/tests/library/inspector/cli-codegen-aria.spec.ts b/tests/library/inspector/cli-codegen-aria.spec.tsindex a11cf33342..9a81f25f73 100644--- a/tests/library/inspector/cli-codegen-aria.spec.ts+++ b/tests/library/inspector/cli-codegen-aria.spec.ts@@ -68,7 +68,6 @@ test.describe(() => {await recorder.trustedClick();await recorder.recorderPage.getByRole('tab', { name: 'Aria' }).click();await expect(recorder.recorderPage.locator('.tab-aria .CodeMirror')).toMatchAriaSnapshot(`- - textbox- text: '- button "Submit"'`);});diff --git a/tests/page/page-aria-snapshot.spec.ts b/tests/page/page-aria-snapshot.spec.tsindex 196402361f..5e3f0cf93a 100644--- a/tests/page/page-aria-snapshot.spec.ts+++ b/tests/page/page-aria-snapshot.spec.ts@@ -730,3 +730,15 @@ it('ref mode can be used to stitch all frame snapshots', async ({ page, server }- text: Hi, I'm frame`.trim());});++it('should not include hidden input elements', async ({ page }) => {+ await page.setContent(`+ <button>One</button>+ <button style="width: 0; height: 0; appearance: none; border: 0; padding: 0;">Two</button>+ <button>Three</button>+ `);++ const snapshot = await page.locator('body').ariaSnapshot();+ expect(snapshot).toContain(`- button \"One\"+- button \"Three\"`);+});