Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(android): dont pass "--disable-sync" (#38301)

Simon Knottc5861f32dc7c
diff --git a/packages/playwright-core/src/server/android/android.ts b/packages/playwright-core/src/server/android/android.ts
index 077d0569bc..81b3346dab 100644
--- a/packages/playwright-core/src/server/android/android.ts
+++ b/packages/playwright-core/src/server/android/android.ts
@@ -287,7 +287,7 @@ export class AndroidDevice extends SdkObject {
'--disable-fre',
'--no-default-browser-check',
`--remote-debugging-socket-name=${socketName}`,
- ...chromiumSwitches(),
+ ...chromiumSwitches(undefined, undefined, true),
...this._innerDefaultArgs(options)
];
return chromeArguments;
diff --git a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts b/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
index ca98372dd5..28d6928455 100644
--- a/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
+++ b/packages/playwright-core/src/server/chromium/chromiumSwitches.ts
@@ -47,7 +47,7 @@ const disabledFeatures = (assistantMode?: boolean) => [
assistantMode ? 'AutomationControlled' : '',
].filter(Boolean);
-export const chromiumSwitches = (assistantMode?: boolean, channel?: string) => [
+export const chromiumSwitches = (assistantMode?: boolean, channel?: string, android?: boolean) => [
'--disable-field-trial-config', // https://source.chromium.org/chromium/chromium/src/+/main:testing/variations/README.md
'--disable-background-networking',
'--disable-background-timer-throttling',
@@ -90,5 +90,5 @@ export const chromiumSwitches = (assistantMode?: boolean, channel?: string) => [
// Less annoying popups.
'--disable-search-engine-choice-screen',
// Prevents the "three dots" menu crash in IdentityManager::HasPrimaryAccount for ephemeral contexts.
- '--disable-sync',
+ android ? '' : '--disable-sync',
].filter(Boolean);