Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(trace-viewer): neutralize object and embed tags in snapshot renderer (#40761)
Sebastien Tardifc6a06ed1127b
diff --git a/packages/isomorphic/trace/snapshotRenderer.ts b/packages/isomorphic/trace/snapshotRenderer.tsindex b031ea9f1c..73ab493826 100644--- a/packages/isomorphic/trace/snapshotRenderer.ts+++ b/packages/isomorphic/trace/snapshotRenderer.ts@@ -140,6 +140,10 @@ export class SnapshotRenderer {// crafted trace could include them.attrName = '__playwright_' + attr.toLowerCase() + '__';}+ if (upperName === 'OBJECT' && attr.toLowerCase() === 'data')+ attrName = '__playwright_data__';+ if (upperName === 'EMBED' && attr.toLowerCase() === 'src')+ attrName = '__playwright_src__';if (isImg && attr === kCurrentSrcAttribute) {// Render currentSrc for images, so that trace viewer does not accidentally// resolve srcset to a different source.diff --git a/tests/library/snapshot-renderer.spec.ts b/tests/library/snapshot-renderer.spec.tsindex 1bdc21ab3f..0dd0d7900c 100644--- a/tests/library/snapshot-renderer.spec.ts+++ b/tests/library/snapshot-renderer.spec.ts@@ -84,6 +84,24 @@ test('snapshot renderer neutralizes iframe sandbox', () => {expect(html).toContain('__playwright_sandbox__');});+test('snapshot renderer neutralizes object data attribute', () => {+ const renderer = new SnapshotRenderer(new LRUCache(1_000_000), [], [makeSnapshot({+ html: ['HTML', {}, ['BODY', {}, ['OBJECT', { 'data': '/sha1/malicious', 'type': 'text/html' }]]],+ })], [], 0);+ const { html } = renderer.render();+ expect(html).not.toContain(' data=');+ expect(html).toContain('__playwright_data__');+});++test('snapshot renderer neutralizes embed src attribute', () => {+ const renderer = new SnapshotRenderer(new LRUCache(1_000_000), [], [makeSnapshot({+ html: ['HTML', {}, ['BODY', {}, ['EMBED', { 'src': '/sha1/malicious', 'type': 'text/html' }]]],+ })], [], 0);+ const { html } = renderer.render();+ expect(html).not.toContain(' src=');+ expect(html).toContain('__playwright_src__');+});+test('snapshot renderer handles case-insensitive iframe tag names', () => {const renderer = new SnapshotRenderer(new LRUCache(1_000_000), [], [makeSnapshot({html: ['HTML', {}, ['BODY', {}, ['iframe', { 'srcdoc': '<script>alert(1)</script>', 'src': 'http://evil.com' }]]],