Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(electron): pass port via switches not args (#39012)
Pavel Feldmanc86a07249906
diff --git a/packages/playwright-core/src/server/electron/electron.ts b/packages/playwright-core/src/server/electron/electron.tsindex 98ab309f28..c4d10deb81 100644--- a/packages/playwright-core/src/server/electron/electron.ts+++ b/packages/playwright-core/src/server/electron/electron.ts@@ -156,8 +156,8 @@ export class Electron extends SdkObject {async launch(progress: Progress, options: Omit<channels.ElectronLaunchParams, 'timeout'>): Promise<ElectronApplication> {let app: ElectronApplication | undefined = undefined;- // --remote-debugging-port=0 must be the last playwright's argument, loader.ts relies on it.- let electronArguments = ['--inspect=0', '--remote-debugging-port=0', ...(options.args || [])];+ // --inspect=0 must be the last playwright's argument, loader.ts relies on it.+ let electronArguments = ['--inspect=0', ...(options.args || [])];if (os.platform() === 'linux') {if (!options.chromiumSandbox && electronArguments.indexOf('--no-sandbox') === -1)diff --git a/packages/playwright-core/src/server/electron/loader.ts b/packages/playwright-core/src/server/electron/loader.tsindex c3aee60db9..534fc5300f 100644--- a/packages/playwright-core/src/server/electron/loader.ts+++ b/packages/playwright-core/src/server/electron/loader.ts@@ -21,7 +21,9 @@ const { chromiumSwitches } = require('../chromium/chromiumSwitches');// Always pass user arguments first, see https://github.com/microsoft/playwright/issues/16614 and// https://github.com/microsoft/playwright/issues/29198.// [Electron, -r, loader.js[, --no-sandbox>], --inspect=0, --remote-debugging-port=0, ...args]-process.argv.splice(1, process.argv.indexOf('--remote-debugging-port=0'));+process.argv.splice(1, process.argv.indexOf('--inspect=0'));++app.commandLine.appendSwitch('remote-debugging-port', '0');for (const arg of chromiumSwitches()) {const match = arg.match(/--([^=]*)=?(.*)/)!;