Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: emit snapshot when browser closes (#37241)

Simon Knottc923ff527398
diff --git a/packages/playwright-core/src/server/debugController.ts b/packages/playwright-core/src/server/debugController.ts
index 4efe0c8f21..850ddaeed2 100644
--- a/packages/playwright-core/src/server/debugController.ts
+++ b/packages/playwright-core/src/server/debugController.ts
@@ -78,6 +78,9 @@ export class DebugController extends SdkObject {
page.on(Page.Events.Close, () => this._disposeListeners.delete(dispose));
},
onPageClose: () => this._emitSnapshot(false),
+ onBrowserClose: () => {
+ this._emitSnapshot(false);
+ },
};
this._playwright.instrumentation.addListener(listener, null);
this._disposeListeners.add(() => this._playwright.instrumentation.removeListener(listener));
diff --git a/tests/library/debug-controller.spec.ts b/tests/library/debug-controller.spec.ts
index 8d8ec44ba9..8109e4171a 100644
--- a/tests/library/debug-controller.spec.ts
+++ b/tests/library/debug-controller.spec.ts
@@ -428,6 +428,13 @@ test('should not work with browser._launchServer(_debugController: false)', asyn
});
test('should support closing browsers', async ({ backend, connectedBrowser }) => {
+ const events: channels.DebugControllerStateChangedEvent[] = [];
+ backend.on('stateChanged', event => events.push(event));
+ await backend.setReportStateChanged({ enabled: true });
+ await connectedBrowser.newPage();
+
await backend.closeBrowser({ id: (connectedBrowser as any)._guid, reason: 'some reason' });
await expect.poll(() => connectedBrowser.isConnected()).toBe(false);
+
+ await expect.poll(() => events[events.length - 1]?.browsers).toEqual([]);
});