Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

feat(trace-viewer): add copy to clipboard button of snapshot url on hover (#35213) (#35255)

alscottycb7f1121ee41
diff --git a/packages/trace-viewer/src/ui/browserFrame.css b/packages/trace-viewer/src/ui/browserFrame.css
index 9293e1a1d8..e4fbdfdd4c 100644
--- a/packages/trace-viewer/src/ui/browserFrame.css
+++ b/packages/trace-viewer/src/ui/browserFrame.css
@@ -34,6 +34,16 @@
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
+ display: flex;
+ align-items: center;
+}
+
+.browser-frame-address-bar > button {
+ visibility: hidden;
+}
+
+.browser-frame-address-bar:hover > button {
+ visibility: visible;
}
.browser-frame-menu-bar {
diff --git a/packages/trace-viewer/src/ui/browserFrame.tsx b/packages/trace-viewer/src/ui/browserFrame.tsx
index 53cece1c8f..20dac3e134 100644
--- a/packages/trace-viewer/src/ui/browserFrame.tsx
+++ b/packages/trace-viewer/src/ui/browserFrame.tsx
@@ -16,17 +16,26 @@
import './browserFrame.css';
import * as React from 'react';
+import { CopyToClipboard } from './copyToClipboard';
export const BrowserFrame: React.FunctionComponent<{
url?: string,
-}> = ({ url }) => {
+}> = ({ url }): React.ReactElement => {
return <div className='browser-frame-header'>
<div style={{ whiteSpace: 'nowrap' }}>
<span className='browser-frame-dot' style={{ backgroundColor: 'rgb(242, 95, 88)' }}></span>
<span className='browser-frame-dot' style={{ backgroundColor: 'rgb(251, 190, 60)' }}></span>
<span className='browser-frame-dot' style={{ backgroundColor: 'rgb(88, 203, 66)' }}></span>
</div>
- <div className='browser-frame-address-bar' title={url || 'about:blank'}>{url || 'about:blank'}</div>
+ <div
+ className='browser-frame-address-bar'
+ title={url || 'about:blank'}
+ >
+ {url || 'about:blank'}
+ {url && (
+ <CopyToClipboard value={url} />
+ )}
+ </div>
<div style={{ marginLeft: 'auto' }}>
<div>
<span className='browser-frame-menu-bar'></span>
diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts
index 05887ab6bf..45813944d2 100644
--- a/tests/library/trace-viewer.spec.ts
+++ b/tests/library/trace-viewer.spec.ts
@@ -467,7 +467,15 @@ test('should show snapshot URL', async ({ page, runAndTrace, server }) => {
await page.evaluate('2+2');
});
await traceViewer.snapshotFrame('page.evaluate');
- await expect(traceViewer.page.locator('.browser-frame-address-bar')).toHaveText(server.EMPTY_PAGE);
+ const browserFrameAddressBarLocator = traceViewer.page.locator('.browser-frame-address-bar');
+ await expect(browserFrameAddressBarLocator).toHaveText(server.EMPTY_PAGE);
+ const copySelectorLocator = browserFrameAddressBarLocator.getByRole('button', { name: 'Copy' });
+ await expect(copySelectorLocator).toBeHidden();
+ await browserFrameAddressBarLocator.hover();
+ await expect(copySelectorLocator).toBeVisible();
+ await traceViewer.page.context().grantPermissions(['clipboard-read', 'clipboard-write']);
+ await copySelectorLocator.click();
+ expect(await traceViewer.page.evaluate(() => navigator.clipboard.readText())).toBe(server.EMPTY_PAGE);
});
test('should popup snapshot', async ({ page, runAndTrace, server }) => {