Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix: `exposeBinding` should work in parallel (#37721)
Simon Knottce1082ec9fe9
diff --git a/packages/playwright-core/src/server/browserContext.ts b/packages/playwright-core/src/server/browserContext.tsindex 1866e05a21..9edfd3a43f 100644--- a/packages/playwright-core/src/server/browserContext.ts+++ b/packages/playwright-core/src/server/browserContext.ts@@ -93,7 +93,7 @@ export abstract class BrowserContext extends SdkObject {_closeReason: string | undefined;readonly clock: Clock;_clientCertificatesProxy: ClientCertificatesProxy | undefined;- private _playwrightBindingExposed = false;+ private _playwrightBindingExposed?: Promise<void>;readonly dialogManager: DialogManager;constructor(browser: Browser, options: types.BrowserContextOptions, browserContextId: string | undefined) {@@ -304,19 +304,19 @@ export abstract class BrowserContext extends SdkObject {}async exposePlaywrightBindingIfNeeded() {- if (this._playwrightBindingExposed)- return;- this._playwrightBindingExposed = true;- await this.doExposePlaywrightBinding();+ this._playwrightBindingExposed ??= (async () => {+ await this.doExposePlaywrightBinding();- this.bindingsInitScript = PageBinding.createInitScript();- this.initScripts.push(this.bindingsInitScript);- await this.doAddInitScript(this.bindingsInitScript);- await this.safeNonStallingEvaluateInAllFrames(this.bindingsInitScript.source, 'main');+ this.bindingsInitScript = PageBinding.createInitScript();+ this.initScripts.push(this.bindingsInitScript);+ await this.doAddInitScript(this.bindingsInitScript);+ await this.safeNonStallingEvaluateInAllFrames(this.bindingsInitScript.source, 'main');+ })();+ return await this._playwrightBindingExposed;}- needsPlaywrightBinding() {- return this._playwrightBindingExposed;+ needsPlaywrightBinding(): boolean {+ return this._playwrightBindingExposed !== undefined;}async exposeBinding(progress: Progress, name: string, needsHandle: boolean, playwrightBinding: frames.FunctionWithSource, forClient?: unknown): Promise<PageBinding> {diff --git a/tests/page/page-expose-function.spec.ts b/tests/page/page-expose-function.spec.tsindex e9334c4df0..8bafdff2b3 100644--- a/tests/page/page-expose-function.spec.ts+++ b/tests/page/page-expose-function.spec.ts@@ -292,3 +292,14 @@ it('should fail with busted Array.prototype.toJSON', async ({ page }) => {expect.soft(await page.evaluate(() => ([] as any).toJSON())).toBe('"[]"');});++it('exposeBinding should work in parallel', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/37712' } }, async ({ page }) => {+ await Promise.all([+ page.exposeBinding('foo', () => 42),+ page.exposeBinding('bar', () => 42),+ ]);+ await page.evaluate(() => {+ (window as any).foo();+ (window as any).bar();+ });+});