Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(bidi): don't deserialize the toString property (#42677)

Holger Benld78a9e71f256
diff --git a/packages/playwright-core/src/server/bidi/bidiDeserializer.ts b/packages/playwright-core/src/server/bidi/bidiDeserializer.ts
index bd09192d65..31b4d34979 100644
--- a/packages/playwright-core/src/server/bidi/bidiDeserializer.ts
+++ b/packages/playwright-core/src/server/bidi/bidiDeserializer.ts
@@ -108,8 +108,10 @@ function deserializeBidiMapping(
typeof serializedKey === 'string'
? serializedKey
: deserializeBidiValue(serializedKey, internalIdMap);
- const value = deserializeBidiValue(serializedValue, internalIdMap);
- result[key] = value;
+ if (key !== 'toString') {
+ const value = deserializeBidiValue(serializedValue, internalIdMap);
+ result[key] = value;
+ }
}
return result;
}
diff --git a/tests/page/page-event-console.spec.ts b/tests/page/page-event-console.spec.ts
index 883db6d4de..7e373a2826 100644
--- a/tests/page/page-event-console.spec.ts
+++ b/tests/page/page-event-console.spec.ts
@@ -130,6 +130,19 @@ it('should not fail for window object', async ({ page, browserName, isBidi }) =>
expect(message.text()).toEqual('JSHandle@object');
});
+it(`should not fail for object that can't be coerced to a primitive`, async ({ page, browserName, isBidi }) => {
+ let message = null;
+ page.once('console', msg => message = msg);
+ await Promise.all([
+ page.evaluate(() => console.log({ toString() { return {}; }, valueOf() { return {}; } })),
+ page.waitForEvent('console')
+ ]);
+ if (browserName !== 'firefox' || isBidi)
+ expect(message.text()).toMatch(/\{toString: (Function)?, valueOf: (Function)?\}/);
+ else
+ expect(message.text()).toEqual('JSHandle@object');
+});
+
it('should trigger correct Log', async ({ page, server, browserName, isWindows }) => {
it.skip(browserName === 'webkit' && isWindows, 'Upstream issue https://bugs.webkit.org/show_bug.cgi?id=229515');
await page.goto('about:blank');