Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

Fix bidi screenshot quality=0 being treated as 80% (#39744)

Karesansuid7d8e5bed138
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index f94fe48c1a..017259d6b0 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -480,7 +480,7 @@ export class BidiPage implements PageDelegate {
context: this._session.sessionId,
format: {
type: `image/${format === 'png' ? 'png' : 'jpeg'}`,
- quality: quality ? quality / 100 : 0.8,
+ quality: quality !== undefined ? quality / 100 : undefined,
},
origin: documentRect ? 'document' : 'viewport',
clip: {
diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts
index 3cfbd8efb0..00a58c99f5 100644
--- a/tests/page/page-screenshot.spec.ts
+++ b/tests/page/page-screenshot.spec.ts
@@ -394,6 +394,13 @@ it.describe('page screenshot', () => {
expect(error.message).toContain('options.quality is unsupported for the png');
});
+ it('quality option should work for jpeg', async ({ page, server }) => {
+ await page.goto(server.PREFIX + '/grid.html');
+ const zeroQuality = await page.screenshot({ type: 'jpeg', quality: 0 });
+ const highQuality = await page.screenshot({ type: 'jpeg', quality: 100 });
+ expect(zeroQuality.byteLength).toBeLessThan(highQuality.byteLength);
+ });
+
it('should prefer type over extension', async ({ page }, testInfo) => {
const outputPath = testInfo.outputPath('file.png');
const buffer = await page.screenshot({ path: outputPath, type: 'jpeg' });