Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): enable webp screenshot support (#41849)

Holger Benlda345fbc372d
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index 1d4a08b470..b8fcdb1191 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -502,13 +502,11 @@ export class BidiPage implements PageDelegate {
}
async takeScreenshot(progress: Progress, format: string, documentRect: types.Rect | undefined, viewportRect: types.Rect | undefined, quality: number | undefined, fitsViewport: boolean, scale: 'css' | 'device'): Promise<Buffer> {
- if (format === 'webp')
- throw new Error('webp screenshots are not supported via WebDriver BiDi');
const rect = (documentRect || viewportRect)!;
const { data } = await progress.race(this._session.send('browsingContext.captureScreenshot', {
context: this._session.sessionId,
format: {
- type: `image/${format === 'png' ? 'png' : 'jpeg'}`,
+ type: `image/${format === 'png' || format === 'webp' ? format : 'jpeg'}`,
quality: quality !== undefined ? quality / 100 : undefined,
},
origin: documentRect ? 'document' : 'viewport',
diff --git a/tests/page/elementhandle-screenshot.spec.ts b/tests/page/elementhandle-screenshot.spec.ts
index a5b206e98c..5738230cb6 100644
--- a/tests/page/elementhandle-screenshot.spec.ts
+++ b/tests/page/elementhandle-screenshot.spec.ts
@@ -35,9 +35,7 @@ it.describe('element screenshot', () => {
expect(screenshot).toMatchSnapshot('screenshot-element-bounding-box.png');
});
- it('should work with webp', async ({ page, server, isBidi }) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
-
+ it('should work with webp', async ({ page, server }) => {
await page.setViewportSize({ width: 500, height: 500 });
await page.goto(server.PREFIX + '/grid.html');
const elementHandle = await page.$('.box:nth-of-type(3)');
diff --git a/tests/page/page-screenshot.spec.ts b/tests/page/page-screenshot.spec.ts
index 1810515829..6daca69121 100644
--- a/tests/page/page-screenshot.spec.ts
+++ b/tests/page/page-screenshot.spec.ts
@@ -279,9 +279,7 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('white.jpg');
});
- it('should produce a valid webp screenshot', async ({ page, server, isBidi }) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
-
+ it('should produce a valid webp screenshot', async ({ page, server }) => {
await page.setViewportSize({ width: 300, height: 300 });
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => (document.body.style.background = 'rgb(255, 0, 0)'));
@@ -289,9 +287,7 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('red.webp');
});
- it('path option should detect webp', async ({ page, server, isBidi }, testInfo) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
-
+ it('path option should detect webp', async ({ page, server }, testInfo) => {
await page.setViewportSize({ width: 300, height: 300 });
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => (document.body.style.background = 'rgb(255, 0, 0)'));
@@ -301,25 +297,21 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('red.webp');
});
- it('quality option should work for webp', async ({ page, server, isBidi }) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
-
+ it('quality option should work for webp', async ({ page, server }) => {
await page.goto(server.PREFIX + '/grid.html');
const lowQuality = await page.screenshot({ type: 'webp', quality: 0 });
const highQuality = await page.screenshot({ type: 'webp', quality: 100 });
expect(lowQuality.byteLength).toBeLessThan(highQuality.byteLength);
});
- it('webp screenshots should be lossless by default', async ({ page, server, isBidi }) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
-
+ it('webp screenshots should be lossless by default', async ({ page, server }) => {
await page.goto(server.PREFIX + '/grid.html');
expect(utils.isLosslessWebp(await page.screenshot({ type: 'webp' }))).toBe(true);
expect(utils.isLosslessWebp(await page.screenshot({ type: 'webp', quality: 80 }))).toBe(false);
});
it('should allow transparency with webp', async ({ page, browserName, isBidi }) => {
- it.skip(isBidi, 'webp screenshots are not supported via WebDriver BiDi');
+ it.skip(isBidi, 'transparency is not supported via WebDriver BiDi');
it.fail(browserName === 'firefox');
await page.setViewportSize({ width: 300, height: 300 });
diff --git a/tests/page/page-screenshot.spec.ts-snapshots/red-bidi-chromium.webp b/tests/page/page-screenshot.spec.ts-snapshots/red-bidi-chromium.webp
new file mode 100644
index 0000000000..a420da6c5b
Binary files /dev/null and b/tests/page/page-screenshot.spec.ts-snapshots/red-bidi-chromium.webp differ
diff --git a/tests/page/page-screenshot.spec.ts-snapshots/red-moz-firefox-nightly.webp b/tests/page/page-screenshot.spec.ts-snapshots/red-moz-firefox-nightly.webp
new file mode 100644
index 0000000000..8c12295c4c
Binary files /dev/null and b/tests/page/page-screenshot.spec.ts-snapshots/red-moz-firefox-nightly.webp differ