Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(html): improve HTML report payload loading speeds (#36768)

Adam Gastineaude9fde32c6c4
diff --git a/packages/html-reporter/src/index.tsx b/packages/html-reporter/src/index.tsx
index 84763267c4..89a44fe026 100644
--- a/packages/html-reporter/src/index.tsx
+++ b/packages/html-reporter/src/index.tsx
@@ -36,11 +36,13 @@ document.head.appendChild(link);
const ReportLoader: React.FC = () => {
const [report, setReport] = React.useState<LoadedReport | undefined>();
React.useEffect(() => {
- if (report)
- return;
const zipReport = new ZipReport();
- zipReport.load().then(() => setReport(zipReport));
- }, [report]);
+ zipReport.load().then(() => {
+ // Drop node after consumption
+ document.getElementById('playwrightReportBase64')?.remove();
+ setReport(zipReport);
+ });
+ }, []);
return <SearchParamsProvider>
<ReportView report={report} />
</SearchParamsProvider>;
@@ -58,8 +60,9 @@ class ZipReport implements LoadedReport {
async load() {
const zipURI = await new Promise<string>(resolve => {
- if (window.playwrightReportBase64)
- return resolve(window.playwrightReportBase64);
+ const element = document.getElementById('playwrightReportBase64');
+ if (!!element?.textContent)
+ return resolve(element.textContent);
if (window.opener) {
const listener = (event: MessageEvent) => {
if (event.source === window.opener) {
diff --git a/packages/playwright/src/reporters/html.ts b/packages/playwright/src/reporters/html.ts
index eb34ab0192..cf72861604 100644
--- a/packages/playwright/src/reporters/html.ts
+++ b/packages/playwright/src/reporters/html.ts
@@ -329,7 +329,8 @@ class HtmlBuilder {
const popup = window.open(hmrURL);
const listener = (evt: MessageEvent) => {
if (evt.source === popup && evt.data === 'ready') {
- popup!.postMessage((window as any).playwrightReportBase64, hmrURL.origin);
+ const element = document.getElementById('playwrightReportBase64');
+ popup!.postMessage(element?.textContent ?? '', hmrURL.origin);
window.removeEventListener('message', listener);
// This is generally not allowed
window.close();
@@ -372,7 +373,7 @@ class HtmlBuilder {
}
private async _writeReportData(filePath: string) {
- fs.appendFileSync(filePath, '<script>\nwindow.playwrightReportBase64 = "data:application/zip;base64,');
+ fs.appendFileSync(filePath, '<script id="playwrightReportBase64" type="application/zip">data:application/zip;base64,');
await new Promise(f => {
this._dataZipFile!.end(undefined, () => {
this._dataZipFile!.outputStream
@@ -380,7 +381,7 @@ class HtmlBuilder {
.pipe(fs.createWriteStream(filePath, { flags: 'a' })).on('close', f);
});
});
- fs.appendFileSync(filePath, '";</script>');
+ fs.appendFileSync(filePath, '"</script>');
}
private _addDataFile(fileName: string, data: any) {