Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
Revert "chore(chromium): pass auto attach filter for iframes (#36784)" (#37607)
Yury Semikhatskye0f42b6b3c95
diff --git a/packages/playwright-core/src/server/chromium/crBrowser.ts b/packages/playwright-core/src/server/chromium/crBrowser.tsindex acee565940..ef6f16e7c8 100644--- a/packages/playwright-core/src/server/chromium/crBrowser.ts+++ b/packages/playwright-core/src/server/chromium/crBrowser.ts@@ -150,7 +150,7 @@ export class CRBrowser extends Browser {await Promise.all([...this._crPages.values()].map(crPage => crPage._page.waitForInitializedOrError()));}- _onAttachedToTarget({ targetInfo, sessionId }: Protocol.Target.attachedToTargetPayload) {+ _onAttachedToTarget({ targetInfo, sessionId, waitingForDebugger }: Protocol.Target.attachedToTargetPayload) {if (targetInfo.type === 'browser')return;const session = this._session.createChildSession(sessionId);diff --git a/packages/playwright-core/src/server/chromium/crPage.ts b/packages/playwright-core/src/server/chromium/crPage.tsindex df181ccec9..43f810ebd6 100644--- a/packages/playwright-core/src/server/chromium/crPage.ts+++ b/packages/playwright-core/src/server/chromium/crPage.ts@@ -525,16 +525,7 @@ class FrameSession {worldName: this._crPage.utilityWorldName,}),this._crPage._networkManager.addSession(this._client, undefined, this._isMainFrame()),- this._client.send('Target.setAutoAttach', {- autoAttach: true,- waitForDebuggerOnStart: true,- flatten: true,- filter: [- { type: 'iframe' },- { type: 'worker' },- { type: 'service_worker', exclude: !process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS }- ]- }),+ this._client.send('Target.setAutoAttach', { autoAttach: true, waitForDebuggerOnStart: true, flatten: true }),];if (!this._page.isStorageStatePage) {if (this._crPage._browserContext.needsPlaywrightBinding())@@ -764,15 +755,7 @@ class FrameSession {// TODO: attribute workers to the right frame.this._crPage._networkManager.addSession(session, this._page.frameManager.frame(this._targetId) ?? undefined).catch(() => {});session._sendMayFail('Runtime.runIfWaitingForDebugger');- session._sendMayFail('Target.setAutoAttach', {- autoAttach: true,- waitForDebuggerOnStart: true,- flatten: true,- filter: [- { type: 'worker' },- { type: 'service_worker', exclude: !process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS }- ]- });+ session._sendMayFail('Target.setAutoAttach', { autoAttach: true, waitForDebuggerOnStart: true, flatten: true });session.on('Target.attachedToTarget', event => this._onAttachedToTarget(event));session.on('Target.detachedFromTarget', event => this._onDetachedFromTarget(event));session.on('Runtime.consoleAPICalled', event => {