Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(bidi): add support for the browsingContext.download* events (#37299)
Holger Benle366a3b2606e
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.tsindex 505b1ae5bf..fb48288952 100644--- a/packages/playwright-core/src/server/bidi/bidiPage.ts+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts@@ -75,6 +75,8 @@ export class BidiPage implements PageDelegate {eventsHelper.addEventListener(bidiSession, 'browsingContext.historyUpdated', this._onHistoryUpdated.bind(this)),eventsHelper.addEventListener(bidiSession, 'browsingContext.domContentLoaded', this._onDomContentLoaded.bind(this)),eventsHelper.addEventListener(bidiSession, 'browsingContext.load', this._onLoad.bind(this)),+ eventsHelper.addEventListener(bidiSession, 'browsingContext.downloadWillBegin', this._onDownloadWillBegin.bind(this)),+ eventsHelper.addEventListener(bidiSession, 'browsingContext.downloadEnd', this._onDownloadEnded.bind(this)),eventsHelper.addEventListener(bidiSession, 'browsingContext.userPromptOpened', this._onUserPromptOpened.bind(this)),eventsHelper.addEventListener(bidiSession, 'log.entryAdded', this._onLogEntryAdded.bind(this)),];@@ -217,6 +219,26 @@ export class BidiPage implements PageDelegate {event.defaultValue));}+ private _onDownloadWillBegin(event: bidi.BrowsingContext.DownloadWillBeginParams) {+ if (!event.navigation)+ return;++ let originPage = this._page.initializedOrUndefined();+ // If it's a new window download, report it on the opener page.+ if (!originPage && this._opener)+ originPage = this._opener._page.initializedOrUndefined();+ if (!originPage)+ return;++ this._browserContext._browser._downloadCreated(originPage, event.navigation, event.url, event.suggestedFilename);+ }++ private _onDownloadEnded(event: bidi.BrowsingContext.DownloadEndParams) {+ if (!event.navigation)+ return;+ this._browserContext._browser._downloadFinished(event.navigation, event.status === 'canceled' ? 'canceled' : undefined);+ }+private _onLogEntryAdded(params: bidi.Log.Entry) {if (params.type === 'javascript' && params.level === 'error') {let errorName = '';