Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(chromium): reject pending commands on all sessions when connection closes (#43221)
Pavel Feldmane41a93b0b05a
diff --git a/packages/playwright-core/src/server/chromium/crConnection.ts b/packages/playwright-core/src/server/chromium/crConnection.tsindex bdf9ab80d5..2fd4a2a264 100644--- a/packages/playwright-core/src/server/chromium/crConnection.ts+++ b/packages/playwright-core/src/server/chromium/crConnection.ts@@ -89,7 +89,8 @@ export class CRConnection extends SdkObject {this._transport.onmessage = undefined;this._transport.onclose = undefined;this._browserDisconnectedLogs = helper.formatBrowserLogs(this._browserLogsCollector.recentLogs(), reason);- this.rootSession.dispose();+ for (const session of [...this._sessions.values()])+ session.dispose();Promise.resolve().then(() => this.emit(ConnectionEvents.Disconnected));}diff --git a/tests/library/chromium/connect-over-cdp.spec.ts b/tests/library/chromium/connect-over-cdp.spec.tsindex e6346a0ce2..3d16f45e52 100644--- a/tests/library/chromium/connect-over-cdp.spec.ts+++ b/tests/library/chromium/connect-over-cdp.spec.ts@@ -179,6 +179,25 @@ test('should cleanup artifacts dir after connectOverCDP disconnects due to ws clexpect(exists2).toBe(false);});+test('should reject pending CDPSession calls when the browser is killed', {+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/43200' },+}, async ({ browserType }, testInfo) => {+ const port = 9339 + testInfo.workerIndex;+ const browserServer = await browserType.launchServer({+ args: ['--remote-debugging-port=' + port]+ });+ const cdpBrowser = await browserType.connectOverCDP({+ endpointURL: `http://127.0.0.1:${port}/`,+ });+ const context = cdpBrowser.contexts()[0];+ const page = await context.newPage();+ const session = await context.newCDPSession(page);+ const sendPromise = session.send('Runtime.evaluate', { expression: 'new Promise(() => {})', awaitPromise: true }).catch(e => e);+ await browserServer.kill();+ const error = await sendPromise;+ expect(error.message).toContain('Target page, context or browser has been closed');+});+test('should write traces to provided artifactsDir on connectOverCDP', async ({ browserType, toImpl, trace }, testInfo) => {test.skip(trace === 'on');