Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): close isolated HTTP client context on disconnect (#41560)

Pavel Feldmane4d4430c112c
diff --git a/packages/playwright-core/src/tools/mcp/program.ts b/packages/playwright-core/src/tools/mcp/program.ts
index e29d72fed0..f074c961e2 100644
--- a/packages/playwright-core/src/tools/mcp/program.ts
+++ b/packages/playwright-core/src/tools/mcp/program.ts
@@ -132,12 +132,18 @@ export function decorateMCPCommand(command: Command) {
},
disposed: async backend => {
clientCount--;
- if (sharedBrowserPromise && clientCount > 0)
+ const browserContext = (backend as BrowserBackend).browserContext;
+
+ if (sharedBrowserPromise && clientCount > 0) {
+ if (config.browser.isolated) {
+ testDebug('close context');
+ await browserContext.close().catch(() => { });
+ }
return;
+ }
testDebug('close browser');
sharedBrowserPromise = undefined;
- const browserContext = (backend as BrowserBackend).browserContext;
await browserContext.close().catch(() => { });
await browserContext.browser()?.close().catch(() => { });
}
diff --git a/tests/mcp/http.spec.ts b/tests/mcp/http.spec.ts
index 292e7e1275..85dca4f877 100644
--- a/tests/mcp/http.spec.ts
+++ b/tests/mcp/http.spec.ts
@@ -161,7 +161,7 @@ test('http transport browser sigint', async ({ serverEndpoint, server }) => {
});
});
-test('http transport browser lifecycle (isolated, multiclient)', async ({ serverEndpoint, server }) => {
+test('http transport browser lifecycle (isolated, multiclient)', { annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/41539' } }, async ({ serverEndpoint, server }) => {
const { url, stderr } = await serverEndpoint({ args: ['--isolated'] });
const transport1 = new StreamableHTTPClientTransport(new URL('/mcp', url));
@@ -200,6 +200,7 @@ test('http transport browser lifecycle (isolated, multiclient)', async ({ server
'delete http session': 3,
'create context': 3,
'create browser (isolated)': 1,
+ 'close context': 2,
'close browser': 1,
});
});
@@ -229,6 +230,7 @@ test('http transport browser lifecycle (isolated, concurrent clients)', { annota
'delete http session': 3,
'create context': 3,
'create browser (isolated)': 1,
+ 'close context': 2,
'close browser': 1,
});
});
diff --git a/tests/mcp/sse.spec.ts b/tests/mcp/sse.spec.ts
index 753b233d28..2ea74f488e 100644
--- a/tests/mcp/sse.spec.ts
+++ b/tests/mcp/sse.spec.ts
@@ -161,6 +161,7 @@ test('sse transport browser lifecycle (isolated, multiclient)', async ({ serverE
'delete SSE session': 3,
'create context': 3,
'create browser (isolated)': 1,
+ 'close context': 2,
'close browser': 1,
});
});