Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(extension): pass client name on token-bypass connect (#41845)

Akshat Anande8b395b2b02e
diff --git a/packages/extension/src/ui/connect.tsx b/packages/extension/src/ui/connect.tsx
index da32ceab19..2b7a54a4e4 100644
--- a/packages/extension/src/ui/connect.tsx
+++ b/packages/extension/src/ui/connect.tsx
@@ -27,11 +27,19 @@ type Status =
const SUPPORTED_PROTOCOL_VERSION = 2;
+// Client name comes from the URL and never changes for the lifetime of this page.
+const clientInfo = (() => {
+ try {
+ return JSON.parse(new URLSearchParams(window.location.search).get('client') || '{}').name || 'unknown';
+ } catch {
+ return 'unknown';
+ }
+})();
+
const ConnectApp: React.FC = () => {
const [tabs, setTabs] = useState<chrome.tabs.Tab[]>([]);
const [status, setStatus] = useState<Status | null>(null);
const [showTabList, setShowTabList] = useState(true);
- const [clientInfo, setClientInfo] = useState('unknown');
const setError = useCallback((message: string) => {
setShowTabList(false);
@@ -59,18 +67,10 @@ const ConnectApp: React.FC = () => {
return;
}
- try {
- const client = JSON.parse(params.get('client') || '{}');
- const info = `${client.name || 'unknown'}`;
- setClientInfo(info);
- setStatus({
- type: 'connecting',
- message: `"${info}" is trying to connect to the Playwright Extension.`
- });
- } catch (e) {
- setStatus({ type: 'error', message: 'Failed to parse client version.' });
- return;
- }
+ setStatus({
+ type: 'connecting',
+ message: `"${clientInfo}" is trying to connect to the Playwright Extension.`
+ });
const parsedVersion = parseInt(params.get('protocolVersion') ?? '', 10);
const requestedVersion = isNaN(parsedVersion) ? 1 : parsedVersion;
@@ -152,7 +152,7 @@ const ConnectApp: React.FC = () => {
message: `"${clientInfo}" failed to connect: ${e}`
});
}
- }, [clientInfo]);
+ }, []);
return (
<div className='app-container'>
diff --git a/tests/extension/extension.spec.ts b/tests/extension/extension.spec.ts
index b751297743..68c5c50b0a 100644
--- a/tests/extension/extension.spec.ts
+++ b/tests/extension/extension.spec.ts
@@ -322,7 +322,9 @@ test(`bypass connection dialog with token`, async ({ browserWithExtension, start
const token = await page.locator('.auth-token-code').textContent();
const [, value] = token?.split('=') || [];
+ const clientName = 'token-bypass-client';
const { client } = await startClient({
+ clientName,
args: [`--extension`],
env: {
PLAYWRIGHT_MCP_EXTENSION_TOKEN: value,
@@ -338,4 +340,7 @@ test(`bypass connection dialog with token`, async ({ browserWithExtension, start
expect(await navigateResponse).toHaveResponse({
snapshot: expect.stringContaining(`- generic [active] [ref=f1e1]: Hello, world!`),
});
+
+ await page.goto(`chrome-extension://${extensionId}/status.html`);
+ await expect(page.locator('.client-info')).toContainText(`Connected to "${clientName}"`);
});