Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): skip empty secret values when redacting responses (#39942)

Yury Semikhatskyeec8b3875225
diff --git a/packages/playwright-core/src/tools/backend/response.ts b/packages/playwright-core/src/tools/backend/response.ts
index 1e3514ae4e..3d7218c194 100644
--- a/packages/playwright-core/src/tools/backend/response.ts
+++ b/packages/playwright-core/src/tools/backend/response.ts
@@ -140,8 +140,11 @@ export class Response {
}
private _redactSecrets(text: string): string {
- for (const [secretName, secretValue] of Object.entries(this._context.config.secrets ?? {}))
+ for (const [secretName, secretValue] of Object.entries(this._context.config.secrets ?? {})) {
+ if (!secretValue)
+ continue;
text = text.replaceAll(secretValue, `<secret>${secretName}</secret>`);
+ }
return text;
}
diff --git a/tests/mcp/secrets.spec.ts b/tests/mcp/secrets.spec.ts
index 21d7f5503d..5d4e55a5d0 100644
--- a/tests/mcp/secrets.spec.ts
+++ b/tests/mcp/secrets.spec.ts
@@ -126,3 +126,29 @@ await page.getByRole('textbox', { name: 'Password' }).fill(process.env['X-PASSWO
inlineSnapshot: expect.stringContaining(`- textbox \"Password\" [active] [ref=e6]: <secret>X-PASSWORD</secret>`),
});
});
+
+test('empty secret value is ignored', async ({ startClient, server }) => {
+ const secretsFile = test.info().outputPath('secrets.env');
+ await fs.promises.writeFile(secretsFile, 'EMPTY_SECRET=\nX-PASSWORD=password123');
+
+ const { client } = await startClient({
+ args: ['--secrets', secretsFile],
+ });
+
+ server.setContent('/', `
+ <!DOCTYPE html>
+ <html>
+ <body><p>hello password123</p></body>
+ </html>
+ `, 'text/html');
+
+ const response = await client.callTool({
+ name: 'browser_navigate',
+ arguments: { url: server.PREFIX },
+ });
+
+ // Response should not be mangled by empty secret replacement
+ expect(response).toHaveResponse({
+ snapshot: expect.stringContaining(`<secret>X-PASSWORD</secret>`),
+ });
+});