Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore: allow local-network-access permission in chromium (#37871)

Yury Semikhatskyeed1f1910488
diff --git a/docs/src/api/class-browsercontext.md b/docs/src/api/class-browsercontext.md
index c49bef5832..3e7529c482 100644
--- a/docs/src/api/class-browsercontext.md
+++ b/docs/src/api/class-browsercontext.md
@@ -948,6 +948,8 @@ Here are some permissions that may be supported by some browsers:
* `'clipboard-write'`
* `'geolocation'`
* `'gyroscope'`
+* `'local-fonts'`
+* `'local-network-access'`
* `'magnetometer'`
* `'microphone'`
* `'midi-sysex'` (system-exclusive midi)
@@ -955,7 +957,6 @@ Here are some permissions that may be supported by some browsers:
* `'notifications'`
* `'payment-handler'`
* `'storage-access'`
-* `'local-fonts'`
### option: BrowserContext.grantPermissions.origin
* since: v1.8
diff --git a/packages/playwright-client/types/types.d.ts b/packages/playwright-client/types/types.d.ts
index 28c4b14a9e..df5bfa0bc2 100644
--- a/packages/playwright-client/types/types.d.ts
+++ b/packages/playwright-client/types/types.d.ts
@@ -8991,6 +8991,8 @@ export interface BrowserContext {
* - `'clipboard-write'`
* - `'geolocation'`
* - `'gyroscope'`
+ * - `'local-fonts'`
+ * - `'local-network-access'`
* - `'magnetometer'`
* - `'microphone'`
* - `'midi-sysex'` (system-exclusive midi)
@@ -8998,7 +9000,6 @@ export interface BrowserContext {
* - `'notifications'`
* - `'payment-handler'`
* - `'storage-access'`
- * - `'local-fonts'`
* @param options
*/
grantPermissions(permissions: ReadonlyArray<string>, options?: {
diff --git a/packages/playwright-core/src/server/chromium/crBrowser.ts b/packages/playwright-core/src/server/chromium/crBrowser.ts
index ef6f16e7c8..a81e3d88b9 100644
--- a/packages/playwright-core/src/server/chromium/crBrowser.ts
+++ b/packages/playwright-core/src/server/chromium/crBrowser.ts
@@ -435,6 +435,7 @@ export class CRBrowserContext extends BrowserContext {
['midi-sysex', 'midiSysex'],
['storage-access', 'storageAccess'],
['local-fonts', 'localFonts'],
+ ['local-network-access', 'localNetworkAccess'],
]);
const filtered = permissions.map(permission => {
const protocolPermission = webPermissionToProtocol.get(permission);
diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts
index 28c4b14a9e..df5bfa0bc2 100644
--- a/packages/playwright-core/types/types.d.ts
+++ b/packages/playwright-core/types/types.d.ts
@@ -8991,6 +8991,8 @@ export interface BrowserContext {
* - `'clipboard-write'`
* - `'geolocation'`
* - `'gyroscope'`
+ * - `'local-fonts'`
+ * - `'local-network-access'`
* - `'magnetometer'`
* - `'microphone'`
* - `'midi-sysex'` (system-exclusive midi)
@@ -8998,7 +9000,6 @@ export interface BrowserContext {
* - `'notifications'`
* - `'payment-handler'`
* - `'storage-access'`
- * - `'local-fonts'`
* @param options
*/
grantPermissions(permissions: ReadonlyArray<string>, options?: {
diff --git a/tests/library/permissions.spec.ts b/tests/library/permissions.spec.ts
index b723aee813..f753adc794 100644
--- a/tests/library/permissions.spec.ts
+++ b/tests/library/permissions.spec.ts
@@ -253,3 +253,51 @@ it.describe(() => {
expect(await page.evaluate(async () => (await (window as any).queryLocalFonts()).length > 0)).toBe(true);
});
});
+
+it('local network request is allowed from public origin', {
+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/37861' }
+}, async ({ page, context, server, browserName }) => {
+ it.fail(browserName === 'webkit');
+ if (browserName === 'chromium')
+ await context.grantPermissions(['local-network-access']);
+ const serverRequests = [];
+ server.setRoute('/cors', (req, res) => {
+ serverRequests.push(`${req.method} ${req.url}`);
+ if (req.method === 'OPTIONS') {
+ res.writeHead(204, {
+ 'Access-Control-Allow-Origin': '*',
+ 'Access-Control-Allow-Methods': 'GET, POST, PUT, OPTIONS',
+ 'Access-Control-Allow-Headers': '*',
+ });
+ res.end();
+ return;
+ }
+ res.writeHead(200, { 'Content-type': 'text/plain', 'Access-Control-Allow-Origin': '*' });
+ res.end('Hello there!');
+ });
+ const clientRequests = [];
+ // Has to be a public origin.
+ await page.goto('https://demo.playwright.dev/todomvc/');
+ page.on('request', request => {
+ clientRequests.push(`${request.method()} ${request.url()}`);
+ });
+ const response = await page.evaluate(async url => {
+ const response = await fetch(url, {
+ method: 'POST',
+ body: '',
+ headers: {
+ 'Content-Type': 'application/json',
+ 'X-Custom-Header': 'test-value'
+ }
+ });
+ return await response.text();
+ }, server.CROSS_PROCESS_PREFIX + '/cors').catch(e => e.message);
+ expect(response).toBe('Hello there!');
+ expect(serverRequests).toEqual([
+ 'OPTIONS /cors',
+ 'POST /cors',
+ ]);
+ expect(clientRequests).toEqual([
+ `POST ${server.CROSS_PROCESS_PREFIX}/cors`,
+ ]);
+});