Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(build): set esbuild target to node20 (#42657)

Pavel Feldmanefb0761d304a
diff --git a/packages/playwright-core/src/server/chromium/crPage.ts b/packages/playwright-core/src/server/chromium/crPage.ts
index 1e97cacbcc..30c993fb37 100644
--- a/packages/playwright-core/src/server/chromium/crPage.ts
+++ b/packages/playwright-core/src/server/chromium/crPage.ts
@@ -1145,7 +1145,7 @@ class FrameSession {
return null;
if (frame === this._page.mainFrame())
return { x: 0, y: 0 };
- const element = await frame.frameElement(nullProgress);
+ using element = await frame.frameElement(nullProgress);
const box = await element.boundingBox(nullProgress);
return box;
}
diff --git a/packages/playwright-core/src/server/javascript.ts b/packages/playwright-core/src/server/javascript.ts
index 0f549a0273..adaae310f1 100644
--- a/packages/playwright-core/src/server/javascript.ts
+++ b/packages/playwright-core/src/server/javascript.ts
@@ -223,6 +223,10 @@ export class JSHandle<T = any> extends SdkObject {
}
}
+ [Symbol.dispose]() {
+ this.dispose();
+ }
+
override toString(): string {
return this._preview;
}
diff --git a/utils/build/build.js b/utils/build/build.js
index 75c247284e..68de8fbcf6 100644
--- a/utils/build/build.js
+++ b/utils/build/build.js
@@ -331,6 +331,7 @@ class EsbuildStep extends Step {
sourcemap: withSourceMaps ? 'linked' : false,
platform: 'node',
format: 'cjs',
+ target: 'node20',
...options,
};
this._watchPaths = watchPaths;