Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore: account for the aria disabled parent (#35430)
Pavel Feldmaneffb64cdf42b
diff --git a/packages/playwright-core/src/server/injected/roleUtils.ts b/packages/playwright-core/src/server/injected/roleUtils.tsindex ca716d77b5..0f22d07a8f 100644--- a/packages/playwright-core/src/server/injected/roleUtils.ts+++ b/packages/playwright-core/src/server/injected/roleUtils.ts@@ -1013,18 +1013,19 @@ function belongsToDisabledFieldSet(element: Element): boolean {return !legendElement || !legendElement.contains(element);}-function hasExplicitAriaDisabled(element: Element | undefined): boolean {+function hasExplicitAriaDisabled(element: Element | undefined, isAncestor = false): boolean {if (!element)return false;- if (kAriaDisabledRoles.includes(getAriaRole(element) || '')) {+ if (isAncestor || kAriaDisabledRoles.includes(getAriaRole(element) || '')) {const attribute = (element.getAttribute('aria-disabled') || '').toLowerCase();if (attribute === 'true')return true;if (attribute === 'false')return false;+ // aria-disabled works across shadow boundaries.+ return hasExplicitAriaDisabled(parentElementOrShadowHost(element), true);}- // aria-disabled works across shadow boundaries.- return hasExplicitAriaDisabled(parentElementOrShadowHost(element));+ return false;}function getAccessibleNameFromAssociatedLabels(labels: Iterable<HTMLLabelElement>, options: AccessibleNameOptions) {diff --git a/tests/page/selectors-role.spec.ts b/tests/page/selectors-role.spec.tsindex 32e12640b4..6a36619f46 100644--- a/tests/page/selectors-role.spec.ts+++ b/tests/page/selectors-role.spec.ts@@ -243,6 +243,22 @@ test('should support disabled', async ({ page }) => {]);});+test('should inherit disabled from the ancestor', async ({ page }) => {+ await page.setContent(`+ <span aria-disabled="true">+ <button>Click me!</button>+ </span>+ `);+ await expect(page.locator('button')).toBeDisabled();++ await page.setContent(`+ <span aria-disabled="true">+ <h1>Heading</h1>+ </span>+ `);+ await expect(page.locator('h1')).not.toBeDisabled();+});+test('should support disabled fieldset', async ({ page }) => {await page.setContent(`<fieldset disabled>