Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

chore(bidi): don't await browsingContext.close with runBeforeUnload (#37188)

Holger Benlf06814137242
diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts
index fb48288952..7dd77fd31e 100644
--- a/packages/playwright-core/src/server/bidi/bidiPage.ts
+++ b/packages/playwright-core/src/server/bidi/bidiPage.ts
@@ -385,10 +385,17 @@ export class BidiPage implements PageDelegate {
}
async closePage(runBeforeUnload: boolean): Promise<void> {
- await this._session.send('browsingContext.close', {
- context: this._session.sessionId,
- promptUnload: runBeforeUnload,
- });
+ if (runBeforeUnload) {
+ this._session.sendMayFail('browsingContext.close', {
+ context: this._session.sessionId,
+ promptUnload: runBeforeUnload,
+ });
+ } else {
+ await this._session.send('browsingContext.close', {
+ context: this._session.sessionId,
+ promptUnload: runBeforeUnload,
+ });
+ }
}
async setBackgroundColor(color?: { r: number; g: number; b: number; a: number; }): Promise<void> {