Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(har): preserve cookie values containing '=' in API request HAR recording (#40640)
Tomohiro Yamadaf0ce6a07edb6
diff --git a/packages/playwright-core/src/server/fetch.ts b/packages/playwright-core/src/server/fetch.tsindex a8543273ff..d80c8e4a3b 100644--- a/packages/playwright-core/src/server/fetch.ts+++ b/packages/playwright-core/src/server/fetch.ts@@ -303,7 +303,9 @@ export abstract class APIRequestContext extends SdkObject {await this._updateRequestCookieHeader(progress, url, options.headers);const requestCookies = getHeader(options.headers, 'cookie')?.split(';').map(p => {- const [name, value] = p.split('=').map(v => v.trim());+ const indexOfEquals = p.indexOf('=');+ const name = indexOfEquals !== -1 ? p.substring(0, indexOfEquals).trim() : p.trim();+ const value = indexOfEquals !== -1 ? p.substring(indexOfEquals + 1).trim() : '';return { name, value };}) || [];const requestEvent: APIRequestEvent = {diff --git a/tests/library/har.spec.ts b/tests/library/har.spec.tsindex dbd00adfb5..121726b52a 100644--- a/tests/library/har.spec.ts+++ b/tests/library/har.spec.ts@@ -826,6 +826,19 @@ it('should include API request', async ({ contextFactory, server }, testInfo) =>expect(entry._serverPort).toEqual(server.PORT);});+it('should correctly record API request cookies with equals sign in value', async ({ contextFactory, server }, testInfo) => {+ const { page, getLog } = await pageWithHar(contextFactory, testInfo);+ const url = server.PREFIX + '/simple.json';+ await page.request.get(url, {+ headers: { cookie: 'token=abc=xyz; other=val' },+ });+ const log = await getLog();+ expect(log.entries[0].request.cookies).toEqual([+ { name: 'token', value: 'abc=xyz' },+ { name: 'other', value: 'val' },+ ]);+});+it('should respect minimal mode for API Requests', async ({ contextFactory, server }, testInfo) => {const { page, getLog } = await pageWithHar(contextFactory, testInfo, { mode: 'minimal' });const url = server.PREFIX + '/simple.json';