Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(cli): hide Windows daemon consoles (#42155)

Simon Knottf1fc9fcae900
diff --git a/packages/playwright-core/src/tools/backend/devtools.ts b/packages/playwright-core/src/tools/backend/devtools.ts
index 56fe53258e..ee35a90b20 100644
--- a/packages/playwright-core/src/tools/backend/devtools.ts
+++ b/packages/playwright-core/src/tools/backend/devtools.ts
@@ -135,7 +135,7 @@ const annotate = defineTabTool({
const daemonArgs = [daemonScript, `--pageId=${pageId}`];
// Spawn the dashboard daemon (idempotent — the singleton socket guards against duplicates).
- const daemon = spawn(process.execPath, daemonArgs, { detached: true, stdio: 'ignore' });
+ const daemon = spawn(process.execPath, daemonArgs, { detached: true, stdio: 'ignore', windowsHide: true });
daemon.unref();
// Spawn the annotate client in JSON mode to capture the raw payload over stdout.
diff --git a/packages/playwright-core/src/tools/cli-client/program.ts b/packages/playwright-core/src/tools/cli-client/program.ts
index ef0e82a34f..3ac0efd041 100644
--- a/packages/playwright-core/src/tools/cli-client/program.ts
+++ b/packages/playwright-core/src/tools/cli-client/program.ts
@@ -248,6 +248,7 @@ export async function program(options?: { embedderVersion?: string}) {
const child = spawn(process.execPath, daemonArgs, {
detached: !foreground,
stdio: foreground ? 'inherit' : ['pipe', 'pipe', 'ignore'],
+ windowsHide: true,
});
if (foreground) {
await new Promise<void>(resolve => child.on('exit', () => resolve()));
diff --git a/packages/playwright-core/src/tools/cli-client/session.ts b/packages/playwright-core/src/tools/cli-client/session.ts
index 2db6a105e2..290d8cbff8 100644
--- a/packages/playwright-core/src/tools/cli-client/session.ts
+++ b/packages/playwright-core/src/tools/cli-client/session.ts
@@ -148,6 +148,7 @@ export class Session {
detached: true,
stdio: ['ignore', 'pipe', err],
cwd: process.cwd(), // Will be used as root.
+ windowsHide: true,
});
let signalled = false;
diff --git a/packages/utils/processLauncher.ts b/packages/utils/processLauncher.ts
index 9c77c7a0ce..f865dda5aa 100644
--- a/packages/utils/processLauncher.ts
+++ b/packages/utils/processLauncher.ts
@@ -233,7 +233,7 @@ export async function launchProcess(options: LaunchProcessOptions): Promise<Laun
// Force kill the browser.
try {
if (process.platform === 'win32') {
- const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true });
+ const taskkillProcess = childProcess.spawnSync(`taskkill /pid ${spawnedProcess.pid} /T /F`, { shell: true, windowsHide: true });
const [stdout, stderr] = [taskkillProcess.stdout.toString(), taskkillProcess.stderr.toString()];
if (stdout)
options.log(`[pid=${spawnedProcess.pid}] taskkill stdout: ${stdout}`);