Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(mcp): use console message timestamp from the api (#39133)
Yury Semikhatskyf41c4a52b7f7
diff --git a/packages/playwright-core/src/server/webkit/wkPage.ts b/packages/playwright-core/src/server/webkit/wkPage.tsindex 8cda94ebd7..53560b81f5 100644--- a/packages/playwright-core/src/server/webkit/wkPage.ts+++ b/packages/playwright-core/src/server/webkit/wkPage.ts@@ -579,9 +579,9 @@ export class WKPage implements PageDelegate {url: url || '',lineNumber: (lineNumber || 1) - 1,columnNumber: (columnNumber || 1) - 1,- }+ },};- this._onConsoleRepeatCountUpdated({ count: 1 });+ this._onConsoleRepeatCountUpdated({ count: 1, timestamp: event.message.timestamp });}_onConsoleRepeatCountUpdated(event: Protocol.Console.messageRepeatCountUpdatedPayload) {@@ -593,8 +593,9 @@ export class WKPage implements PageDelegate {count,location} = this._lastConsoleMessage;+ const timestamp = event.timestamp ? event.timestamp * 1000 : Date.now();for (let i = count; i < event.count; ++i)- this._page.addConsoleMessage(null, derivedType, handles, location, handles.length ? undefined : text, event.timestamp ?? Date.now());+ this._page.addConsoleMessage(null, derivedType, handles, location, handles.length ? undefined : text, timestamp);this._lastConsoleMessage.count = event.count;}}diff --git a/packages/playwright-core/src/server/webkit/wkWorkers.ts b/packages/playwright-core/src/server/webkit/wkWorkers.tsindex 4ea7277423..ece751725d 100644--- a/packages/playwright-core/src/server/webkit/wkWorkers.ts+++ b/packages/playwright-core/src/server/webkit/wkWorkers.ts@@ -103,6 +103,7 @@ export class WKWorkers {lineNumber: (lineNumber || 1) - 1,columnNumber: (columnNumber || 1) - 1};- this._page.addConsoleMessage(worker, derivedType, handles, location, handles.length ? undefined : text, event.message.timestamp ?? Date.now());+ const timestamp = event.message.timestamp ? event.message.timestamp * 1000 : Date.now();+ this._page.addConsoleMessage(worker, derivedType, handles, location, handles.length ? undefined : text, timestamp);}}diff --git a/packages/playwright/src/mcp/browser/tab.ts b/packages/playwright/src/mcp/browser/tab.tsindex e1a75ae54e..b9a9cf9936 100644--- a/packages/playwright/src/mcp/browser/tab.ts+++ b/packages/playwright/src/mcp/browser/tab.ts@@ -237,7 +237,7 @@ export class Tab extends EventEmitter<TabEventsInterface> {private _handleConsoleMessage(message: ConsoleMessage) {this._consoleMessages.push(message);- const wallTime = Date.now();+ const wallTime = message.timestamp;this._addLogEntry({ type: 'console', wallTime, message });const level = consoleLevelForMessageType(message.type);if (level === 'error' || level === 'warning')@@ -431,6 +431,7 @@ export class Tab extends EventEmitter<TabEventsInterface> {export type ConsoleMessage = {type: ReturnType<playwright.ConsoleMessage['type']>;+ timestamp: number;text: string;toString(): string;};@@ -438,6 +439,7 @@ export type ConsoleMessage = {function messageToConsoleMessage(message: playwright.ConsoleMessage): ConsoleMessage {return {type: message.type(),+ timestamp: message.timestamp(),text: message.text(),toString: () => `[${message.type().toUpperCase()}] ${message.text()} @ ${message.location().url}:${message.location().lineNumber}`,};@@ -447,12 +449,14 @@ function pageErrorToConsoleMessage(errorOrValue: Error | any): ConsoleMessage {if (errorOrValue instanceof Error) {return {type: 'error',+ timestamp: Date.now(),text: errorOrValue.message,toString: () => errorOrValue.stack || errorOrValue.message,};}return {type: 'error',+ timestamp: Date.now(),text: String(errorOrValue),toString: () => String(errorOrValue),};diff --git a/tests/mcp/console.spec.ts b/tests/mcp/console.spec.tsindex 7060ebb004..1eea579f89 100644--- a/tests/mcp/console.spec.ts+++ b/tests/mcp/console.spec.ts@@ -225,7 +225,7 @@ test('console log file is created on snapshot', async ({ startClient, server },}));// Check events section mentions the log file with line range- expect(response.events).toMatch(/New console entries: output\/console-.+\.log#L\d+(-L\d+)?/);+ expect(response.events).toMatch(/New console entries: output[/\\]console-.+\.log#L\d+(-L\d+)?/);// Verify log file exists and contains the messagesconst files = await fs.promises.readdir(outputDir);diff --git a/tests/mcp/core.spec.ts b/tests/mcp/core.spec.tsindex 3832e4a2eb..87c7ed9772 100644--- a/tests/mcp/core.spec.ts+++ b/tests/mcp/core.spec.ts@@ -59,7 +59,7 @@ test('browser_navigate allows about:, data: and javascript: protocols', async ({arguments: { url: 'data:text/html,<h1>Hello</h1>' },})).toHaveResponse({code: `await page.goto('data:text/html,<h1>Hello</h1>');`,- page: `- Page URL: data:text/html,<h1>Hello</h1>`,+ page: expect.stringContaining(`- Page URL: data:text/html,<h1>Hello</h1>`),snapshot: `\`\`\`yaml- heading \"Hello\" [level=1] [ref=e2]\`\`\``,