Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
fix(mcp): match browser_route header names case-insensitively (#43227)
Pavel Feldmanf6f66c57d5a9
diff --git a/packages/playwright-core/src/tools/backend/route.ts b/packages/playwright-core/src/tools/backend/route.tsindex 9c2e293c0d..de7ca12366 100644--- a/packages/playwright-core/src/tools/backend/route.ts+++ b/packages/playwright-core/src/tools/backend/route.ts@@ -68,8 +68,9 @@ const route = defineTool({// Otherwise, modify headers and continueconst headers = { ...route.request().headers() };if (addHeaders) {+ // Header names are case-insensitive, and request headers use lowercase names.for (const [key, value] of Object.entries(addHeaders))- headers[key] = value as string;+ headers[key.toLowerCase()] = value as string;}if (removeHeaders) {for (const header of removeHeaders)diff --git a/tests/mcp/route.spec.ts b/tests/mcp/route.spec.tsindex 60a2b3a698..0a0ffbdaee 100644--- a/tests/mcp/route.spec.ts+++ b/tests/mcp/route.spec.ts@@ -136,6 +136,45 @@ test('browser_route modifies request headers', async ({ client, server }) => {expect(receivedHeaders['x-custom-header']).toBe('test-value');});+for (const { title, headers, removeHeaders, expected } of [+ { title: 'removes added header regardless of case', headers: ['X-Custom-Header: replacement'], removeHeaders: 'x-custom-header', expected: undefined },+ { title: 'lets the last of duplicate header names win', headers: ['X-Custom-Header: first', 'x-custom-header: last'], removeHeaders: undefined, expected: 'last' },+]) {+ test(`browser_route ${title}`, {+ annotation: { type: 'issue', description: 'https://github.com/microsoft/playwright/issues/43215' },+ }, async ({ client, server }) => {+ let receivedHeaders: Record<string, string> = {};+ server.setRoute('/api/check', (req, res) => {+ receivedHeaders = req.headers as Record<string, string>;+ res.writeHead(200, { 'Content-Type': 'application/json' });+ res.end(JSON.stringify({ received: true }));+ });++ server.setContent('/', `+ <button onclick="fetch('/api/check', { headers: { 'X-Custom-Header': 'original' } }).then(() => document.body.textContent = 'Done')">Fetch</button>+ `, 'text/html');++ await client.callTool({+ name: 'browser_navigate',+ arguments: { url: server.PREFIX },+ });++ await client.callTool({+ name: 'browser_route',+ arguments: { pattern: '**/api/check', headers, removeHeaders },+ });++ const requestPromise = server.waitForRequest('/api/check');+ await client.callTool({+ name: 'browser_click',+ arguments: { element: 'Fetch button', target: 'e2' },+ });++ await requestPromise;+ expect(receivedHeaders['x-custom-header']).toBe(expected);+ });+}+test('browser_route errors on header lines without a colon', async ({ client, server }) => {await client.callTool({name: 'browser_navigate',