Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(server): add missing '/' before guid in ws endpoint (#40332)

Dmitry Gozmanf961f99f8f51
diff --git a/packages/playwright-core/src/server/browser.ts b/packages/playwright-core/src/server/browser.ts
index bdd7dfe8e7..a7106f3035 100644
--- a/packages/playwright-core/src/server/browser.ts
+++ b/packages/playwright-core/src/server/browser.ts
@@ -217,7 +217,7 @@ export class BrowserServer {
let endpoint: string;
if (options.host !== undefined || options.port !== undefined) {
this._wsServer = new PlaywrightWebSocketServer(this._browser, '/');
- endpoint = await this._wsServer.listen(options.port ?? 0, options.host, createGuid());
+ endpoint = await this._wsServer.listen(options.port ?? 0, options.host, '/' + createGuid());
} else {
this._pipeServer = new PlaywrightPipeServer(this._browser);
this._pipeSocketPath = await this._socketPath();
diff --git a/tests/library/browser-server.spec.ts b/tests/library/browser-server.spec.ts
index 1205e1b646..2cbc7c8108 100644
--- a/tests/library/browser-server.spec.ts
+++ b/tests/library/browser-server.spec.ts
@@ -31,7 +31,7 @@ it('should start and stop pipe server', async ({ browserType, browser }) => {
endpoint: expect.stringMatching(/browser@/),
}));
- const browser2 = await (browserType as any).connect(serverInfo.endpoint);
+ const browser2 = await browserType.connect(serverInfo.endpoint);
const page = await browser2.newPage();
await page.goto('data:text/html,<h1>Hello via pipe</h1>');
expect(await page.locator('h1').textContent()).toBe('Hello via pipe');
@@ -62,3 +62,16 @@ it('should write descriptor on start and remove on stop', async ({ browser }) =>
if (process.platform !== 'win32')
expect(fs.existsSync(serverInfo.endpoint)).toBe(false);
});
+
+it('should start ws server with host/port and produce well-formed endpoint', async ({ browserType, browser }) => {
+ const serverInfo = await browser.bind('default', { host: 'localhost', port: 0 });
+ expect(serverInfo.endpoint).toMatch(/^ws:\/\/localhost:\d+\/[a-f0-9]+$/);
+
+ const browser2 = await browserType.connect(serverInfo.endpoint);
+ const page = await browser2.newPage();
+ await page.goto('data:text/html,<h1>Hello via ws</h1>');
+ expect(await page.locator('h1').textContent()).toBe('Hello via ws');
+ await page.close();
+ await browser2.close();
+ await browser.unbind();
+});