Skip to content

Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.

fix(mcp): pick a writable output directory when cwd is unsuitable (#40544)

Yury Semikhatskyfbae9a8e3648
diff --git a/packages/playwright-core/src/tools/backend/context.ts b/packages/playwright-core/src/tools/backend/context.ts
index e0ba8dc3d4..852ff4c2eb 100644
--- a/packages/playwright-core/src/tools/backend/context.ts
+++ b/packages/playwright-core/src/tools/backend/context.ts
@@ -15,13 +15,14 @@
*/
import fs from 'fs';
+import os from 'os';
import path from 'path';
import debug from 'debug';
import { escapeWithQuotes } from '@isomorphic/stringUtils';
import { disposeAll } from '@isomorphic/disposable';
import { eventsHelper } from '@utils/eventsHelper';
-import { isPathInside } from '@utils/fileUtils';
+import { isPathInside, isSystemDirectory, isWritable } from '@utils/fileUtils';
import { playwright } from '../../inprocess';
import { Tab } from './tab';
@@ -387,7 +388,10 @@ export async function workspaceFile(options: ContextOptions, fileName: string, p
export function outputDir(options: ContextOptions): string {
if (options.config.outputDir)
return path.resolve(options.config.outputDir);
- return path.resolve(options.cwd, options.config.skillMode ? '.playwright-cli' : '.playwright-mcp');
+ const baseName = options.config.skillMode ? '.playwright-cli' : '.playwright-mcp';
+ if (isSystemDirectory(options.cwd) || !isWritable(options.cwd))
+ return path.join(os.tmpdir(), baseName);
+ return path.join(options.cwd, baseName);
}
export async function outputFile(options: ContextOptions, fileName: string, flags: { origin: 'code' | 'llm' }): Promise<string> {
diff --git a/packages/playwright-core/src/tools/index.ts b/packages/playwright-core/src/tools/index.ts
index 69e3cfe559..24459b9b0d 100644
--- a/packages/playwright-core/src/tools/index.ts
+++ b/packages/playwright-core/src/tools/index.ts
@@ -23,6 +23,8 @@ export { browserTools, filteredTools } from './backend/tools';
export { start } from './utils/mcp/server';
export { createConnection } from './mcp/index';
export { resolveCLIConfigForCLI, resolveCLIConfigForMCP } from './mcp/config';
+export { outputDir } from './backend/context';
+export { isSystemDirectory } from '@utils/fileUtils';
export { isProfileLocked } from './mcp/browserFactory';
export { compareSemver } from './utils/socketConnection';
export { extractTrace, DirTraceLoaderBackend } from './trace/traceParser';
diff --git a/packages/playwright-core/src/tools/mcp/config.ts b/packages/playwright-core/src/tools/mcp/config.ts
index d042ec9248..46b019eccf 100644
--- a/packages/playwright-core/src/tools/mcp/config.ts
+++ b/packages/playwright-core/src/tools/mcp/config.ts
@@ -19,6 +19,7 @@ import path from 'path';
import os from 'os';
import dotenv from 'dotenv';
+import { isSystemDirectory } from '@utils/fileUtils';
import { playwright } from '../../inprocess';
import { configFromIniFile } from './configIni';
@@ -126,9 +127,18 @@ export async function resolveCLIConfigForMCP(cliOptions: CLIOptions, env?: NodeJ
if (browser.launchOptions.headless === undefined)
browser.launchOptions.headless = os.platform() === 'linux' && !process.env.DISPLAY;
+ validateOutputDir(result.outputDir);
+
return { ...result, browser, configFile };
}
+function validateOutputDir(outputDir: string | undefined) {
+ if (!outputDir)
+ return;
+ if (isSystemDirectory(outputDir))
+ throw new Error(`--output-dir cannot point to a system directory: ${path.resolve(outputDir)}.`);
+}
+
export async function resolveCLIConfigForCLI(daemonProfilesDir: string, sessionName: string, options: any, env?: NodeJS.ProcessEnv): Promise<FullConfig> {
const config = options.config ? path.resolve(options.config) : undefined;
try {
@@ -172,6 +182,8 @@ export async function resolveCLIConfigForCLI(daemonProfilesDir: string, sessionN
const browser = await validateBrowserConfig(result.browser);
+ validateOutputDir(result.outputDir);
+
if (!result.extension && !browser.isolated && !browser.userDataDir && !browser.remoteEndpoint && !browser.cdpEndpoint) {
// No custom value provided, use the daemon data dir.
const browserToken = browser.launchOptions?.channel ?? browser?.browserName;
diff --git a/packages/utils/fileUtils.ts b/packages/utils/fileUtils.ts
index fefe17a30b..2a748a92d1 100644
--- a/packages/utils/fileUtils.ts
+++ b/packages/utils/fileUtils.ts
@@ -45,6 +45,24 @@ export function canAccessFile(file: string) {
}
}
+export function isWritable(file: string): boolean {
+ try {
+ fs.accessSync(file, fs.constants.W_OK);
+ return true;
+ } catch {
+ return false;
+ }
+}
+
+export function isSystemDirectory(dir: string): boolean {
+ const resolved = path.resolve(dir);
+ if (process.platform === 'win32') {
+ const systemRoot = path.resolve(process.env.SystemRoot || 'C:\\Windows');
+ return isPathInside(systemRoot.toLowerCase(), resolved.toLowerCase());
+ }
+ return resolved === '/';
+}
+
export async function copyFileAndMakeWritable(from: string, to: string) {
await fs.promises.copyFile(from, to);
await fs.promises.chmod(to, 0o664);
diff --git a/tests/mcp/config-resolve.spec.ts b/tests/mcp/config-resolve.spec.ts
index 5e85d48fb9..f4cc2c35f2 100644
--- a/tests/mcp/config-resolve.spec.ts
+++ b/tests/mcp/config-resolve.spec.ts
@@ -15,6 +15,7 @@
*/
import fs from 'fs';
+import os from 'os';
import path from 'path';
import { test, expect } from './fixtures';
@@ -22,7 +23,7 @@ import { test, expect } from './fixtures';
import { tools } from '../../packages/playwright-core/lib/coreBundle';
import type { Config } from '../../packages/playwright-core/src/tools/mcp/config.d';
-const { resolveCLIConfigForCLI, resolveCLIConfigForMCP } = tools;
+const { resolveCLIConfigForCLI, resolveCLIConfigForMCP, isSystemDirectory, outputDir } = tools;
// Empty env to isolate tests from the host environment.
const emptyEnv = {};
@@ -260,6 +261,67 @@ test.describe('validation', () => {
});
});
+// ---------------------------------------------------------------------------
+// Output directory — fallback for unsuitable cwd, throw on explicit system dir
+// ---------------------------------------------------------------------------
+
+test.describe('outputDir', () => {
+ test.skip(process.platform === 'win32', 'POSIX-specific cases');
+
+ test('falls back to tmpdir when cwd is /', () => {
+ const result = outputDir({ config: {}, cwd: '/' });
+ expect(result).toBe(path.join(os.tmpdir(), '.playwright-mcp'));
+ });
+
+ test('uses cwd-relative .playwright-mcp for normal cwd', ({}, testInfo) => {
+ const cwd = testInfo.outputPath('workspace');
+ fs.mkdirSync(cwd, { recursive: true });
+ const result = outputDir({ config: {}, cwd });
+ expect(result).toBe(path.join(cwd, '.playwright-mcp'));
+ });
+
+ test('uses .playwright-cli when skillMode is set', ({}, testInfo) => {
+ const cwd = testInfo.outputPath('workspace');
+ fs.mkdirSync(cwd, { recursive: true });
+ const result = outputDir({ config: { skillMode: true }, cwd });
+ expect(result).toBe(path.join(cwd, '.playwright-cli'));
+ });
+
+ test('skillMode falls back to tmpdir/.playwright-cli when cwd is /', () => {
+ const result = outputDir({ config: { skillMode: true }, cwd: '/' });
+ expect(result).toBe(path.join(os.tmpdir(), '.playwright-cli'));
+ });
+
+ test('explicit outputDir wins regardless of cwd', ({}, testInfo) => {
+ const explicit = testInfo.outputPath('explicit');
+ const result = outputDir({ config: { outputDir: explicit }, cwd: '/' });
+ expect(result).toBe(explicit);
+ });
+
+ test('falls back to tmpdir when cwd is not writable', ({}, testInfo) => {
+ const cwd = testInfo.outputPath('readonly');
+ fs.mkdirSync(cwd, { recursive: true });
+ fs.chmodSync(cwd, 0o500);
+ try {
+ const result = outputDir({ config: {}, cwd });
+ expect(result).toBe(path.join(os.tmpdir(), '.playwright-mcp'));
+ } finally {
+ fs.chmodSync(cwd, 0o700);
+ }
+ });
+
+ test('isSystemDirectory detects /', () => {
+ expect(isSystemDirectory('/')).toBe(true);
+ expect(isSystemDirectory('/tmp')).toBe(false);
+ expect(isSystemDirectory(os.homedir())).toBe(false);
+ });
+
+ test('resolveCLIConfigForMCP throws when --output-dir is /', async () => {
+ await expect(resolveCLIConfigForMCP({ outputDir: '/' }, emptyEnv))
+ .rejects.toThrow(/--output-dir cannot point to a system directory/);
+ });
+});
+
// ---------------------------------------------------------------------------
// MCP-specific: headless platform default, timeout CLI options
// ---------------------------------------------------------------------------