Playwright is a framework for Web Testing and Automation. It allows testing Chromium, Firefox and WebKit with a single API.
TypeScript automationchromechromiume2e-testingelectronend-to-end-testingfirefoxjavascriptplaywrighttesttest-automationtestingtesting-toolswebwebkit
chore(mcp): remove unnecessary waitForCompletion from non-navigating tools (#39769)
Pavel Feldmanfd1b453fdc77
diff --git a/packages/playwright-core/src/tools/backend/keyboard.ts b/packages/playwright-core/src/tools/backend/keyboard.tsindex 91b21999d7..7fc8b5b018 100644--- a/packages/playwright-core/src/tools/backend/keyboard.ts+++ b/packages/playwright-core/src/tools/backend/keyboard.ts@@ -94,7 +94,7 @@ const type = defineTabTool({const { locator, resolved } = await tab.refLocator(params);const secret = tab.context.lookupSecret(params.text);- await tab.waitForCompletion(async () => {+ const action = async () => {if (params.slowly) {response.setIncludeSnapshot();response.addCode(`await page.${resolved}.pressSequentially(${secret.code});`);@@ -109,7 +109,12 @@ const type = defineTabTool({response.addCode(`await page.${resolved}.press('Enter');`);await locator.press('Enter', tab.actionTimeoutOptions);}- });+ };++ if (params.submit || params.slowly)+ await tab.waitForCompletion(action);+ else+ await action();},});diff --git a/packages/playwright-core/src/tools/backend/mouse.ts b/packages/playwright-core/src/tools/backend/mouse.tsindex f0cdc67c5b..bfdb29679c 100644--- a/packages/playwright-core/src/tools/backend/mouse.ts+++ b/packages/playwright-core/src/tools/backend/mouse.ts@@ -35,9 +35,7 @@ const mouseMove = defineTabTool({response.addCode(`// Move mouse to (${params.x}, ${params.y})`);response.addCode(`await page.mouse.move(${params.x}, ${params.y});`);- await tab.waitForCompletion(async () => {- await tab.page.mouse.move(params.x, params.y);- });+ await tab.page.mouse.move(params.x, params.y);},});diff --git a/packages/playwright-core/src/tools/backend/snapshot.ts b/packages/playwright-core/src/tools/backend/snapshot.tsindex e4982abae5..2fced17c98 100644--- a/packages/playwright-core/src/tools/backend/snapshot.ts+++ b/packages/playwright-core/src/tools/backend/snapshot.ts@@ -135,9 +135,7 @@ const hover = defineTabTool({const { locator, resolved } = await tab.refLocator(params);response.addCode(`await page.${resolved}.hover();`);- await tab.waitForCompletion(async () => {- await locator.hover(tab.actionTimeoutOptions);- });+ await locator.hover(tab.actionTimeoutOptions);},});@@ -161,9 +159,7 @@ const selectOption = defineTabTool({const { locator, resolved } = await tab.refLocator(params);response.addCode(`await page.${resolved}.selectOption(${formatObject(params.values)});`);- await tab.waitForCompletion(async () => {- await locator.selectOption(params.values, tab.actionTimeoutOptions);- });+ await locator.selectOption(params.values, tab.actionTimeoutOptions);},});diff --git a/packages/playwright-core/src/tools/cli-client/skill/SKILL.md b/packages/playwright-core/src/tools/cli-client/skill/SKILL.mdindex 33bc1bc361..77a0c0eae0 100644--- a/packages/playwright-core/src/tools/cli-client/skill/SKILL.md+++ b/packages/playwright-core/src/tools/cli-client/skill/SKILL.md@@ -35,7 +35,8 @@ playwright-cli goto https://playwright.devplaywright-cli type "search query"playwright-cli click e3playwright-cli dblclick e7-playwright-cli fill e5 "[email protected]"+# --submit presses Enter after filling the element+playwright-cli fill e5 "[email protected]" --submitplaywright-cli drag e2 e8playwright-cli hover e4playwright-cli select e9 "option-value"