Skip to content

armgit / plexo

Public Imported from GitHub
0

Speed up downloads by combining multiple network connections in parallel

Drop the macOS first-launch workaround now that the Mac app is notarized (#113)

Anmol Kapilaf878e20d17f
diff --git a/README.md b/README.md
index 4e4dafd..199c553 100644
--- a/README.md
+++ b/README.md
@@ -10,10 +10,7 @@ https://github.com/user-attachments/assets/e57728f4-fb63-441f-839c-174eef954b17
Get the installer for your computer from [getplexo.app](https://getplexo.app/#downloads), or pick a file from [GitHub Releases](https://github.com/anmolkapil/plexo/releases). Builds are available for macOS (Apple silicon and Intel), Windows 10 and 11 (x64 and ARM64), and Linux (AppImage and `.deb`, x86_64 and ARM64).
-The first launch needs one extra step:
-
-- **macOS** says "Apple cannot check 'Plexo' for malicious software": click **Done**, then open **System Settings → Privacy & Security** and click **Open Anyway**. The Mac app is signed with an Apple Developer ID (see [Credits](#credits)) but not yet notarized by Apple. Or move it to Applications, run `xattr -dr com.apple.quarantine /Applications/Plexo.app` in Terminal, and open it again.
-- **Windows** shows "Windows protected your PC": click **More info**, then **Run anyway**. The installer isn't code-signed yet.
+The Mac app is signed with an Apple Developer ID (see [Credits](#credits)) and notarized by Apple, so it opens like any other app. On Windows, the first launch needs one extra step: when it shows "Windows protected your PC", click **More info**, then **Run anyway**. The installer isn't code-signed yet.
Plexo updates itself after that: new versions download in the background and install when you restart.
diff --git a/docs/downloads.js b/docs/downloads.js
index 3124f85..0efa4e6 100644
--- a/docs/downloads.js
+++ b/docs/downloads.js
@@ -13,19 +13,10 @@
var OS_ORDER = ['mac', 'win', 'linux']
var OS_LABEL = { mac: 'macOS', win: 'Windows', linux: 'Linux' }
- // What a build that isn't notarized (macOS) or signed (Windows) makes the OS say on first
- // launch, and the way past it: under the
- // download button for the visitor's own OS, and with every other OS's downloads.
- // `code` in backticks, **button names** in stars.
- var MAC_COMMAND = 'xattr -dr com.apple.quarantine /Applications/Plexo.app'
+ // What an installer that isn't code-signed (Windows) makes the OS say on first launch, and the
+ // way past it: under the download button for the visitor's own OS, and with every other OS's
+ // downloads. `code` in backticks, **button names** in stars.
var FIRST_LAUNCH = {
- mac: {
- system: 'macOS',
- warning: 'Apple cannot check “Plexo” for malicious software',
- fix: 'Plexo is signed, just not notarized by Apple yet. Click **Done**, choose **Open Anyway** in System Settings → Privacy & Security, and open it again. Or drag Plexo into **Applications**, then run this once in **Terminal**:',
- command: MAC_COMMAND,
- aside: null
- },
win: {
system: 'Windows',
warning: 'Windows protected your PC',
@@ -303,12 +294,6 @@
out.push('')
})
out.push(
- '**macOS says Apple cannot check Plexo?** Plexo is signed, just not notarized by Apple yet. ' +
- 'Click Done, choose Open Anyway in System Settings → Privacy & Security, and open it again. ' +
- 'Or move it to Applications, run `' +
- MAC_COMMAND +
- '` in Terminal, and open it again.',
- '',
'**Windows protected your PC?** Click More info, then Run anyway.',
'',
'Step by step, and what Linux needs: ' + siteUrl + '#downloads'
diff --git a/docs/index.html b/docs/index.html
index dcc5309..41c8b04 100644
--- a/docs/index.html
+++ b/docs/index.html
@@ -2399,12 +2399,12 @@
"
>
The Mac app is signed with an Apple Developer ID provided by
- <a href="https://github.com/DhananjayBhosale">Dhananjay Bhosale</a>, but isn't
- notarized by Apple yet, and the Windows installer isn't code-signed yet, so both
- may show a security warning the first time you open Plexo. Follow the first-launch
- steps under Downloads for your system. You only need to do this once, and the full
- source code is available on GitHub. Code-signing licenses cost money; if you'd
- like to help remove these warnings, consider
+ <a href="https://github.com/DhananjayBhosale">Dhananjay Bhosale</a> and notarized
+ by Apple, so it opens without a warning. The Windows installer isn't code-signed
+ yet, so Windows may show a security warning the first time you open Plexo. Follow
+ the first-launch steps under Downloads for Windows. You only need to do this once,
+ and the full source code is available on GitHub. Code-signing licenses cost money;
+ if you'd like to help remove this warning, consider
<a href="https://github.com/sponsors/anmolkapil">sponsoring Plexo</a> so the
project can cover them.
</p>
diff --git a/docs/landing.js b/docs/landing.js
index c4f9cac..8f8f1ca 100644
--- a/docs/landing.js
+++ b/docs/landing.js
@@ -76,19 +76,6 @@
window.requestAnimationFrame(fitDemoToViewport)
const installGuides = {
- mac: {
- title: 'Opening Plexo for the first time on macOS',
- why: 'Plexo is signed with an Apple Developer ID but not notarized by Apple yet, so macOS asks you to allow it the first time you open it. You only need to do this once.',
- steps: [
- ['Open the .dmg and drag **Plexo** into your **Applications** folder.'],
- ['Open Plexo. When macOS says it can’t verify the app, click **Done**.'],
- ['Open **System Settings → Privacy & Security**, then click **Open Anyway**.']
- ],
- fix: [
- 'Still won’t open? Run this in Terminal, then open Plexo again:',
- 'xattr -cr /Applications/Plexo.app'
- ]
- },
win: {
title: 'Installing Plexo on Windows',
why: 'Plexo isn’t code-signed yet, so your browser and Windows SmartScreen may warn you before it installs.',
@@ -262,6 +249,8 @@
}
function renderInstallGuide(os) {
const guide = installGuides[os]
+ // The Mac app is notarized, so it opens like any other app and needs no guide.
+ if (!guide) return document.createDocumentFragment()
const details = element('details', 'install-help')
const summary = document.createElement('summary')
const icon = element('span', 'install-help-icon')
diff --git a/e2e/downloads.spec.ts b/e2e/downloads.spec.ts
index af5da4a..21866bd 100644
--- a/e2e/downloads.spec.ts
+++ b/e2e/downloads.spec.ts
@@ -266,7 +266,7 @@ test.describe('which download is offered', () => {
for (const name of NOISE) expect(text).not.toContain(name)
expect(text).toContain('[Apple silicon]')
expect(text).toContain('https://getplexo.app/#downloads')
- expect(text).toContain('`xattr -dr com.apple.quarantine /Applications/Plexo.app`')
+ expect(text).not.toContain('notarized')
})
})
@@ -385,9 +385,7 @@ test.describe('the download page', () => {
try {
await page.getByRole('tab', { name: 'macOS' }).click()
const mac = page.getByRole('tabpanel', { name: 'macOS' })
- await mac.locator('summary').click()
- await expect(mac.locator('code')).toHaveText('xattr -cr /Applications/Plexo.app')
- await expect(mac).toContainText('Open Anyway')
+ await expect(mac.locator('.install-help')).toHaveCount(0)
await page.getByRole('tab', { name: 'Windows' }).click()
await page.getByRole('tabpanel', { name: 'Windows' }).locator('summary').click()
await expect(page.getByRole('tabpanel', { name: 'Windows' })).toContainText('Run anyway')
@@ -443,7 +441,8 @@ test.describe('the download page', () => {
'href',
'https://github.com/anmolkapil/plexo/releases'
)
- for (const os of ['macOS', 'Windows', 'Linux']) {
+ await expect(page.locator('#panel-mac .install-help')).toHaveCount(0)
+ for (const os of ['Windows', 'Linux']) {
await page.getByRole('tab', { name: os }).click()
const panel = page.getByRole('tabpanel', { name: os })
await panel.locator('summary').click()
@@ -466,16 +465,16 @@ test.describe('the download page', () => {
}
})
})
- await page.locator('#panel-mac summary').click()
- const button = page.locator('#panel-mac .copy-command')
- const status = page.locator('#panel-mac .command-status')
+ await page.locator('#panel-linux summary').click()
+ const button = page.locator('#panel-linux .copy-command').first()
+ const status = page.locator('#panel-linux .command-status').first()
await button.click({ trial: true })
const width = (await button.boundingBox())?.width
await button.click()
await expect(button).toHaveText('Copied')
expect((await button.boundingBox())?.width).toBe(width)
expect(await page.locator('body').getAttribute('data-copied-command')).toBe(
- await page.locator('#panel-mac code').textContent()
+ await page.locator('#panel-linux code').first().textContent()
)
await expect(status).toHaveAttribute('role', 'status')
await expect(status).toHaveText('Command copied to clipboard.')
@@ -492,7 +491,7 @@ test.describe('the download page', () => {
test('failed or unavailable clipboard access offers manual copying', async () => {
const { page, close } = await openPage(BROWSERS.chromeMac)
try {
- await page.locator('#panel-mac summary').click()
+ await page.locator('#panel-linux summary').click()
for (const unavailable of [false, true]) {
await page.evaluate((missing) => {
Object.defineProperty(navigator, 'clipboard', {
@@ -506,12 +505,12 @@ test.describe('the download page', () => {
}
})
}, unavailable)
- await page.locator('#panel-mac .copy-command').click()
- const status = page.locator('#panel-mac .command-status')
+ await page.locator('#panel-linux .copy-command').first().click()
+ const status = page.locator('#panel-linux .command-status').first()
await expect(status).toBeVisible()
await expect(status).not.toHaveClass(/sr-only/)
await expect(status).toHaveText('Couldn’t copy. Select the command and copy it manually.')
- await expect(page.locator('#panel-mac .copy-command')).toHaveText('Copy')
+ await expect(page.locator('#panel-linux .copy-command').first()).toHaveText('Copy')
}
} finally {
await close()