Skip to content

armgit / plexo

Public Imported from GitHub
0

Speed up downloads by combining multiple network connections in parallel

Fix accessibility gaps found in the frontend audit

Anmol Kapile091cfb6b0fe
diff --git a/src/renderer/src/components/NetworkCard.tsx b/src/renderer/src/components/NetworkCard.tsx
index b9cb416..5d658f6 100644
--- a/src/renderer/src/components/NetworkCard.tsx
+++ b/src/renderer/src/components/NetworkCard.tsx
@@ -58,7 +58,9 @@ export function NetworkCard({
role="checkbox"
aria-checked={selected}
onClick={onToggle}
- className="flex min-w-0 shrink items-center gap-[9px] border-none bg-transparent p-0 text-left [font:inherit] text-inherit"
+ // min-h-6: WCAG 2.5.8's 24px floor — this is the primary "select this network" control
+ // and previously sized to its ~15px content (the checkbox glyph + name text).
+ className="flex min-h-6 min-w-0 shrink items-center gap-[9px] border-none bg-transparent p-0 text-left [font:inherit] text-inherit"
>
<Checkbox checked={selected} color={visual.solid} onColor={visual.onSolid} />
<div
diff --git a/src/renderer/src/components/NetworkEditPopover.tsx b/src/renderer/src/components/NetworkEditPopover.tsx
index 4cb7bbe..56402dc 100644
--- a/src/renderer/src/components/NetworkEditPopover.tsx
+++ b/src/renderer/src/components/NetworkEditPopover.tsx
@@ -112,20 +112,26 @@ export function NetworkEditPopover({
<Tooltip key={swatch.id}>
<TooltipTrigger
render={
+ // The 24px button is the WCAG 2.5.8 hit target; the visible 20px dot lives
+ // in the padding-shrunk inner span so the swatch itself doesn't grow.
<button
type="button"
onClick={() => setDraftColorId(swatch.id)}
aria-label={swatch.label}
aria-pressed={isSelected}
- className="size-5 shrink-0 rounded-full border-none p-0"
- style={{
- background: swatch.solid,
- // Popover-colored gap, then a ring in the swatch's own hue — reads in both themes.
- boxShadow: isSelected
- ? `0 0 0 2px var(--color-popover), 0 0 0 4px ${swatch.solid}`
- : undefined
- }}
- />
+ className="size-6 shrink-0 rounded-full border-none p-[2px]"
+ >
+ <span
+ className="block size-full rounded-full"
+ style={{
+ background: swatch.solid,
+ // Popover-colored gap, then a ring in the swatch's own hue — reads in both themes.
+ boxShadow: isSelected
+ ? `0 0 0 2px var(--color-popover), 0 0 0 4px ${swatch.solid}`
+ : undefined
+ }}
+ />
+ </button>
}
/>
<TooltipContent>{swatch.label}</TooltipContent>
diff --git a/src/renderer/src/components/NetworkRow.tsx b/src/renderer/src/components/NetworkRow.tsx
index 2de8209..a306587 100644
--- a/src/renderer/src/components/NetworkRow.tsx
+++ b/src/renderer/src/components/NetworkRow.tsx
@@ -1,7 +1,6 @@
import type { BlockState, ChunkState } from '@shared/types'
import { useState } from 'react'
-import { useNetworkVisuals } from '../hooks/useNetworkVisuals'
-import { DANGER } from '../theme'
+import { DANGER, type NetworkVisual } from '../theme'
import type { NetworkGroup } from '../utils/format'
import { formatBytes, formatSpeed } from '../utils/format'
import { ColorBadge } from './ColorBadge'
@@ -11,6 +10,7 @@ import { Button } from './ui/button'
interface NetworkRowProps {
group: NetworkGroup
+ visual: NetworkVisual
sharePercent: number
totalBytes?: number | null
blocks?: BlockState[]
@@ -96,12 +96,12 @@ function describeStream(
export function NetworkRow({
group,
+ visual,
sharePercent,
totalBytes,
blocks
}: NetworkRowProps): React.JSX.Element {
const [expanded, setExpanded] = useState(false)
- const visual = useNetworkVisuals()(group.interfaceId, group.interfaceKind, group.interfaceLabel)
const hasError = group.chunks.some((chunk) => chunk.status === 'error')
const isActive = group.chunks.some((chunk) => chunk.status === 'downloading')
@@ -116,6 +116,7 @@ export function NetworkRow({
>
<div
role="cell"
+ aria-label={hasError ? 'Error' : isActive ? 'Active' : 'Idle'}
className="ml-5 size-2 rounded-full"
style={{
background: hasError ? DANGER : visual.solid,
diff --git a/src/renderer/src/components/TruncatedText.tsx b/src/renderer/src/components/TruncatedText.tsx
index 6563635..cb0e995 100644
--- a/src/renderer/src/components/TruncatedText.tsx
+++ b/src/renderer/src/components/TruncatedText.tsx
@@ -32,7 +32,11 @@ export function TruncatedText({
render={
<span
ref={setNode}
- className={`inline-block max-w-full truncate align-bottom ${className}`}
+ // Focusable only when actually truncated — untruncated text has nothing more to
+ // reveal, and a keyboard user needs some way to reach the tooltip a mouse user gets
+ // via hover.
+ tabIndex={isTruncated ? 0 : undefined}
+ className={`inline-block max-w-full truncate align-bottom outline-none focus-visible:rounded-sm focus-visible:ring-2 focus-visible:ring-ring/50 ${className}`}
>
{text}
</span>
diff --git a/src/renderer/src/screens/CompleteScreen.tsx b/src/renderer/src/screens/CompleteScreen.tsx
index 07b0680..75965d4 100644
--- a/src/renderer/src/screens/CompleteScreen.tsx
+++ b/src/renderer/src/screens/CompleteScreen.tsx
@@ -92,6 +92,9 @@ export function CompleteScreen({
return (
<div className="flex h-full flex-col bg-background">
+ <div role="status" className="sr-only">
+ Download complete: {download.fileName}
+ </div>
<HeroBand>
<div className="flex items-center gap-[18px]">
<div className="flex size-11 shrink-0 items-center justify-center rounded-full border border-[var(--color-wifi-border)] bg-[var(--color-wifi-bg)]">
@@ -167,7 +170,7 @@ export function CompleteScreen({
</div>
<div className="mx-5 mb-4 flex flex-col gap-2">
- <div className={sectionHeaderClass}>Speed over the download</div>
+ <h2 className={sectionHeaderClass}>Speed over the download</h2>
<ThroughputChart
order={groups.map((g, i) => ({ interfaceId: g.interfaceId, solid: visuals[i].solid }))}
historyByInterface={speedHistoryByInterface}
@@ -175,7 +178,7 @@ export function CompleteScreen({
</div>
<div className="mx-5 mb-5 flex flex-1 flex-col gap-[9px]">
- <div className={sectionHeaderClass}>Contribution by network</div>
+ <h2 className={sectionHeaderClass}>Contribution by network</h2>
<div className="flex h-2.5 gap-0.5 overflow-hidden rounded-full bg-muted">
{groups.map((group, index) => (
<div
diff --git a/src/renderer/src/screens/DownloadingScreen.tsx b/src/renderer/src/screens/DownloadingScreen.tsx
index 5ed8321..9a1d3e7 100644
--- a/src/renderer/src/screens/DownloadingScreen.tsx
+++ b/src/renderer/src/screens/DownloadingScreen.tsx
@@ -385,10 +385,11 @@ export function DownloadingScreen({ download }: { download: DownloadState }): Re
Downloaded
</div>
</div>
- {groups.map((group) => (
+ {groups.map((group, index) => (
<NetworkRow
key={group.interfaceId}
group={group}
+ visual={visuals[index]}
sharePercent={
totalDownloadedByNetworks > 0
? (group.bytesDownloaded / totalDownloadedByNetworks) * 100
@@ -430,6 +431,9 @@ export function DownloadingScreen({ download }: { download: DownloadState }): Re
variant={isPaused ? 'default' : 'secondary'}
onClick={handlePauseResume}
disabled={isAssembling || resuming}
+ // Disabled natively means unhoverable/unfocusable, which would silence this button's
+ // own explanatory tooltip exactly when it's needed — keep it reachable instead.
+ focusableWhenDisabled
>
{pauseResumeLabel}
</Button>
@@ -438,7 +442,12 @@ export function DownloadingScreen({ download }: { download: DownloadState }): Re
<WhileAssembling active={isAssembling} text="Can’t cancel while assembling the file">
<AlertDialogTrigger
render={
- <Button type="button" variant="destructive" disabled={isAssembling}>
+ <Button
+ type="button"
+ variant="destructive"
+ disabled={isAssembling}
+ focusableWhenDisabled
+ >
Cancel
</Button>
}
diff --git a/src/renderer/src/screens/IdleScreen.tsx b/src/renderer/src/screens/IdleScreen.tsx
index 7c308ee..151bee4 100644
--- a/src/renderer/src/screens/IdleScreen.tsx
+++ b/src/renderer/src/screens/IdleScreen.tsx
@@ -1,4 +1,5 @@
import type { ProbeResult } from '@shared/types'
+import { cn } from 'cn'
import { AlertTriangle, ClipboardPaste } from 'lucide-react'
import { useEffect, useRef, useState } from 'react'
import { NetworkCard } from '../components/NetworkCard'
@@ -7,7 +8,6 @@ import { Alert, AlertDescription } from '../components/ui/alert'
import { Button } from '../components/ui/button'
import { ToggleGroup, ToggleGroupItem } from '../components/ui/toggle-group'
import { useNetworkPolling } from '../hooks/useNetworkPolling'
-import { cn } from '../lib/utils'
import { useAppStore } from '../store/useAppStore'
import { describeError, formatBytes, toDisplayPath } from '../utils/format'
@@ -275,7 +275,9 @@ export function IdleScreen(): React.JSX.Element {
spacing={1}
>
{PRESET_STREAMS.map((preset) => (
- <ToggleGroupItem key={preset} value={String(preset)}>
+ // h-6/min-w-6: WCAG 2.5.8's 24px floor — the xs toggle size is 20px, and this is
+ // the primary "how many parallel connections" control.
+ <ToggleGroupItem key={preset} value={String(preset)} className="h-6 min-w-6">
{preset}×
</ToggleGroupItem>
))}
@@ -307,7 +309,7 @@ export function IdleScreen(): React.JSX.Element {
{isSingleStreamOnly && (
<div className="text-[11.5px] text-muted-foreground">
- This server doesn&apos;t support multi-chunk downloads for this file — using a single
+ This server doesn’t support multi-chunk downloads for this file — using a single
network.
</div>
)}
@@ -316,9 +318,9 @@ export function IdleScreen(): React.JSX.Element {
<div className="flex-1 overflow-y-auto px-5 pb-3.5">
<div className="flex items-baseline justify-between border-b border-border pb-2">
- <div className="font-mono text-[10px] tracking-[0.16em] text-muted-foreground uppercase">
+ <h2 className="font-mono text-[10px] tracking-[0.16em] text-muted-foreground uppercase">
Connected Networks
- </div>
+ </h2>
<div className="shrink-0 font-mono text-[10.5px] text-muted-foreground">
{interfaces.length} detected · {selectedInterfaceIds.length} selected
</div>