Skip to content

A modern, self-hosted backup solution for secure, encrypted backups across local and cloud storage.

chore fix failing test cases due to app settings structure change

towfiqi5caa09c53b06
diff --git a/backend/__tests__/services/DeviceService.test.ts b/backend/__tests__/services/DeviceService.test.ts
index 4cdacb0..8897e45 100644
--- a/backend/__tests__/services/DeviceService.test.ts
+++ b/backend/__tests__/services/DeviceService.test.ts
@@ -6,7 +6,6 @@ import { BaseSystemManager } from '../../src/managers/BaseSystemManager';
import { LocalStrategy, RemoteStrategy } from '../../src/strategies/system';
import { Device } from '../../src/db/schema/devices';
import { Plan } from '../../src/db/schema/plans';
-import { Storage } from '../../src/db/schema/storages';
import { DeviceMetrics } from '../../src/types/devices';
// Mock dependencies
@@ -179,7 +178,7 @@ describe('DeviceService', () => {
});
it('should call updateSettings on the strategy for a remote device', async () => {
- const settingsUpdate = { settings: { tempDir: '/new/temp' } };
+ const settingsUpdate = { settings: { general: { tempDir: '/new/temp' } } };
mockDeviceStore.getById.mockResolvedValue(mockDevice);
mockRemoteStrategy.updateSettings.mockResolvedValue({ success: true, result: 'Updated' });
@@ -200,7 +199,7 @@ describe('DeviceService', () => {
});
it('should throw an error if updating settings on a remote device fails', async () => {
- const settingsUpdate = { settings: { tempDir: '/new/temp' } };
+ const settingsUpdate = { settings: { general: { tempDir: '/new/temp' } } };
mockDeviceStore.getById.mockResolvedValue(mockDevice);
mockRemoteStrategy.updateSettings.mockResolvedValue({
success: false,
diff --git a/backend/__tests__/utils/initSetup.test.ts b/backend/__tests__/utils/initSetup.test.ts
index 00cbace..f66a9b0 100644
--- a/backend/__tests__/utils/initSetup.test.ts
+++ b/backend/__tests__/utils/initSetup.test.ts
@@ -271,7 +271,9 @@ describe('runInitialSetup', () => {
},
status: 'active',
lastSeen: expect.any(Date),
- settings: { tempDir: '/tmp/pluton' },
+ settings: {
+ general: { tempDir: '/tmp/pluton' },
+ },
});
});
diff --git a/backend/src/services/DeviceService.ts b/backend/src/services/DeviceService.ts
index 9ccd50f..99c9dda 100644
--- a/backend/src/services/DeviceService.ts
+++ b/backend/src/services/DeviceService.ts
@@ -143,16 +143,14 @@ export class DeviceService {
}
if (data.settings) {
- if (existingDevice.id === 'main') {
- try {
- const strategy = this.getSystemStrategy(id);
- const updateResp = await strategy.updateSettings(data.settings);
- if (!updateResp.success) {
- throw new Error('Failed to update device settings');
- }
- } catch (error: any) {
+ try {
+ const strategy = this.getSystemStrategy(id);
+ const updateResp = await strategy.updateSettings(data.settings);
+ if (!updateResp.success) {
throw new Error('Failed to update device settings');
}
+ } catch (error: any) {
+ throw new Error('Failed to update device settings');
}
}