Skip to content

A modern, self-hosted backup solution for secure, encrypted backups across local and cloud storage.

fix: prevent encryption setting changes after plan creation

towfiqi67cffba561e9
diff --git a/frontend/src/components/Plan/PlanForm/PlanForm.tsx b/frontend/src/components/Plan/PlanForm/PlanForm.tsx
index a79c3ec..fd43074 100644
--- a/frontend/src/components/Plan/PlanForm/PlanForm.tsx
+++ b/frontend/src/components/Plan/PlanForm/PlanForm.tsx
@@ -273,7 +273,13 @@ const PlanForm = ({
)}
{step === 4 && (
<div className={PFClasses.planStep}>
- <PlanAdvancedSettings plan={planSettings} appSettings={appSettings} onUpdate={onPlanSettingsChange} device={deviceInstance} />
+ <PlanAdvancedSettings
+ plan={planSettings}
+ appSettings={appSettings}
+ onUpdate={onPlanSettingsChange}
+ device={deviceInstance}
+ isEditing={type === 'edit'}
+ />
</div>
)}
</div>
diff --git a/frontend/src/components/Plan/PlanSettings/PlanAdvancedSettings.tsx b/frontend/src/components/Plan/PlanSettings/PlanAdvancedSettings.tsx
index c0177f9..9221607 100644
--- a/frontend/src/components/Plan/PlanSettings/PlanAdvancedSettings.tsx
+++ b/frontend/src/components/Plan/PlanSettings/PlanAdvancedSettings.tsx
@@ -16,9 +16,10 @@ interface PlanAdvancedSettingsProps {
appSettings?: Record<string, any>;
device: Device;
onUpdate: (notificationSettings: NewPlanSettings) => void;
+ isEditing: boolean;
}
-const PlanAdvancedSettings = ({ plan, appSettings, device, onUpdate }: PlanAdvancedSettingsProps) => {
+const PlanAdvancedSettings = ({ plan, appSettings, device, onUpdate, isEditing }: PlanAdvancedSettingsProps) => {
const [advancedTab, setAdvancedTab] = useState('General');
const settings = plan.settings;
const integrationTypes = useMemo(() => {
@@ -75,7 +76,11 @@ const PlanAdvancedSettings = ({ plan, appSettings, device, onUpdate }: PlanAdvan
)}
<div className={classes.advancedTabContent}>
{advancedTab === 'General' && (
- <PlanGeneralSettings settings={settings} onUpdate={(newSettings) => onUpdate({ ...plan, settings: newSettings })} />
+ <PlanGeneralSettings
+ settings={settings}
+ onUpdate={(newSettings) => onUpdate({ ...plan, settings: newSettings })}
+ isEditing={isEditing}
+ />
)}
{advancedTab === 'Notification' && (
<PlanNotificationSettings
diff --git a/frontend/src/components/Plan/PlanSettings/PlanGeneralSettings.tsx b/frontend/src/components/Plan/PlanSettings/PlanGeneralSettings.tsx
index ee8796b..aad3fb1 100644
--- a/frontend/src/components/Plan/PlanSettings/PlanGeneralSettings.tsx
+++ b/frontend/src/components/Plan/PlanSettings/PlanGeneralSettings.tsx
@@ -6,9 +6,10 @@ import classes from './PlanSettings.module.scss';
interface PlanGeneralSettingsProps {
settings: NewPlanSettings['settings'];
onUpdate: (settings: NewPlanSettings['settings']) => void;
+ isEditing: boolean;
}
-const PlanGeneralSettings = ({ settings, onUpdate }: PlanGeneralSettingsProps) => {
+const PlanGeneralSettings = ({ settings, onUpdate, isEditing }: PlanGeneralSettingsProps) => {
const { encryption, compression, retries, retryDelay } = settings;
return (
<>
@@ -16,6 +17,7 @@ const PlanGeneralSettings = ({ settings, onUpdate }: PlanGeneralSettingsProps) =
<label className={classes.label}>Encryption</label>
<Toggle
fieldValue={encryption}
+ disabled={isEditing}
onUpdate={(val: boolean) => onUpdate({ ...settings, encryption: val })}
description="Encrypt Source Files before backup"
/>
diff --git a/frontend/src/components/common/form/Toggle/Toggle.module.scss b/frontend/src/components/common/form/Toggle/Toggle.module.scss
index 3b6c90b..96074f7 100644
--- a/frontend/src/components/common/form/Toggle/Toggle.module.scss
+++ b/frontend/src/components/common/form/Toggle/Toggle.module.scss
@@ -61,6 +61,13 @@
label:active:after {
width: 30px;
}
+ &.toggleDisabled {
+ opacity: 0.6;
+ cursor: not-allowed;
+ label {
+ cursor: not-allowed;
+ }
+ }
}
.description {
diff --git a/frontend/src/components/common/form/Toggle/Toggle.tsx b/frontend/src/components/common/form/Toggle/Toggle.tsx
index c65a4a0..d1093e2 100644
--- a/frontend/src/components/common/form/Toggle/Toggle.tsx
+++ b/frontend/src/components/common/form/Toggle/Toggle.tsx
@@ -9,11 +9,22 @@ type ToggleProps = {
inline?: boolean;
hint?: string;
error?: string;
+ disabled?: boolean;
fieldValue: boolean;
onUpdate: (f: boolean) => void;
};
-const Toggle = ({ label, description, customClasses = '', fieldValue = false, inline = false, hint = '', error, onUpdate }: ToggleProps) => {
+const Toggle = ({
+ label,
+ description,
+ customClasses = '',
+ fieldValue = false,
+ inline = false,
+ hint = '',
+ error,
+ disabled = false,
+ onUpdate,
+}: ToggleProps) => {
const toggleID = nanoid();
const updateField = (event: React.FormEvent<HTMLInputElement>) => {
const inputVal = event.currentTarget.value === 'true';
@@ -22,8 +33,8 @@ const Toggle = ({ label, description, customClasses = '', fieldValue = false, in
return (
<FormField type="toggle" label={label} hint={hint} error={error} inline={inline} classes={`${classes.toggleField} ${customClasses}`}>
- <div className={classes.toggleCheckbox}>
- <input type="checkbox" id={toggleID} value={fieldValue.toString()} onChange={updateField} checked={fieldValue} />
+ <div className={`${classes.toggleCheckbox} ${disabled ? classes.toggleDisabled : ''}`}>
+ <input type="checkbox" id={toggleID} value={fieldValue.toString()} onChange={updateField} checked={fieldValue} disabled={disabled} />
<label htmlFor={toggleID}>{label}</label>
{description && <span className={classes.description}>{description}</span>}
</div>