A modern, self-hosted backup solution for secure, encrypted backups across local and cloud storage.
ci: fix test suit failures
towfiqib391ac1e0786
diff --git a/backend/__tests__/env-setup.ts b/backend/__tests__/env-setup.tsnew file mode 100644index 0000000..31a6a6b--- /dev/null+++ b/backend/__tests__/env-setup.ts@@ -0,0 +1,9 @@+/**+ * This file runs BEFORE the test framework is installed (via setupFiles in jest.config.ts).+ * It sets required environment variables so that ConfigService doesn't call process.exit(1)+ * when it's transitively imported by test modules.+ */+process.env.NODE_ENV = 'test';+process.env.ENCRYPTION_KEY = 'test-encryption-key-min12';+process.env.USER_NAME = 'testuser';+process.env.USER_PASSWORD = 'testpassword123';diff --git a/backend/__tests__/managers/BaseSystemManager.test.ts b/backend/__tests__/managers/BaseSystemManager.test.tsindex 57078f8..8467e8c 100644--- a/backend/__tests__/managers/BaseSystemManager.test.ts+++ b/backend/__tests__/managers/BaseSystemManager.test.ts@@ -54,11 +54,10 @@ jest.mock('https', () => ({default: { get: (...args: any[]) => httpsGetMock(...args) },}));-const promisifyMock = jest.fn();-const promisifiedExecMock = jest.fn();+const mockPromisifiedExec = jest.fn().mockResolvedValue({ stdout: '', stderr: '' });jest.mock('util', () => ({__esModule: true,- promisify: (...args: any[]) => promisifyMock(...args),+ promisify: jest.fn().mockReturnValue(mockPromisifiedExec),}));jest.mock('../../src/utils/versions', () => ({@@ -109,9 +108,9 @@ describe('BaseSystemManager', () => {beforeEach(() => {jest.clearAllMocks();- // util.promisify returns our mocked execAsync function- (promisifyMock as jest.Mock).mockReturnValue(promisifiedExecMock);- (promisifiedExecMock as jest.Mock).mockResolvedValue({ stdout: '', stderr: '' });+ // Reset the promisified exec mock for each test+ mockPromisifiedExec.mockReset();+ mockPromisifiedExec.mockResolvedValue({ stdout: '', stderr: '' });// Default OS platform linuxjest.spyOn(os, 'platform').mockReturnValue('linux' as NodeJS.Platform);@@ -242,7 +241,7 @@ describe('BaseSystemManager', () => {type: 'ext4',mount: '/',// Match current friendly name- name: 'Local Disk (/)',+ name: 'Root (/)',});const net = (res.result as any).network;expect(Array.isArray(net)).toBe(true);@@ -519,7 +518,7 @@ describe('BaseSystemManager', () => {`;// Route exec calls by command content to handle preliminary checks- (promisifiedExecMock as jest.Mock).mockImplementation((cmd: string) => {+ (mockPromisifiedExec as jest.Mock).mockImplementation((cmd: string) => {const s = String(cmd);if (/which\s+lsblk|command\s+-v\s+lsblk/i.test(s)) {return Promise.resolve({ stdout: '/usr/bin/lsblk\n', stderr: '' });diff --git a/backend/__tests__/utils/AppPaths.test.ts b/backend/__tests__/utils/AppPaths.test.tsindex 9926023..63485cb 100644--- a/backend/__tests__/utils/AppPaths.test.ts+++ b/backend/__tests__/utils/AppPaths.test.ts@@ -81,7 +81,10 @@ describe('AppPaths', () => {expect(freshAppPaths.getBaseDir()).toBe(customDir);});- it('should use ProgramData on Windows', () => {+ // These Windows tests require the native path module to handle backslashes+ const windowsIt = process.platform === 'win32' ? it : it.skip;++ windowsIt('should use ProgramData on Windows', () => {// Arrangeprocess.env.NODE_ENV = 'production';process.env.PROGRAMDATA = 'C:\\ProgramData';@@ -103,7 +106,7 @@ describe('AppPaths', () => {expect(freshAppPaths.getBaseDir()).toBe(expectedPath);});- it('should use default ProgramData path when PROGRAMDATA is not set on Windows', () => {+ windowsIt('should use default ProgramData path when PROGRAMDATA is not set on Windows', () => {// Arrangeprocess.env.NODE_ENV = 'production';delete process.env.PROGRAMDATA;diff --git a/backend/__tests__/utils/binaryPathResolver.test.ts b/backend/__tests__/utils/binaryPathResolver.test.tsindex b779cf5..0404e34 100644--- a/backend/__tests__/utils/binaryPathResolver.test.ts+++ b/backend/__tests__/utils/binaryPathResolver.test.ts@@ -197,7 +197,10 @@ describe('getBinaryPath', () => {expect(result).toBe(expectedPath);});- it('appends .exe on Windows for pkg path', () => {+ // Tests that use Windows-style paths with backslashes require native Windows path module+ const windowsIt = process.platform === 'win32' ? it : it.skip;++ windowsIt('appends .exe on Windows for pkg path', () => {(process as any).pkg = {};Object.defineProperty(process, 'execPath', {value: 'C:\\Program Files\\app\\app.exe',@@ -216,7 +219,7 @@ describe('getBinaryPath', () => {expect(result).toBe(expectedPath);});- it('appends .exe on Windows for production path', () => {+ windowsIt('appends .exe on Windows for production path', () => {Object.defineProperty(process, 'execPath', { value: 'C:\\app\\myapp.exe', writable: true });const expectedPath = path.join('C:\\app', 'restic.exe');diff --git a/backend/__tests__/utils/restic/restic.test.ts b/backend/__tests__/utils/restic/restic.test.tsindex f149abf..1e8fdd9 100644--- a/backend/__tests__/utils/restic/restic.test.ts+++ b/backend/__tests__/utils/restic/restic.test.ts@@ -239,7 +239,9 @@ describe('runResticCommand', () => {expect(onProgress).toHaveBeenCalledWith(Buffer.from(plainTextData));});- it('should replace backslashes in rclone binary path on Windows', async () => {+ // This test requires Windows path semantics (path.basename with backslashes)+ const windowsIt = process.platform === 'win32' ? it : it.skip;+ windowsIt('should replace backslashes in rclone binary path on Windows', async () => {const originalPlatform = Object.getOwnPropertyDescriptor(process, 'platform');Object.defineProperty(process, 'platform', {value: 'win32',diff --git a/backend/jest.config.ts b/backend/jest.config.tsindex a179e96..65d4750 100644--- a/backend/jest.config.ts+++ b/backend/jest.config.ts@@ -36,6 +36,7 @@ const config: Config = {// This alias is now even more important to keep imports clean'^#core-backend/(.*)$': '<rootDir>/src/$1',},+ setupFiles: ['<rootDir>/__tests__/env-setup.ts'],setupFilesAfterEnv: ['<rootDir>/__tests__/setup.ts'],transformIgnorePatterns: ['/node_modules/(?!nanoid)/'],};diff --git a/backend/src/managers/BaseSystemManager.ts b/backend/src/managers/BaseSystemManager.tsindex b215425..5a012a8 100644--- a/backend/src/managers/BaseSystemManager.ts+++ b/backend/src/managers/BaseSystemManager.ts@@ -406,7 +406,7 @@ export class BaseSystemManager {}private getFriendlyMountName(fs: any): string {- if (process.platform === 'win32') {+ if (os.platform() === 'win32') {return `Local Disk (${fs.mount})`;}diff --git a/backend/src/utils/restic/helpers.ts b/backend/src/utils/restic/helpers.tsindex 33aebad..882ec10 100644--- a/backend/src/utils/restic/helpers.ts+++ b/backend/src/utils/restic/helpers.ts@@ -12,6 +12,9 @@ export function toResticPath(srcPath: string) {// Replace backslashes with forward slashesnormalizedPath = normalizedPath.replace(/\\/g, '/');+ // Collapse redundant forward slashes (preserve leading // for UNC paths)+ normalizedPath = normalizedPath.replace(/([^/])\/+/g, '$1/');+// Remove the colon after the drive letter, if presentnormalizedPath = normalizedPath.replace(/^([A-Za-z]):/, '$1');