Skip to content

A modern, self-hosted backup solution for secure, encrypted backups across local and cloud storage.

fix: incorrect cron schedule for 12AM backup plans

towfiqid10c02262cbf
diff --git a/backend/__tests__/utils/intervalToCron.test.ts b/backend/__tests__/utils/intervalToCron.test.ts
index a1ec77d..6351600 100644
--- a/backend/__tests__/utils/intervalToCron.test.ts
+++ b/backend/__tests__/utils/intervalToCron.test.ts
@@ -66,7 +66,7 @@ describe('intervalToCron', () => {
describe('daily intervals', () => {
it('should return cron for daily at midnight', () => {
const interval: PlanInterval = { type: 'daily', time: '12:00AM' };
- expect(intervalToCron(interval)).toBe('00 12 * * *');
+ expect(intervalToCron(interval)).toBe('00 0 * * *');
});
it('should return cron for daily at 9:00 AM', () => {
@@ -168,12 +168,12 @@ describe('intervalToCron', () => {
describe('time parsing', () => {
it('should handle 12:00 PM correctly', () => {
const interval: PlanInterval = { type: 'daily', time: '12:00PM' };
- expect(intervalToCron(interval)).toBe('00 24 * * *');
+ expect(intervalToCron(interval)).toBe('00 12 * * *');
});
it('should handle 12:00 AM correctly', () => {
const interval: PlanInterval = { type: 'daily', time: '12:00AM' };
- expect(intervalToCron(interval)).toBe('00 12 * * *');
+ expect(intervalToCron(interval)).toBe('00 0 * * *');
});
it('should handle 1:00 AM correctly', () => {
diff --git a/backend/src/utils/intervalToCron.ts b/backend/src/utils/intervalToCron.ts
index 3b23c65..bbbef42 100644
--- a/backend/src/utils/intervalToCron.ts
+++ b/backend/src/utils/intervalToCron.ts
@@ -15,7 +15,16 @@ export function intervalToCron(interval: PlanInterval): string {
? interval.time.match(/(\d+):(\d+)([AaPp][Mm])/)?.slice(1, 3) || []
: [];
const isPM = interval.time?.toLowerCase().includes('pm');
- const hour = hours ? (isPM ? (parseInt(hours) + 12).toString() : hours) : '0';
+ const parsedHour = hours ? parseInt(hours, 10) : 0;
+
+ let hour = '0';
+ if (hours) {
+ if (isPM) {
+ hour = parsedHour === 12 ? '12' : String(parsedHour + 12);
+ } else {
+ hour = parsedHour === 12 ? '0' : String(parsedHour);
+ }
+ }
switch (interval.type) {
case 'hourly':