Skip to content

A modern, self-hosted backup solution for secure, encrypted backups across local and cloud storage.

fix: possible memory leak issue

towfiqif36deabe5763
diff --git a/backend/package.json b/backend/package.json
index ae37e12..0cc158a 100644
--- a/backend/package.json
+++ b/backend/package.json
@@ -29,6 +29,7 @@
"express-session": "^1.19.0",
"helmet": "^8.1.0",
"jsonwebtoken": "^9.0.3",
+ "memorystore": "^1.6.8",
"nanoid": "^5.0.9",
"node-ssh": "^13.2.0",
"nodemailer": "8.0.1",
diff --git a/backend/src/createApp.ts b/backend/src/createApp.ts
index 50504d8..651a723 100644
--- a/backend/src/createApp.ts
+++ b/backend/src/createApp.ts
@@ -4,6 +4,7 @@ import express, { type Express } from 'express';
import { IncomingMessage, ServerResponse } from 'http';
import cors from 'cors';
import session from 'express-session';
+import createMemoryStore from 'memorystore';
import helmet from 'helmet';
import rateLimit from 'express-rate-limit';
import { db } from './db';
@@ -53,6 +54,8 @@ import { initializeLogger } from './utils/logger';
import { configService } from './services/ConfigService';
import { BaseRestoreManager } from './managers/BaseRestoreManager';
+const MemoryStore = createMemoryStore(session);
+
export async function createApp(): Promise<{ app: Express }> {
// Initialize Logger
initializeLogger();
@@ -138,13 +141,16 @@ export async function createApp(): Promise<{ app: Express }> {
// Session Middleware for 2FA Setup Process
app.use(
session({
+ store: new MemoryStore({
+ checkPeriod: 86400000,
+ }),
secret: configService.config.SECRET,
resave: false,
saveUninitialized: false,
cookie: {
secure: configService.config.APP_URL?.startsWith('https'),
httpOnly: true,
- maxAge: 1000 * 60 * 15, // 15 minutes
+ maxAge: 1000 * 60 * 15,
},
})
);
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 7cf2cb6..d91f77e 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -83,6 +83,9 @@ importers:
jsonwebtoken:
specifier: ^9.0.3
version: 9.0.3
+ memorystore:
+ specifier: ^1.6.8
+ version: 1.6.8
nanoid:
specifier: ^5.0.9
version: 5.1.6
@@ -273,7 +276,7 @@ importers:
version: 10.1.8([email protected])
eslint-plugin-import:
specifier: ^2.32.0
+ version: 2.32.0([email protected])
eslint-plugin-react-hooks:
specifier: ^7.0.1
version: 7.0.1([email protected])
@@ -4705,6 +4708,9 @@ packages:
resolution: {integrity: sha512-JNAzZcXrCt42VGLuYz0zfAzDfAvJWW6AfYlDBQyDV5DClI2m5sAmK+OIO7s59XfsRsWHp02jAJrRadPRGTt6SQ==}
+ resolution: {integrity: sha512-sWZlbEP2OsHNkXrMl5GYk/jKk70MBng6UU4YI/qGDYbgf6YbP4EvmqISbXCoJiRKs+1bSpFHVgQxvJ17F2li5g==}
+
resolution: {integrity: sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==}
@@ -4760,6 +4766,10 @@ packages:
resolution: {integrity: sha512-zYiwtZUcYyXKo/np96AGZAckk+FWWsUdJ3cHGGmld7+AhvcWmQyGCYUh1hc4Q/pkOhb65dQR/pqCyK0cOaHz4Q==}
+ resolution: {integrity: sha512-kC3svB2LXnLAnndjxKjXy8FkrScazufhNweSd2JyJAKbK3jXYfL38qf/GI6tAQp6VXQ5QoNLdcO2qIg5g45EVQ==}
+ engines: {node: '>=0.10'}
+
resolution: {integrity: sha512-r85E3NdZ+mpYk1C6RjPFEMSE+s1iZMuHtsHAqY0DT3jZczl0diWUZ8g6oU7h0M9cD2EL+PzaYghhCLzR0ZNn5Q==}
engines: {node: '>=10'}
@@ -5241,6 +5251,9 @@ packages:
resolution: {integrity: sha512-yPw4Sng1gWghHQWj0B3ZggWUm4qVbPwPFcRG8KyxiU7J2OHFSoEHKS+EZ3fv5l1t9CyCiop6l/ZYeWbrgoQejw==}
+ resolution: {integrity: sha512-b/YwNhb8lk1Zz2+bXXpS/LK9OisiZZ1SNsSLxN1x2OXVEhW2Ckr/7mWE5vrC1ZTiJlD9g19jWszTmJsB+oEpFQ==}
+
resolution: {integrity: sha512-todwxLMY7/heScKmntwQG8CXVkWUOdYxIvY2s0VWAAMh/nd8SoYiRaKjlr7+iCs984f2P8zvrfWcDDYVb73NfA==}
@@ -6490,6 +6503,9 @@ packages:
resolution: {integrity: sha512-0pfFzegeDWJHJIAmTLRP2DwHjdF5s7jo9tuztdQxAhINCdvS+3nGINqPd00AphqJR/0LhANUS6/+7SCb98YOfA==}
engines: {node: '>=10'}
+ resolution: {integrity: sha512-ncTzHV7NvsQZkYe1DW7cbDLm0YpzHmZF5r/iyP3ZnQtMiJ+pjzisCiMNI+Sj+xQF5pXhSHxSB3uDbsBTzY/c2A==}
+
resolution: {integrity: sha512-a4UGQaWPH59mOXUYnAG2ewncQS4i4F43Tv3JoAM+s2VDAmS9NsK8GpDMLrCHPksFT7h3K6TOoUNn2pb7RoXx4g==}
@@ -9985,17 +10001,16 @@ snapshots:
transitivePeerDependencies:
- supports-color
dependencies:
debug: 3.2.7
optionalDependencies:
- '@typescript-eslint/parser': 8.56.0([email protected])([email protected])
eslint: 10.0.0
eslint-import-resolver-node: 0.3.9
transitivePeerDependencies:
- supports-color
dependencies:
'@rtsao/scc': 1.1.0
array-includes: 3.1.9
@@ -10006,7 +10021,7 @@ snapshots:
doctrine: 2.1.0
eslint: 10.0.0
eslint-import-resolver-node: 0.3.9
+ eslint-module-utils: 2.12.1([email protected])([email protected])
hasown: 2.0.2
is-core-module: 2.16.1
is-glob: 4.0.3
@@ -10017,8 +10032,6 @@ snapshots:
semver: 6.3.1
string.prototype.trimend: 1.0.9
tsconfig-paths: 3.15.0
- optionalDependencies:
- '@typescript-eslint/parser': 8.56.0([email protected])([email protected])
transitivePeerDependencies:
- eslint-import-resolver-typescript
- eslint-import-resolver-webpack
@@ -11188,6 +11201,11 @@ snapshots:
+ dependencies:
+ pseudomap: 1.0.2
+ yallist: 2.1.2
+
dependencies:
yallist: 3.1.1
@@ -11236,6 +11254,13 @@ snapshots:
+ dependencies:
+ debug: 4.4.3
+ lru-cache: 4.1.5
+ transitivePeerDependencies:
+ - supports-color
+
dependencies:
'@types/minimist': 1.2.5
@@ -11689,6 +11714,8 @@ snapshots:
optional: true
+
dependencies:
end-of-stream: 1.4.5
@@ -13183,6 +13210,8 @@ snapshots:
+