Skip to content

armgit / posta

Public Imported from GitHub
0

Self-hosted email delivery platform that enables applications to send emails via HTTP APIs while handling SMTP delivery, templates, storage, security, and analytics. Fully self-hostable alternative to services like SendGrid or Mailgun.

fix(db): stop Save cascading a partial user row from ActorRef Updating a form returned 500:

Jonas Kaninda68563e3effe1
diff --git a/internal/models/api_key.go b/internal/models/api_key.go
index a378f84..a5a1178 100644
--- a/internal/models/api_key.go
+++ b/internal/models/api_key.go
@@ -46,7 +46,7 @@ type APIKey struct {
Scopes pq.StringArray `json:"scopes" gorm:"type:text[]"`
User User `json:"-" gorm:"foreignKey:UserID"`
- CreatedBy *ActorRef `json:"created_by,omitempty" gorm:"foreignKey:UserID;references:ID;constraint:false"`
+ CreatedBy *ActorRef `json:"created_by,omitempty" gorm:"->;foreignKey:UserID;references:ID;constraint:false"`
}
// HasScope reports whether the key grants scope s. An empty scope set means the
diff --git a/internal/models/form.go b/internal/models/form.go
index b29593e..91b9221 100644
--- a/internal/models/form.go
+++ b/internal/models/form.go
@@ -77,7 +77,7 @@ type Form struct {
UpdatedAt *time.Time `json:"updated_at,omitempty"`
DeletedAt gorm.DeletedAt `json:"-" gorm:"index"`
- LastEditedBy *ActorRef `json:"last_edited_by,omitempty" gorm:"foreignKey:LastEditedByID;references:ID;constraint:false"`
+ LastEditedBy *ActorRef `json:"last_edited_by,omitempty" gorm:"->;foreignKey:LastEditedByID;references:ID;constraint:false"`
}
func (f *Form) IsActive() bool { return f.Status == FormStatusActive }
diff --git a/internal/models/message.go b/internal/models/message.go
index b908036..40067d5 100644
--- a/internal/models/message.go
+++ b/internal/models/message.go
@@ -84,7 +84,7 @@ type Message struct {
Attachments []InboundAttachmentMeta `json:"attachments,omitempty" gorm:"-"`
Form *Form `json:"form,omitempty" gorm:"foreignKey:FormID;constraint:false"`
- AssignedTo *ActorRef `json:"assigned_to,omitempty" gorm:"foreignKey:AssignedToID;references:ID;constraint:false"`
+ AssignedTo *ActorRef `json:"assigned_to,omitempty" gorm:"->;foreignKey:AssignedToID;references:ID;constraint:false"`
Replies []MessageReply `json:"replies,omitempty" gorm:"foreignKey:MessageID"`
}
@@ -115,5 +115,5 @@ type MessageReply struct {
CreatedAt time.Time `json:"created_at"`
- Author *ActorRef `json:"author,omitempty" gorm:"foreignKey:AuthorID;references:ID;constraint:false"`
+ Author *ActorRef `json:"author,omitempty" gorm:"->;foreignKey:AuthorID;references:ID;constraint:false"`
}
diff --git a/internal/models/template.go b/internal/models/template.go
index e46d6f2..6b5591c 100644
--- a/internal/models/template.go
+++ b/internal/models/template.go
@@ -20,6 +20,6 @@ type Template struct {
User User `json:"-" gorm:"foreignKey:UserID"`
ActiveVersion *TemplateVersion `json:"active_version,omitempty" gorm:"foreignKey:ActiveVersionID;constraint:false"`
- CreatedBy *ActorRef `json:"created_by,omitempty" gorm:"foreignKey:UserID;references:ID;constraint:false"`
- LastEditedBy *ActorRef `json:"last_edited_by,omitempty" gorm:"foreignKey:LastEditedByID;references:ID;constraint:false"`
+ CreatedBy *ActorRef `json:"created_by,omitempty" gorm:"->;foreignKey:UserID;references:ID;constraint:false"`
+ LastEditedBy *ActorRef `json:"last_edited_by,omitempty" gorm:"->;foreignKey:LastEditedByID;references:ID;constraint:false"`
}
diff --git a/internal/storage/repositories/actor_cascade_test.go b/internal/storage/repositories/actor_cascade_test.go
new file mode 100644
index 0000000..3f90576
--- /dev/null
+++ b/internal/storage/repositories/actor_cascade_test.go
@@ -0,0 +1,120 @@
+// SPDX-FileCopyrightText: 2026 Jonas Kaninda
+// SPDX-License-Identifier: AGPL-3.0-or-later
+
+package repositories
+
+import (
+ "testing"
+
+ "github.com/goposta/posta/internal/models"
+ "gorm.io/gorm"
+)
+
+func seedActor(t *testing.T, tx *gorm.DB, email string) uint {
+ t.Helper()
+ u := &models.User{Name: "Jonas Kaninda", Email: email, PasswordHash: "x"}
+ if err := tx.Create(u).Error; err != nil {
+ t.Fatalf("create user: %v", err)
+ }
+ return u.ID
+}
+
+func seedWorkspace(t *testing.T, tx *gorm.DB, ownerID uint, slug string) uint {
+ t.Helper()
+ ws := &models.Workspace{Name: "Acme", Slug: slug, OwnerID: ownerID}
+ if err := tx.Create(ws).Error; err != nil {
+ t.Fatalf("create workspace: %v", err)
+ }
+ return ws.ID
+}
+
+func TestFormUpdateDoesNotCascadeIntoUsers(t *testing.T) {
+ db := testDB(t)
+ if err := db.AutoMigrate(&models.User{}, &models.Workspace{}, &models.Form{}); err != nil {
+ t.Skipf("skipping: cannot migrate schema: %v", err)
+ }
+ tx := db.Begin()
+ t.Cleanup(func() { tx.Rollback() })
+
+ userID := seedActor(t, tx, "[email protected]")
+ wsID := seedWorkspace(t, tx, userID, "form-cascade")
+
+ repo := NewFormRepository(tx)
+ form := &models.Form{
+ WorkspaceID: &wsID, Name: "Contact", Slug: "contact",
+ PublicKey: "form-cascade-key", Status: models.FormStatusActive,
+ LastEditedByID: &userID,
+ }
+ if err := repo.Create(form); err != nil {
+ t.Fatalf("create form: %v", err)
+ }
+
+ // Read it back the way the handler does — with LastEditedBy preloaded.
+ loaded, err := repo.FindByID(form.ID)
+ if err != nil {
+ t.Fatalf("find form: %v", err)
+ }
+ if loaded.LastEditedBy == nil {
+ t.Fatal("expected LastEditedBy to be preloaded; this test proves nothing without it")
+ }
+
+ loaded.Name = "Contact form"
+ if err := repo.Update(loaded); err != nil {
+ t.Fatalf("update form must not cascade into users: %v", err)
+ }
+}
+
+func TestMessageUpdateDoesNotCascadeIntoUsers(t *testing.T) {
+ db := testDB(t)
+ if err := db.AutoMigrate(
+ &models.User{}, &models.Workspace{}, &models.Form{},
+ &models.Message{}, &models.MessageReply{},
+ ); err != nil {
+ t.Skipf("skipping: cannot migrate schema: %v", err)
+ }
+ tx := db.Begin()
+ t.Cleanup(func() { tx.Rollback() })
+
+ userID := seedActor(t, tx, "[email protected]")
+ wsID := seedWorkspace(t, tx, userID, "msg-cascade")
+
+ formRepo := NewFormRepository(tx)
+ form := &models.Form{
+ WorkspaceID: &wsID, Name: "Contact", Slug: "contact",
+ PublicKey: "msg-cascade-key", Status: models.FormStatusActive,
+ }
+ if err := formRepo.Create(form); err != nil {
+ t.Fatalf("create form: %v", err)
+ }
+
+ repo := NewMessageRepository(tx)
+ msg := &models.Message{
+ WorkspaceID: &wsID, FormID: form.ID,
+ SenderEmail: "[email protected]", Subject: "Hello",
+ Status: models.MessageStatusReceived, State: models.MessageStateNew,
+ ThreadToken: "msg-cascade-token", AssignedToID: &userID,
+ }
+ if err := repo.Create(msg); err != nil {
+ t.Fatalf("create message: %v", err)
+ }
+ if err := repo.AddReply(&models.MessageReply{
+ MessageID: msg.ID, WorkspaceID: &wsID, Kind: models.MessageReplyKindOperator,
+ AuthorID: userID, FromAddr: "[email protected]", ToAddr: "[email protected]",
+ }); err != nil {
+ t.Fatalf("add reply: %v", err)
+ }
+
+ scope := ResourceScope{UserID: userID, WorkspaceID: &wsID}
+ loaded, err := repo.FindByUUIDForScope(scope, msg.UUID)
+ if err != nil {
+ t.Fatalf("find message: %v", err)
+ }
+ if loaded.AssignedTo == nil || len(loaded.Replies) == 0 || loaded.Replies[0].Author == nil {
+ t.Fatal("expected AssignedTo and Replies[].Author to be preloaded; this test proves nothing without them")
+ }
+
+ loaded.State = models.MessageStateReplied
+ if err := repo.Update(loaded); err != nil {
+ t.Fatalf("update message must not cascade into users: %v", err)
+ }
+}
diff --git a/internal/storage/repositories/form_repo.go b/internal/storage/repositories/form_repo.go
index bc00c71..1c30012 100644
--- a/internal/storage/repositories/form_repo.go
+++ b/internal/storage/repositories/form_repo.go
@@ -8,6 +8,7 @@ import (
"github.com/goposta/posta/internal/models"
"gorm.io/gorm"
+ "gorm.io/gorm/clause"
)
type FormRepository struct {
@@ -23,7 +24,7 @@ func (r *FormRepository) Create(f *models.Form) error {
}
func (r *FormRepository) Update(f *models.Form) error {
- return r.db.Save(f).Error
+ return r.db.Omit(clause.Associations).Save(f).Error
}
func (r *FormRepository) FindByID(id uint) (*models.Form, error) {
diff --git a/internal/storage/repositories/message_filter_repo.go b/internal/storage/repositories/message_filter_repo.go
index 2f0eac6..611b0f2 100644
--- a/internal/storage/repositories/message_filter_repo.go
+++ b/internal/storage/repositories/message_filter_repo.go
@@ -8,6 +8,7 @@ import (
"github.com/goposta/posta/internal/models"
"gorm.io/gorm"
+ "gorm.io/gorm/clause"
)
type MessageFilterRepository struct {
@@ -23,7 +24,7 @@ func (r *MessageFilterRepository) Create(f *models.MessageFilter) error {
}
func (r *MessageFilterRepository) Update(f *models.MessageFilter) error {
- return r.db.Save(f).Error
+ return r.db.Omit(clause.Associations).Save(f).Error
}
func (r *MessageFilterRepository) FindByIDForScope(scope ResourceScope, id uint) (*models.MessageFilter, error) {
diff --git a/internal/storage/repositories/message_repo.go b/internal/storage/repositories/message_repo.go
index d34c413..4a710a3 100644
--- a/internal/storage/repositories/message_repo.go
+++ b/internal/storage/repositories/message_repo.go
@@ -9,6 +9,7 @@ import (
"github.com/goposta/posta/internal/models"
"gorm.io/gorm"
+ "gorm.io/gorm/clause"
)
type MessageFilterQuery struct {
@@ -35,7 +36,7 @@ func (r *MessageRepository) Create(m *models.Message) error {
}
func (r *MessageRepository) Update(m *models.Message) error {
- return r.db.Save(m).Error
+ return r.db.Omit(clause.Associations).Save(m).Error
}
func (r *MessageRepository) FindByID(id uint) (*models.Message, error) {