Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

3.7 KB
Raw Blame
//! End-to-end tests for the per-team /flags body-logger config refresh path.
//!
//! Verifies that a row written to `posthog_instancesetting` under
//! `constance:posthog:FLAGS_LOG_BODIES_TEAMS` propagates into the Rust
//! service's in-memory config when `BodyLogger::do_refresh` runs.
//!
//! All scenarios share one combined test so they don't race on the same
//! `posthog_instancesetting` row when cargo runs integration tests in parallel.

use feature_flags::config::{BodyLogTeams, Config};
use feature_flags::handler::body_logger::BodyLogger;
use feature_flags::utils::test_utils::TestContext;
use sqlx::postgres::PgPoolOptions;

fn pg_pool_from_config(config: &Config) -> sqlx::PgPool {
    PgPoolOptions::new()
        .max_connections(2)
        .connect_lazy(&config.read_database_url)
        .expect("failed to create test PgPool")
}

#[tokio::test]
async fn test_db_body_logger_refresh() {
    let context = TestContext::new(None).await;
    context
        .delete_instance_setting("FLAGS_LOG_BODIES_TEAMS")
        .await
        .unwrap();

    let pool = pg_pool_from_config(&Config::default_test_config());

    // --- Scenario 1: missing row preserves env-var default ---
    {
        let mut initial = std::collections::HashMap::new();
        initial.insert(42, vec!["env-default".into()]);
        let logger = BodyLogger::new(BodyLogTeams(initial), 65_536);

        logger.do_refresh(&pool).await;

        let patterns = logger
            .for_team(42)
            .expect("missing DB row should preserve env-var default");
        assert!(patterns.matches("env-default"));
        assert!(!patterns.matches("other-flag"));
    }

    // --- Scenario 2: wildcard pattern yields log-all ---
    {
        let logger = BodyLogger::new(BodyLogTeams::default(), 65_536);
        assert!(logger.for_team(123).is_none(), "scenario 2: starts empty");

        context
            .set_instance_setting("FLAGS_LOG_BODIES_TEAMS", r#"{"123": ["*"]}"#)
            .await
            .unwrap();

        logger.do_refresh(&pool).await;

        let patterns = logger
            .for_team(123)
            .expect("scenario 2: team 123 should be enabled after refresh");
        assert!(
            patterns.matches("anything"),
            "scenario 2: wildcard matches any flag key"
        );
        assert!(
            logger.for_team(456).is_none(),
            "scenario 2: team 456 stays unlisted"
        );
    }

    // --- Scenario 3: non-empty patterns filter by flag key ---
    {
        context
            .set_instance_setting(
                "FLAGS_LOG_BODIES_TEAMS",
                r#"{"789": ["my-feature", "checkout-*"]}"#,
            )
            .await
            .unwrap();

        let logger = BodyLogger::new(BodyLogTeams::default(), 65_536);
        logger.do_refresh(&pool).await;

        let patterns = logger
            .for_team(789)
            .expect("scenario 3: team 789 should be enabled after refresh");
        assert!(patterns.matches("my-feature"));
        assert!(patterns.matches("checkout-foo"));
        assert!(!patterns.matches("other-flag"));
    }

    // --- Scenario 4: Django string-encoded value also parses ---
    {
        context
            .set_instance_setting("FLAGS_LOG_BODIES_TEAMS", r#""{\"555\": [\"*\"]}""#)
            .await
            .unwrap();

        let logger = BodyLogger::new(BodyLogTeams::default(), 65_536);
        logger.do_refresh(&pool).await;

        let patterns = logger
            .for_team(555)
            .expect("scenario 4: team 555 should be enabled after refresh");
        assert!(patterns.matches("anything"), "scenario 4: wildcard matches");
    }

    context
        .delete_instance_setting("FLAGS_LOG_BODIES_TEAMS")
        .await
        .unwrap();
}