:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(replay): move the watch filter bar and chips to quill (#127794)
Hayne Ryu03efda90208b
diff --git a/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx b/frontend/src/scenes/session-recordings/playlist/FilterChips.tsxindex 59fafafdcaff..b2b27e555b5e 100644--- a/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx+++ b/frontend/src/scenes/session-recordings/playlist/FilterChips.tsx@@ -1,8 +1,8 @@import { useActions, useValues } from 'kea'import { ReactNode, useState } from 'react'-import { IconClock, IconEye, IconPerson, IconX } from '@posthog/icons'-import { LemonButton } from '@posthog/lemon-ui'+import { IconClock, IconEye, IconPerson } from '@posthog/icons'+import { Button, Chip, ChipClose } from '@posthog/quill'import { convertSecondsToDuration } from 'lib/components/DurationPicker/DurationPicker'import { UniversalFilterButton } from 'lib/components/UniversalFilters/UniversalFilterButton'@@ -114,17 +114,15 @@ export function FilterChips({const visible = expanded || hiddenCount <= 0 ? chips : chips.slice(0, MAX_VISIBLE_CHIPS)return (- <div className="flex items-center gap-1 flex-wrap min-w-0" data-attr="list-filter-chips">+ <div data-quill className="flex items-center gap-1 flex-wrap min-w-0" data-attr="list-filter-chips">{visible}{hiddenCount > 0 && (- <LemonButton- size="xsmall"- type="tertiary"+ <ButtononClick={() => setExpanded(!expanded)}data-attr={expanded ? 'list-filter-chips-collapse' : 'list-filter-chips-expand'}>{expanded ? 'Show less' : `+${hiddenCount} more`}- </LemonButton>+ </Button>)}</div>)@@ -142,15 +140,10 @@ function FilterChip({children: ReactNode}): JSX.Element {return (- <div- className="UniversalFilterButton UniversalFilterButton--closeable inline-flex items-center ph-no-capture"- data-attr={dataAttr}- >- <div className="flex items-center flex-1 truncate gap-1">- <span className="shrink-0 text-secondary">{icon}</span>- <span className="truncate">{children}</span>- </div>- <LemonButton size="xsmall" icon={<IconX className="w-3 h-3" />} onClick={onClose} className="p-0.5" />- </div>+ <Chip className="max-w-60 ph-no-capture" data-attr={dataAttr}>+ <span className="shrink-0 text-muted-foreground">{icon}</span>+ <span className="truncate">{children}</span>+ <ChipClose onClick={onClose} aria-label="Remove filter" />+ </Chip>)}diff --git a/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx b/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsxindex c52778bd0567..3e53cea53257 100644--- a/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx+++ b/frontend/src/scenes/session-recordings/playlist/ReplayFilterBar.tsx@@ -3,7 +3,7 @@ import { useActions, useValues } from 'kea'import { useState } from 'react'import { IconFilter, IconRefresh } from '@posthog/icons'-import { LemonBadge, LemonButton } from '@posthog/lemon-ui'+import { Badge, Button, Toggle, Tooltip, TooltipContent, TooltipTrigger } from '@posthog/quill'import { useMaxTool } from 'scenes/max/useMaxTool'import { SaveFiltersModal } from 'scenes/session-recordings/filters/RecordingsUniversalFiltersEmbed'@@ -57,36 +57,42 @@ export function ReplayFilterBar({const edited = !!appliedSavedFilter && !equal(appliedSavedFilterFilters, comparableRecordingFilters(filters))return (- <div className="flex flex-col gap-1">+ <div data-quill className="flex flex-col gap-1 text-foreground"><div className="flex items-start gap-1" data-attr="list-filter-bar"><div className="flex flex-1 min-w-0 items-center gap-1 flex-wrap">- <LemonButton- size="small"- type="secondary"- active={isFiltersExpanded}- icon={<IconFilter />}- onClick={() => setIsFiltersExpanded(!isFiltersExpanded)}- tooltip={isFiltersExpanded ? 'Hide filters' : 'Add a filter'}- aria-label="Add a filter"- data-attr="filter-recordings-button"- >- {totalFiltersCount ? <LemonBadge.Number count={totalFiltersCount} size="small" /> : null}- </LemonButton>+ <Tooltip>+ <TooltipTrigger+ render={+ <Toggle+ variant="outline"+ pressed={isFiltersExpanded}+ onPressedChange={setIsFiltersExpanded}+ aria-label="Add a filter"+ data-attr="filter-recordings-button"+ />+ }+ >+ <IconFilter />+ {totalFiltersCount ? <Badge>{totalFiltersCount}</Badge> : null}+ </TooltipTrigger>+ <TooltipContent>{isFiltersExpanded ? 'Hide filters' : 'Add a filter'}</TooltipContent>+ </Tooltip><SavedFilterSelect edited={edited} onSaveCurrent={() => setSaveModalOpen(true)} />{savedFilterChips && <SavedFilterChips edited={edited} />}<FilterChips filters={filters} setFilters={setFilters} /></div>- <LemonButton- size="small"- type="secondary"+ <Button+ variant="outline"+ size="icon"className="shrink-0"- icon={<IconRefresh />}loading={sessionRecordingsResponseLoading}onClick={onReload}tooltip="Refresh list"aria-label="Refresh list"data-attr="refresh-recordings-list"- />+ >+ <IconRefresh />+ </Button></div>{edited && <SavedFilterEditedBar filters={filters} onSaveAsCopy={() => setSaveModalOpen(true)} />}<SaveFiltersModal isOpen={saveModalOpen} setIsOpen={setSaveModalOpen} filters={filters} />diff --git a/frontend/src/scenes/session-recordings/playlist/SavedFilterChips.tsx b/frontend/src/scenes/session-recordings/playlist/SavedFilterChips.tsxindex 7de0051c73c2..dbd1821dd577 100644--- a/frontend/src/scenes/session-recordings/playlist/SavedFilterChips.tsx+++ b/frontend/src/scenes/session-recordings/playlist/SavedFilterChips.tsx@@ -1,6 +1,6 @@import { useActions, useValues } from 'kea'-import { LemonButton } from '@posthog/lemon-ui'+import { Toggle } from '@posthog/quill'import { sessionRecordingSavedFiltersLogic } from 'scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic'@@ -33,18 +33,16 @@ export function SavedFilterChips({ edited }: { edited: boolean }): JSX.Element |return (<>{savedFilters.results.slice(0, MAX_CHIPS).map((filter) => (- <LemonButton+ <Togglekey={filter.short_id}- size="small"- type="secondary"- active={!edited && filter.short_id === appliedSavedFilter?.short_id}- onClick={() => apply(filter)}+ variant="outline"+ pressed={!edited && filter.short_id === appliedSavedFilter?.short_id}+ onPressedChange={() => apply(filter)}className="max-w-60"- truncatedata-attr="list-saved-filter-chip">- {filter.name || filter.derived_name || 'Unnamed'}- </LemonButton>+ <span className="truncate">{filter.name || filter.derived_name || 'Unnamed'}</span>+ </Toggle>))}</>)diff --git a/frontend/src/scenes/session-recordings/playlist/SavedFilterEditedBar.tsx b/frontend/src/scenes/session-recordings/playlist/SavedFilterEditedBar.tsxindex c29150d7a493..231da85138b9 100644--- a/frontend/src/scenes/session-recordings/playlist/SavedFilterEditedBar.tsx+++ b/frontend/src/scenes/session-recordings/playlist/SavedFilterEditedBar.tsx@@ -1,8 +1,9 @@import { useActions, useValues } from 'kea'import { useState } from 'react'-import { LemonButton, lemonToast } from '@posthog/lemon-ui'+import { Button } from '@posthog/quill'+import { lemonToast } from 'lib/lemon-ui/LemonToast/LemonToast'import { sessionRecordingSavedFiltersLogic } from 'scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic'import { RecordingUniversalFilters } from '~/types'@@ -48,23 +49,20 @@ export function SavedFilterEditedBar({className="flex items-center gap-2 flex-wrap rounded border border-warning bg-warning-highlight px-2 py-1 text-xs"data-attr="list-saved-filter-edited">- <span className="text-secondary">Saved filter changed.</span>- <LemonButton- size="xsmall"- type="secondary"+ <span className="text-muted-foreground">Saved filter changed.</span>+ <Button+ variant="outline"loading={updating}onClick={() => void update()}className="max-w-60"- truncatedata-attr="list-saved-filter-update">- Update "{appliedSavedFilter.name || 'Unnamed'}"- </LemonButton>- <LemonButton size="xsmall" onClick={onSaveAsCopy} data-attr="list-saved-filter-save-copy">+ <span className="truncate">Update "{appliedSavedFilter.name || 'Unnamed'}"</span>+ </Button>+ <Button onClick={onSaveAsCopy} data-attr="list-saved-filter-save-copy">Save as copy- </LemonButton>- <LemonButton- size="xsmall"+ </Button>+ <ButtononClick={() => {if (appliedSavedFilterFilters) {applySavedFilter(appliedSavedFilterFilters)@@ -73,7 +71,7 @@ export function SavedFilterEditedBar({data-attr="list-saved-filter-revert">Revert- </LemonButton>+ </Button></div>)}diff --git a/frontend/src/scenes/session-recordings/playlist/SavedFilterSelect.tsx b/frontend/src/scenes/session-recordings/playlist/SavedFilterSelect.tsxindex 0acf58aed669..e5a1ebdbe9b4 100644--- a/frontend/src/scenes/session-recordings/playlist/SavedFilterSelect.tsx+++ b/frontend/src/scenes/session-recordings/playlist/SavedFilterSelect.tsx@@ -2,15 +2,16 @@ import { useActions, useValues } from 'kea'import { useEffect } from 'react'import { IconChevronDown, IconFilter } from '@posthog/icons'-import { LemonButton } from '@posthog/lemon-ui'+import { Button, DropdownMenu, DropdownMenuContent, DropdownMenuTrigger } from '@posthog/quill'-import { LemonMenu, LemonMenuItems } from 'lib/lemon-ui/LemonMenu/LemonMenu'+import { LemonMenuItems } from 'lib/lemon-ui/LemonMenu/LemonMenu'import { sessionRecordingSavedFiltersLogic } from 'scenes/session-recordings/filters/sessionRecordingSavedFiltersLogic'import { SessionRecordingPlaylistType } from '~/types'import { playlistFiltersLogic } from './playlistFiltersLogic'import { stripSessionIds } from './playlistUtils'+import { QuillMenuItems } from './QuillMenuItems'import { asUniversalFilters, sessionRecordingsPlaylistLogic } from './sessionRecordingsPlaylistLogic'const savedFilterName = (filter: SessionRecordingPlaylistType): string =>@@ -84,21 +85,27 @@ export function SavedFilterSelect({]return (- <LemonMenu items={items} placement="bottom-start" buttonSize="small">- <LemonButton- size="small"- type="secondary"- active={!!appliedSavedFilter}- icon={appliedSavedFilter ? <IconFilter /> : undefined}- sideIcon={<IconChevronDown />}- className="max-w-60"- truncate- data-attr="list-saved-filter-select"+ <DropdownMenu>+ <DropdownMenuTrigger+ render={+ <Button+ variant={appliedSavedFilter ? 'secondary' : 'outline'}+ className="max-w-60"+ data-attr="list-saved-filter-select"+ />+ }>- {appliedSavedFilter- ? `${savedFilterName(appliedSavedFilter)}${edited ? ' (edited)' : ''}`- : 'All recordings'}- </LemonButton>- </LemonMenu>+ {appliedSavedFilter && <IconFilter />}+ <span className="truncate">+ {appliedSavedFilter+ ? `${savedFilterName(appliedSavedFilter)}${edited ? ' (edited)' : ''}`+ : 'All recordings'}+ </span>+ <IconChevronDown />+ </DropdownMenuTrigger>+ <DropdownMenuContent align="start">+ <QuillMenuItems items={items} />+ </DropdownMenuContent>+ </DropdownMenu>)}