:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(metrics): keep the chart interval in the viewer URL (#126160)
Christiaan Hendriksen04eb45547afc
diff --git a/products/metrics/frontend/metricsLinks.test.ts b/products/metrics/frontend/metricsLinks.test.tsindex 9196454a6b7c..99673bb23e0c 100644--- a/products/metrics/frontend/metricsLinks.test.ts+++ b/products/metrics/frontend/metricsLinks.test.ts@@ -36,10 +36,11 @@ describe('metricsLinks', () => {).toMatchObject({ metricType: 'sum', aggregation: 'rate' })})- it('carries the time window', () => {- expect(paramsOf(metricUrl({ dateFrom: '-7d', dateTo: '-1d' }))).toMatchObject({+ it('carries the time window and the chart interval', () => {+ expect(paramsOf(metricUrl({ dateFrom: '-7d', dateTo: '-1d', interval: 'minute_5' }))).toMatchObject({dateFrom: '-7d',dateTo: '-1d',+ interval: 'minute_5',})})diff --git a/products/metrics/frontend/metricsLinks.ts b/products/metrics/frontend/metricsLinks.tsindex fda7591b7fcf..3e6599e1da72 100644--- a/products/metrics/frontend/metricsLinks.ts+++ b/products/metrics/frontend/metricsLinks.ts@@ -20,6 +20,7 @@ export interface MetricLinkParams {aggregation?: stringdateFrom?: string | nulldateTo?: string | null+ interval?: string | nullgroupBy?: string[]filterGroup?: UniversalFiltersGroup}@@ -60,6 +61,9 @@ export const metricUrl = (params: MetricLinkParams): string => {if (params.dateTo) {searchParams.dateTo = params.dateTo}+ if (params.interval) {+ searchParams.interval = params.interval+ }if (params.groupBy?.length) {searchParams.groupBy = params.groupBy}diff --git a/products/metrics/frontend/metricsSceneLogic.test.ts b/products/metrics/frontend/metricsSceneLogic.test.tsindex 44ac0695c239..0ba4c0f7577b 100644--- a/products/metrics/frontend/metricsSceneLogic.test.ts+++ b/products/metrics/frontend/metricsSceneLogic.test.ts@@ -101,6 +101,7 @@ describe('metricsSceneLogic', () => {aggregation: 'p95',dateFrom: '-24h',dateTo: '2026-08-25T00:00:00.000Z',+ interval: 'minute_5',groupBy: '["service_name","env"]',filterGroup: JSON.stringify(FILTER_GROUP),})@@ -112,6 +113,7 @@ describe('metricsSceneLogic', () => {expect(logic.values.aggregation).toEqual('p95')expect(logic.values.dateFrom).toEqual('-24h')expect(logic.values.dateTo).toEqual('2026-08-25T00:00:00.000Z')+ expect(logic.values.interval).toEqual('minute_5')expect(logic.values.groupByKeys).toEqual(['service_name', 'env'])expect(logic.values.filterGroup).toEqual(FILTER_GROUP)// Applying the params dispatches setters whose own URL sync must not rewrite the@@ -150,6 +152,7 @@ describe('metricsSceneLogic', () => {['activeTab', 'nonsense', 'activeTab', 'overview'],['aggregation', 'not-an-aggregation', 'aggregation', null],['metricType', 'not-a-type', 'selectedMetricType', null],+ ['interval', 'not-an-interval', 'interval', null],])('falls back to the default for an invalid %s param', async (param, urlValue, valueKey, expected) => {await expectLogic(logic, () => {router.actions.push('/metrics', { [param]: urlValue })@@ -289,16 +292,23 @@ describe('metricsSceneLogic', () => {await expectLogic(logic, () => {logic.actions.setMetricName('requests_total')logic.actions.setDateFrom('-7d')+ logic.actions.setInterval('minute_5')}).toFinishAllListeners()- expect(router.values.searchParams).toMatchObject({ metricName: 'requests_total', dateFrom: '-7d' })+ expect(router.values.searchParams).toMatchObject({+ metricName: 'requests_total',+ dateFrom: '-7d',+ interval: 'minute_5',+ })expect(router.values.searchParams).not.toHaveProperty('aggregation')await expectLogic(logic, () => {logic.actions.setDateFrom('-1h')+ logic.actions.setInterval(null)}).toFinishAllListeners()expect(router.values.searchParams).not.toHaveProperty('dateFrom')+ expect(router.values.searchParams).not.toHaveProperty('interval')expect(router.values.searchParams).toMatchObject({ metricName: 'requests_total' })})diff --git a/products/metrics/frontend/metricsSceneLogic.tsx b/products/metrics/frontend/metricsSceneLogic.tsxindex 7c221cdcf5e2..ef4b66c61120 100644--- a/products/metrics/frontend/metricsSceneLogic.tsx+++ b/products/metrics/frontend/metricsSceneLogic.tsx@@ -18,7 +18,7 @@ import { urls } from 'scenes/urls'import { MetricsQueryLanguage, NodeKind } from '~/queries/schema/schema-general'import { UniversalFiltersGroup } from '~/types'-import { OtelMetricTypeEnumApi } from 'products/metrics/frontend/generated/api.schemas'+import { MetricQueryIntervalEnumApi, OtelMetricTypeEnumApi } from 'products/metrics/frontend/generated/api.schemas'import {DEFAULT_DATE_FROM,@@ -67,6 +67,9 @@ const LEGACY_VIEWER_PARAMS = [// PromQL and SQL queries are written as `language` plus the query text in `query`.const TEXT_LANGUAGES: MetricsQueryLanguage[] = ['promql', 'sql']+const isMetricQueryInterval = (value: unknown): value is MetricQueryIntervalEnumApi =>+ typeof value === 'string' && (Object.values(MetricQueryIntervalEnumApi) as string[]).includes(value)+// A clause's alias must satisfy the backend's identifier rules (formulas reference it).const CLAUSE_NAME_PATTERN = /^[a-z][a-z0-9_]{0,63}$/@@ -152,6 +155,7 @@ export interface metricsSceneLogicValues {filterGroup: UniversalFiltersGroup // metricsViewerLogicformula: string // metricsViewerLogicgroupByKeys: string[] // metricsViewerLogic+ interval: string | null // metricsViewerLogiclanguage: MetricsQueryLanguage // metricsViewerLogicmetricName: string // metricsViewerLogicnamedClauses: MetricsViewerClause[] // metricsViewerLogic@@ -202,6 +206,9 @@ export interface metricsSceneLogicActions {setGroupByKeys: (groupByKeys: string[]) => {groupByKeys: string[]} // metricsViewerLogic+ setInterval: (interval: string | null) => {+ interval: string | null+ } // metricsViewerLogicsetMetricName: (metricName: string) => {metricName: string} // metricsViewerLogic@@ -242,6 +249,7 @@ export const metricsSceneLogic = kea<metricsSceneLogicType>(['rangeFunction','dateFrom','dateTo',+ 'interval','groupByKeys','filterGroup','viewerClauses',@@ -260,6 +268,7 @@ export const metricsSceneLogic = kea<metricsSceneLogicType>(['setRangeFunction','setDateFrom','setDateTo',+ 'setInterval','setGroupByKeys','setFilterGroup','setClauses',@@ -403,6 +412,10 @@ export const metricsSceneLogic = kea<metricsSceneLogicType>([if (dateTo !== values.dateTo) {actions.setDateTo(dateTo)}+ const interval = isMetricQueryInterval(params.interval) ? params.interval : null+ if (interval !== values.interval) {+ actions.setInterval(interval)+ }} finally {actions.setRestoringFromUrl(false)}@@ -468,6 +481,7 @@ export const metricsSceneLogic = kea<metricsSceneLogicType>([}updateSearchParams(params, 'dateFrom', values.dateFrom, DEFAULT_DATE_FROM)updateSearchParams(params, 'dateTo', values.dateTo, null)+ updateSearchParams(params, 'interval', values.interval, null)return params})queueMicrotask(() => {@@ -483,6 +497,7 @@ export const metricsSceneLogic = kea<metricsSceneLogicType>([setRangeFunction: () => syncUrl(),setDateFrom: () => syncUrl(),setDateTo: () => syncUrl(),+ setInterval: () => syncUrl(),setGroupByKeys: () => syncUrl(),setFilterGroup: () => syncUrl(),setClauses: () => syncUrl(),