:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
feat(workflows): add tags to the broadcast wizard and workflow menu bar (#121545)
ruby childs0b3df76cc827
diff --git a/products/workflows/frontend/Broadcasts/broadcastWizardLogic.ts b/products/workflows/frontend/Broadcasts/broadcastWizardLogic.tsindex c557f473f6c0..3c202167222e 100644--- a/products/workflows/frontend/Broadcasts/broadcastWizardLogic.ts+++ b/products/workflows/frontend/Broadcasts/broadcastWizardLogic.ts@@ -313,6 +313,7 @@ export interface broadcastWizardLogicValues {stepValidationErrors: Record<BroadcastWizardStep, string[]>summaryStatus: BroadcastStatussummaryTab: BroadcastSummaryTab+ tags: string[]}// Generated by kea-typegen. Update if you're an agent, ignore if you're human.@@ -563,6 +564,9 @@ export interface broadcastWizardLogicActions {setSummaryTab: (tab: BroadcastSummaryTab) => {tab: BroadcastSummaryTab}+ setTags: (tags: string[]) => {+ tags: string[]+ }showSavedDraftUrl: () => {value: true}@@ -716,6 +720,7 @@ export const broadcastWizardLogic = kea<broadcastWizardLogicType>([collapseRun: (runId: string) => ({ runId }),setExpandedRunOverride: (runIds: string[]) => ({ runIds }),setSummaryTab: (tab: BroadcastSummaryTab) => ({ tab }),+ setTags: (tags: string[]) => ({ tags }),launchBroadcast: true,launchBroadcastFinished: true,moveToDraft: true,@@ -930,6 +935,15 @@ export const broadcastWizardLogic = kea<broadcastWizardLogicType>([: state,},],+ tags: [+ [] as string[],+ {+ setTags: (_, { tags }) => tags,+ hydrateFromBroadcast: (state, { broadcast }) => (broadcast.tags ? [...broadcast.tags] : state),+ applyExternalEdit: (state, { broadcast, base }) =>+ changedElsewhere(broadcast, base, (b) => b.tags) ? [...(broadcast.tags ?? [])] : state,+ },+ ],emailRateLimit: [null as HogFlowEmailSendingRateLimitApi | null,{@@ -2408,6 +2422,9 @@ export function buildBroadcastPayload(values: {email: BroadcastEmailValueemailRateLimit: HogFlowEmailSendingRateLimitApi | nullemailSettings?: BroadcastEmailSettings+ // Left out of the payload when undefined: the API clears tags on an empty list, so only a+ // caller that carries the wizard's tags state may write them.+ tags?: string[]broadcast?: HogFlowApi | null}): Record<string, any> {const existing = values.broadcast@@ -2417,6 +2434,7 @@ export function buildBroadcastPayload(values: {// origin_product and the exit condition stay as they were.return {name: values.name,+ ...(values.tags !== undefined ? { tags: values.tags } : {}),conversion: values.goalEnabled ? values.conversion : null,email_sending_rate_limit: values.emailRateLimit,actions: (existing.actions as Record<string, any>[]).map((action) =>@@ -2449,6 +2467,7 @@ export function buildBroadcastPayload(values: {origin_product: 'broadcasts',status: 'draft',name: values.name,+ ...(values.tags !== undefined ? { tags: values.tags } : {}),exit_condition: 'exit_only_at_end',conversion: values.goalEnabled ? values.conversion : null,email_sending_rate_limit: values.emailRateLimit,diff --git a/products/workflows/frontend/Broadcasts/steps/BroadcastGoalStep.tsx b/products/workflows/frontend/Broadcasts/steps/BroadcastGoalStep.tsxindex 209a9703794e..d88a1525ba14 100644--- a/products/workflows/frontend/Broadcasts/steps/BroadcastGoalStep.tsx+++ b/products/workflows/frontend/Broadcasts/steps/BroadcastGoalStep.tsx@@ -1,15 +1,20 @@import { useActions, useValues } from 'kea'+import { ObjectTags } from 'lib/components/ObjectTags/ObjectTags'import { LemonRadio } from 'lib/lemon-ui/LemonRadio'+import { tagsModel } from '~/models/tagsModel'+import type { HogFlowConversionApi } from 'products/workflows/frontend/generated/api.schemas'import { ConversionGoalEditor } from '../../Workflows/hogflows/steps/components/ConversionGoalEditor'import { DEFAULT_BROADCAST_CONVERSION, broadcastWizardLogic } from '../broadcastWizardLogic'export function BroadcastGoalStep(): JSX.Element {- const { goalEnabled, conversion, stepValidationErrors } = useValues(broadcastWizardLogic)- const { setGoalEnabled, setConversion } = useActions(broadcastWizardLogic)+ const { goalEnabled, conversion, stepValidationErrors, tags } = useValues(broadcastWizardLogic)+ const { setGoalEnabled, setConversion, setTags } = useActions(broadcastWizardLogic)+ const { tags: allTags } = useValues(tagsModel)+ const { loadTagsIfNeeded } = useActions(tagsModel)return (<div className="flex flex-col gap-4">@@ -52,6 +57,24 @@ export function BroadcastGoalStep(): JSX.Element {))}</div>)}++ <div className="flex flex-col gap-2">+ <div>+ <h2 className="m-0 text-xl font-semibold">Tags</h2>+ <p className="m-0 text-secondary">+ Group related broadcasts, like repeated sends in one campaign. You can filter the broadcasts+ list by tag.+ </p>+ </div>+ <ObjectTags+ tags={tags}+ onChange={setTags}+ onEdit={loadTagsIfNeeded}+ saving={false}+ tagsAvailable={allTags.filter((tag: string) => !tags.includes(tag))}+ data-attr="broadcast-wizard-tags"+ />+ </div></div>)}diff --git a/products/workflows/frontend/Workflows/WorkflowSceneHeader.tsx b/products/workflows/frontend/Workflows/WorkflowSceneHeader.tsxindex 8e897913c21f..4f4e6f05abe7 100644--- a/products/workflows/frontend/Workflows/WorkflowSceneHeader.tsx+++ b/products/workflows/frontend/Workflows/WorkflowSceneHeader.tsx@@ -5,6 +5,7 @@ import { IconArchive, IconClock, IconCopy, IconScreen, IconTrash, IconUpload } fimport { AccessControlAction } from 'lib/components/AccessControlAction'import { SceneMenuBarFileItems } from 'lib/components/Scenes/SceneMenuBarFileItems'+import { SceneTagsCombobox } from 'lib/components/Scenes/SceneTagsCombobox'import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { urls } from 'scenes/urls'@@ -13,6 +14,7 @@ import {SceneMenuBar,SceneMenuBarItem,SceneMenuBarMenu,+ SceneMenuBarPopover,SceneMenuBarSeparator,} from '~/layout/scenes/components/SceneMenuBar'import { SceneTitleSection } from '~/layout/scenes/components/SceneTitleSection'@@ -22,6 +24,7 @@ import { workflowSuggestionsAvailabilityLogic } from './suggestions/workflowSuggimport { WorkflowSuggestionsMenuItem } from './suggestions/WorkflowSuggestionsMenuItem'import { SaveAsTemplateModal } from './templates/SaveAsTemplateModal'import { workflowTemplateLogic } from './templates/workflowTemplateLogic'+import { canEditWorkflow } from './workflowAccess'import { WorkflowActions } from './WorkflowActions'import { workflowBackTo } from './workflowBackTo'import { workflowLogic } from './workflowLogic'@@ -40,6 +43,7 @@ export const WorkflowSceneHeader = (props: WorkflowSceneLogicProps = {}): JSX.Elconst { featureFlags } = useValues(featureFlagLogic)const sceneMenuBarEnabled = !!featureFlags[FEATURE_FLAGS.SCENE_MENU_BAR]const { suggestionsAvailable } = useValues(workflowSuggestionsAvailabilityLogic)+ const canEdit = canEditWorkflow(workflow, workflowUserAccessLevel)return (<>@@ -148,6 +152,18 @@ export const WorkflowSceneHeader = (props: WorkflowSceneLogicProps = {}): JSX.El</>)}</SceneMenuBarMenu>+ <SceneMenuBarPopover+ label="Metadata"+ dataAttr="workflow-menubar-metadata"+ contentClassName="w-80 p-2 flex flex-col gap-2"+ >+ <SceneTagsCombobox+ onSave={(tags) => setWorkflowValue('tags', tags)}+ canEdit={canEdit}+ tags={workflow?.tags ?? []}+ dataAttrKey="workflow"+ />+ </SceneMenuBarPopover></SceneMenuBar>)}<SceneTitleSectiondiff --git a/products/workflows/frontend/Workflows/WorkflowScenePanel.tsx b/products/workflows/frontend/Workflows/WorkflowScenePanel.tsxindex c30020637fb3..1875883a7ddf 100644--- a/products/workflows/frontend/Workflows/WorkflowScenePanel.tsx+++ b/products/workflows/frontend/Workflows/WorkflowScenePanel.tsx@@ -6,7 +6,6 @@ import { IconArchive, IconCopy, IconScreen } from '@posthog/icons'import { AccessControlAction } from 'lib/components/AccessControlAction'import { SceneTags } from 'lib/components/Scenes/SceneTags'import { ButtonPrimitive } from 'lib/ui/Button/ButtonPrimitives'-import { accessLevelSatisfied } from 'lib/utils/accessControlUtils'import {ScenePanel,@@ -19,6 +18,7 @@ import { AccessControlLevel, AccessControlResourceType } from '~/types'import { workflowSuggestionsAvailabilityLogic } from './suggestions/workflowSuggestionsAvailabilityLogic'import { WorkflowSuggestionsPanelToggle } from './suggestions/WorkflowSuggestionsPanelToggle'import { workflowTemplateLogic } from './templates/workflowTemplateLogic'+import { canEditWorkflow } from './workflowAccess'import { workflowLogic } from './workflowLogic'import { WorkflowSceneLogicProps } from './workflowSceneLogic'@@ -29,14 +29,7 @@ export function WorkflowScenePanel(props: WorkflowSceneLogicProps): JSX.Elementconst editTemplateId = searchParams.editTemplateId as string | undefinedconst { showSaveAsTemplateModal } = useActions(workflowTemplateLogic({ ...props, editTemplateId }))const { suggestionsAvailable } = useValues(workflowSuggestionsAvailabilityLogic)- const canEdit =- workflow.status !== 'archived' &&- (!workflowUserAccessLevel ||- accessLevelSatisfied(- AccessControlResourceType.Workflow,- workflowUserAccessLevel,- AccessControlLevel.Editor- ))+ const canEdit = canEditWorkflow(workflow, workflowUserAccessLevel)return (<ScenePanel>diff --git a/products/workflows/frontend/Workflows/workflowAccess.ts b/products/workflows/frontend/Workflows/workflowAccess.tsnew file mode 100644index 000000000000..b737c97d5577--- /dev/null+++ b/products/workflows/frontend/Workflows/workflowAccess.ts@@ -0,0 +1,14 @@+import { accessLevelSatisfied } from 'lib/utils/accessControlUtils'++import { AccessControlLevel, AccessControlResourceType } from '~/types'++import { HogFlow } from './hogflows/types'++// A workflow with no access level came from a list the backend did not annotate, so it stays editable.+export function canEditWorkflow(workflow: HogFlow | null, userAccessLevel: AccessControlLevel | null): boolean {+ return (+ workflow?.status !== 'archived' &&+ (!userAccessLevel ||+ accessLevelSatisfied(AccessControlResourceType.Workflow, userAccessLevel, AccessControlLevel.Editor))+ )+}