:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(insights): move query-node helpers into the query layer (#126863)
Paul D'Ambra0f8f5161591a
diff --git a/frontend/bin/layer-baseline.txt b/frontend/bin/layer-baseline.txtindex a287d532e029..d9f16b6015ab 100644--- a/frontend/bin/layer-baseline.txt+++ b/frontend/bin/layer-baseline.txt@@ -500,13 +500,11 @@ frontend/src/queries/nodes/HogQLQuery/hogQLQueryEditorLogic.tsx -> frontend/src/frontend/src/queries/nodes/HogQLQuery/hogQLQueryEditorLogic.tsx -> frontend/src/scenes/data-warehouse/saved_queries/savedQueryNameValidation.tsfrontend/src/queries/nodes/HogQLQuery/hogQLQueryEditorLogic.tsx -> frontend/src/scenes/data-warehouse/settings/dataWarehouseSettingsSceneLogic.tsfrontend/src/queries/nodes/HogQLX/render.tsx -> products/mcp_analytics/frontend/components/BrandMarkLabel.tsx-frontend/src/queries/nodes/InsightQuery/defaults.ts -> products/product_analytics/frontend/insights/journeys/stepSourcePresets.tsfrontend/src/queries/nodes/InsightViz/ComputationTimeWithRefresh.tsx -> frontend/src/scenes/insights/insightDataLogic.tsxfrontend/src/queries/nodes/InsightViz/ComputationTimeWithRefresh.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/queries/nodes/InsightViz/FlagCallsRetentionNotice.tsx -> frontend/src/scenes/feature-flags/flagEvaluationsTable.tsfrontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx -> frontend/src/scenes/insights/insightVizDataLogic.ts-frontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx -> products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.tsfrontend/src/queries/nodes/InsightViz/InsightViz.tsx -> frontend/src/scenes/insights/insightDataLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightViz.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/queries/nodes/InsightViz/InsightViz.tsx -> frontend/src/scenes/insights/insightVizDataLogic.ts@@ -536,7 +534,6 @@ frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/retention/RetentionContainer.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/shared/InsightAIAnalysis.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable.tsx-frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/shared/insightImageCapture.tsfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotLegend.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable.tsxfrontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx -> products/product_analytics/frontend/insights/trends/Trends.tsxdiff --git a/frontend/src/queries/nodes/InsightQuery/defaults.ts b/frontend/src/queries/nodes/InsightQuery/defaults.tsindex 02955cf941fc..9b826f1775f7 100644--- a/frontend/src/queries/nodes/InsightQuery/defaults.ts+++ b/frontend/src/queries/nodes/InsightQuery/defaults.ts@@ -1,5 +1,6 @@import { getDefaultEventLabel, getDefaultEventName } from 'lib/utils/getAppContext'+import { STEP_SOURCE_PRESETS } from '~/queries/nodes/InsightQuery/stepSourcePresets'import {FunnelsQuery,InsightQueryNode,@@ -14,8 +15,6 @@ import {} from '~/queries/schema/schema-general'import { BaseMathType, ChartDisplayType, FunnelVizType, InsightType, PathType, RetentionPeriod } from '~/types'-import { STEP_SOURCE_PRESETS } from 'products/product_analytics/frontend/insights/journeys/stepSourcePresets'-function getTrendsQueryDefault(): TrendsQuery {const defaultEvent = getDefaultEventName()const defaultLabel = getDefaultEventLabel()diff --git a/products/product_analytics/frontend/insights/journeys/stepSourcePresets.ts b/frontend/src/queries/nodes/InsightQuery/stepSourcePresets.tssimilarity index 100%rename from products/product_analytics/frontend/insights/journeys/stepSourcePresets.tsrename to frontend/src/queries/nodes/InsightQuery/stepSourcePresets.tsdiff --git a/frontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx b/frontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsxindex a12a1ad66904..44f1433706c8 100644--- a/frontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx+++ b/frontend/src/queries/nodes/InsightViz/InsightResultMetadata.tsx@@ -7,7 +7,7 @@ import {daysOfWeekLabel,getExcludedDaysOfWeek,querySupportsDaysOfWeek,-} from 'products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils'+} from '~/queries/nodes/InsightViz/daysOfWeekFilterUtils'import { ComputationTimeWithRefresh } from './ComputationTimeWithRefresh'diff --git a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsxindex 863cacd70212..de9b95c25553 100644--- a/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx+++ b/frontend/src/queries/nodes/InsightViz/InsightVizDisplay.tsx@@ -32,6 +32,7 @@ import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { isBoxPlotMissingProperty } from 'scenes/insights/utils/queryUtils'import { SceneSection } from '~/layout/scenes/components/SceneSection'+import { INSIGHT_GRAPH_DATA_ATTR } from '~/queries/nodes/InsightViz/insightImageCapture'import { InsightVizNode, TrendsQuery } from '~/queries/schema/schema-general'import { QueryContext } from '~/queries/types'import { shouldQueryBeAsync } from '~/queries/utils'@@ -59,7 +60,6 @@ import { Paths } from 'products/product_analytics/frontend/insights/paths/Paths'import { PathCanvasLabel } from 'products/product_analytics/frontend/insights/paths/PathsLabel'import { RetentionContainer } from 'products/product_analytics/frontend/insights/retention/RetentionContainer'import { InsightAIAnalysis } from 'products/product_analytics/frontend/insights/shared/InsightAIAnalysis'-import { INSIGHT_GRAPH_DATA_ATTR } from 'products/product_analytics/frontend/insights/shared/insightImageCapture'import { InsightsTable } from 'products/product_analytics/frontend/insights/shared/InsightsTable/InsightsTable'import { BoxPlotLegend } from 'products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotLegend'import { BoxPlotResultsTable } from 'products/product_analytics/frontend/insights/trends/BoxPlot/BoxPlotResultsTable'diff --git a/products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.test.ts b/frontend/src/queries/nodes/InsightViz/daysOfWeekFilterUtils.test.tssimilarity index 98%rename from products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.test.tsrename to frontend/src/queries/nodes/InsightViz/daysOfWeekFilterUtils.test.tsindex cce8441c786b..9bbcd49a185e 100644--- a/products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.test.ts+++ b/frontend/src/queries/nodes/InsightViz/daysOfWeekFilterUtils.test.ts@@ -1,13 +1,12 @@-import { NodeKind, type DateRange } from '~/queries/schema/schema-general'-import { FunnelVizType } from '~/types'-import {computeDaysOfWeekUpdate,getExcludedDaysOfWeek,invertDaysOfWeek,querySupportsDaysOfWeek,type IsoDayOfWeek,-} from './daysOfWeekFilterUtils'+} from '~/queries/nodes/InsightViz/daysOfWeekFilterUtils'+import { NodeKind, type DateRange } from '~/queries/schema/schema-general'+import { FunnelVizType } from '~/types'describe('daysOfWeekFilterUtils', () => {it.each([diff --git a/products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.ts b/frontend/src/queries/nodes/InsightViz/daysOfWeekFilterUtils.tssimilarity index 100%rename from products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils.tsrename to frontend/src/queries/nodes/InsightViz/daysOfWeekFilterUtils.tsdiff --git a/products/product_analytics/frontend/insights/shared/insightImageCapture.ts b/frontend/src/queries/nodes/InsightViz/insightImageCapture.tssimilarity index 100%rename from products/product_analytics/frontend/insights/shared/insightImageCapture.tsrename to frontend/src/queries/nodes/InsightViz/insightImageCapture.tsdiff --git a/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsx b/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsxindex e5e97f5ca76b..d699fca991eb 100644--- a/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsx+++ b/products/product_analytics/frontend/insights/editor/filters/InsightDateFilter.tsx@@ -17,7 +17,7 @@ import {getExcludedDaysOfWeek,parseIsoDaysOfWeek,querySupportsDaysOfWeek,-} from './daysOfWeekFilterUtils'+} from '~/queries/nodes/InsightViz/daysOfWeekFilterUtils'type InsightDateFilterProps = {disabled: booleandiff --git a/products/product_analytics/frontend/insights/insightScene/InsightModals.tsx b/products/product_analytics/frontend/insights/insightScene/InsightModals.tsxindex 8b26aee9d512..6387f0d3ed95 100644--- a/products/product_analytics/frontend/insights/insightScene/InsightModals.tsx+++ b/products/product_analytics/frontend/insights/insightScene/InsightModals.tsx@@ -13,6 +13,7 @@ import { insightSceneLogic } from 'scenes/insights/insightSceneLogic'import { urls } from 'scenes/urls'import { sceneLayoutLogic } from '~/layout/scenes/sceneLayoutLogic'+import { INSIGHT_SCREENSHOT_KEY } from '~/queries/nodes/InsightViz/insightImageCapture'import { EndpointQueryNode, HogQLQuery } from '~/queries/schema/schema-general'import { InsightLogicProps, InsightShortId, ItemMode } from '~/types'@@ -23,7 +24,6 @@ import { MetricFromInsightModal } from 'products/data_catalog/frontend/componentimport { metricsLogic } from 'products/data_catalog/frontend/metricsLogic'import { EndpointFromInsightModal } from 'products/endpoints/frontend/EndpointFromInsightModal'import { endpointLogic } from 'products/endpoints/frontend/endpointLogic'-import { INSIGHT_SCREENSHOT_KEY } from 'products/product_analytics/frontend/insights/shared/insightImageCapture'import { SubscriptionsModal } from 'products/subscriptions/frontend/components/Subscriptions/SubscriptionsModal'import { insightModalsLogic } from './insightModalsLogic'diff --git a/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightPanelActions.tsx b/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightPanelActions.tsxindex 415b6f6579c9..461e4486d0d1 100644--- a/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightPanelActions.tsx+++ b/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightPanelActions.tsx@@ -24,6 +24,7 @@ import { urls } from 'scenes/urls'import { ScenePanelActionsSection } from '~/layout/scenes/SceneLayout'import { sceneLayoutLogic } from '~/layout/scenes/sceneLayoutLogic'+import { INSIGHT_GRAPH_SELECTOR, INSIGHT_SCREENSHOT_KEY } from '~/queries/nodes/InsightViz/insightImageCapture'import {isDataTableNode,isDataVisualizationNode,@@ -35,10 +36,6 @@ import { AccessControlLevel, AccessControlResourceType, ExporterFormat, InsightLimport { metricsLogic } from 'products/data_catalog/frontend/metricsLogic'import { endpointLogic } from 'products/endpoints/frontend/endpointLogic'-import {- INSIGHT_GRAPH_SELECTOR,- INSIGHT_SCREENSHOT_KEY,-} from 'products/product_analytics/frontend/insights/shared/insightImageCapture'import { insightModalsLogic } from '../insightModalsLogic'import { openSaveAsCohortDialog } from './insightSidePanelDialogs'diff --git a/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightSceneMenuBar.tsx b/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightSceneMenuBar.tsxindex 0f59cd77a812..d916fd14c9e1 100644--- a/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightSceneMenuBar.tsx+++ b/products/product_analytics/frontend/insights/insightScene/sidePanel/InsightSceneMenuBar.tsx@@ -51,6 +51,7 @@ import {SceneMenuBarSubMenu,} from '~/layout/scenes/components/SceneMenuBar'import { tagsModel } from '~/models/tagsModel'+import { INSIGHT_GRAPH_SELECTOR, INSIGHT_SCREENSHOT_KEY } from '~/queries/nodes/InsightViz/insightImageCapture'import { NodeKind } from '~/queries/schema/schema-general'import {isDataTableNode,@@ -72,10 +73,6 @@ import {import { metricsLogic } from 'products/data_catalog/frontend/metricsLogic'import { endpointLogic } from 'products/endpoints/frontend/endpointLogic'-import {- INSIGHT_GRAPH_SELECTOR,- INSIGHT_SCREENSHOT_KEY,-} from 'products/product_analytics/frontend/insights/shared/insightImageCapture'import { urlForSubscriptions } from 'products/subscriptions/frontend/components/Subscriptions/utils'import { insightModalsLogic } from '../insightModalsLogic'diff --git a/products/product_analytics/frontend/insights/journeys/JourneysStepSourcePicker.tsx b/products/product_analytics/frontend/insights/journeys/JourneysStepSourcePicker.tsxindex 42711cbd7113..a696ac488f2c 100644--- a/products/product_analytics/frontend/insights/journeys/JourneysStepSourcePicker.tsx+++ b/products/product_analytics/frontend/insights/journeys/JourneysStepSourcePicker.tsx@@ -10,13 +10,17 @@ import { TaxonomicStringPopover } from 'lib/components/TaxonomicPopover/Taxonomiimport { LemonSegmentedButton } from 'lib/lemon-ui/LemonSegmentedButton'import { Tooltip } from 'lib/lemon-ui/Tooltip'+import {+ STEP_SOURCE_PRESETS,+ StepSourcePreset,+ presetForStepSources,+} from '~/queries/nodes/InsightQuery/stepSourcePresets'import { EditorFilterProps } from '~/types'import { EventName } from 'products/actions/frontend/components/EventName'import { MAX_STEP_SOURCES } from './editorBounds'import { journeysDataLogic } from './journeysDataLogic'-import { STEP_SOURCE_PRESETS, StepSourcePreset, presetForStepSources } from './stepSourcePresets'const PRESET_OPTIONS = Object.values(STEP_SOURCE_PRESETS).map(({ key, label }) => ({value: key,diff --git a/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts b/products/product_analytics/frontend/insights/journeys/journeysDataLogic.tsindex d251f9a1fbbc..82e6ecffdb0b 100644--- a/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts+++ b/products/product_analytics/frontend/insights/journeys/journeysDataLogic.ts@@ -10,6 +10,7 @@ import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'import { openPersonsModal } from 'scenes/trends/persons-modal/PersonsModal'import { urls } from 'scenes/urls'+import { DEFAULT_STEP_SOURCES } from '~/queries/nodes/InsightQuery/stepSourcePresets'import {InsightFilter,InsightVizNode,@@ -59,7 +60,6 @@ import {journeysNodeModalTitle,journeysOtherModalTitle,} from './journeysModalTitles'-import { DEFAULT_STEP_SOURCES } from './stepSourcePresets'const DEFAULT_JOURNEYS_LOGIC_KEY = 'default_journeys_key'diff --git a/products/product_analytics/frontend/insights/journeys/journeysSummary.ts b/products/product_analytics/frontend/insights/journeys/journeysSummary.tsindex 0e138ab316d4..3c63331385f8 100644--- a/products/product_analytics/frontend/insights/journeys/journeysSummary.ts+++ b/products/product_analytics/frontend/insights/journeys/journeysSummary.ts@@ -1,10 +1,10 @@import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'+import { presetForStepSources } from '~/queries/nodes/InsightQuery/stepSourcePresets'import { PathsV2AnchorType, PathsV2Filter } from '~/queries/schema/schema-general'import { getCoreFilterDefinition } from '~/taxonomy/helpers'import { journeyItemLabel } from './journeyGridModel'-import { presetForStepSources } from './stepSourcePresets'function eventLabel(event: string): string {return getCoreFilterDefinition(event, TaxonomicFilterGroupType.Events)?.label ?? eventdiff --git a/tools/playwright_area_map.json b/tools/playwright_area_map.jsonindex 45207b46d67f..f984e0ec304a 100644--- a/tools/playwright_area_map.json+++ b/tools/playwright_area_map.json@@ -161,11 +161,6 @@"playwright/e2e/insight-sharing-password.spec.ts","playwright/e2e/shared-insight-unauthenticated.spec.ts"],- "products/product_analytics/frontend/insights/editor/filters/daysOfWeekFilterUtils*": [- "playwright/e2e/product-analytics/",- "playwright/e2e/insight-sharing-password.spec.ts",- "playwright/e2e/shared-insight-unauthenticated.spec.ts"- ],"products/product_analytics/frontend/**": ["playwright/e2e/product-analytics/"],"products/dashboards/frontend/**": ["playwright/e2e/product-analytics/dashboards.spec.ts",