Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(replay): move the watch list header and bulk bar to quill (#127778)

Hayne Ryu0ff4dadd6b29
diff --git a/frontend/src/scenes/session-recordings/playlist/OngoingRecordingsGroup.tsx b/frontend/src/scenes/session-recordings/playlist/OngoingRecordingsGroup.tsx
index cc3a128e762f..aea22fc961dd 100644
--- a/frontend/src/scenes/session-recordings/playlist/OngoingRecordingsGroup.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/OngoingRecordingsGroup.tsx
@@ -1,7 +1,7 @@
import { ReactNode, useState } from 'react'
-import { IconChevronDown, IconChevronRight, IconLive } from '@posthog/icons'
-import { LemonBadge, LemonButton } from '@posthog/lemon-ui'
+import { IconLive } from '@posthog/icons'
+import { Badge, Collapsible, CollapsibleContent, CollapsibleTrigger } from '@posthog/quill'
export function OngoingRecordingsGroup({
count,
@@ -29,22 +29,21 @@ export function OngoingRecordingsGroup({
const expanded = choice ?? (holdsActive || defaultOpen)
return (
- <div className="border-b">
- <LemonButton
- fullWidth
- size="xsmall"
- className="rounded-none bg-surface-secondary"
- icon={<IconLive className="text-primary-3000" />}
- sideIcon={expanded ? <IconChevronDown /> : <IconChevronRight />}
- onClick={() => setChoice(!expanded)}
- data-attr="list-ongoing-toggle"
- >
- <span className="flex items-center gap-1 text-[11px] uppercase tracking-wide text-secondary font-semibold">
+ <Collapsible
+ data-quill
+ open={expanded}
+ onOpenChange={(open) => setChoice(open)}
+ className="border-b border-border"
+ >
+ <CollapsibleTrigger className="w-full rounded-none bg-muted" data-attr="list-ongoing-toggle">
+ <IconLive className="text-primary-3000" />
+ <span className="flex items-center gap-1 text-[11px] uppercase tracking-wide text-muted-foreground font-semibold">
Still recording
- <LemonBadge.Number count={count} status="muted" size="small" />
+ <Badge>{count}</Badge>
</span>
- </LemonButton>
- {expanded && children}
- </div>
+ <span className="grow" />
+ </CollapsibleTrigger>
+ <CollapsibleContent>{children}</CollapsibleContent>
+ </Collapsible>
)
}
diff --git a/frontend/src/scenes/session-recordings/playlist/Playlist.tsx b/frontend/src/scenes/session-recordings/playlist/Playlist.tsx
index e09e05debb58..70dabad3a57f 100644
--- a/frontend/src/scenes/session-recordings/playlist/Playlist.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/Playlist.tsx
@@ -386,7 +386,7 @@ export function Playlist({
<ReplayListHeader
filters={filters}
setFilters={setFilters}
- collapseButton={collapseButton}
+ onCollapse={() => setPlaylistCollapsed(true)}
type={type}
shortId={type === 'collection' ? logicKey : undefined}
/>
diff --git a/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx b/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx
new file mode 100644
index 000000000000..64e8b68fbdab
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/playlist/QuillMenuItems.tsx
@@ -0,0 +1,199 @@
+import { Fragment, ReactNode } from 'react'
+
+import {
+ DropdownMenuGroup,
+ DropdownMenuItem,
+ DropdownMenuLabel,
+ DropdownMenuRadioGroup,
+ DropdownMenuRadioItem,
+ DropdownMenuSeparator,
+ DropdownMenuSub,
+ DropdownMenuSubContent,
+ DropdownMenuSubTrigger,
+} from '@posthog/quill'
+
+import {
+ LemonMenuItem,
+ LemonMenuItemCustom,
+ LemonMenuItemNode,
+ LemonMenuItems,
+ LemonMenuSection,
+} from 'lib/lemon-ui/LemonMenu/LemonMenu'
+import { LinkPrimitive } from 'lib/lemon-ui/Link'
+
+type PresentItem = Exclude<LemonMenuItems[number], false | null>
+type MenuEntry = Exclude<LemonMenuItem, LemonMenuItemCustom>
+type MenuLeaf = Exclude<MenuEntry, LemonMenuItemNode>
+
+function tooltipText(tooltip: MenuEntry['tooltip']): ReactNode {
+ return typeof tooltip === 'function' ? tooltip() : tooltip
+}
+
+function isSection(item: PresentItem): item is LemonMenuSection {
+ return !('label' in item)
+}
+
+function isCustom(item: LemonMenuItem): item is LemonMenuItemCustom {
+ return typeof item.label === 'function'
+}
+
+function isNode(item: MenuEntry): item is LemonMenuItemNode {
+ return Array.isArray(item.items)
+}
+
+function itemKey(item: LemonMenuItem, index: number): string {
+ if (isCustom(item)) {
+ return String(item.key ?? index)
+ }
+ return String(item.key ?? item['data-attr'] ?? (typeof item.label === 'string' ? item.label : index))
+}
+
+/** Renders Lemon menu item definitions as quill dropdown menu content, so the Lemon and quill menus share one list. */
+export function QuillMenuItems({
+ items,
+ closeOnClick = true,
+}: {
+ items: LemonMenuItems
+ closeOnClick?: boolean
+}): JSX.Element {
+ const sections: LemonMenuSection[] = []
+ for (const item of items) {
+ if (!item) {
+ continue
+ }
+ if (isSection(item)) {
+ sections.push(item)
+ } else if (
+ sections.length &&
+ !sections[sections.length - 1].title &&
+ !('key' in sections[sections.length - 1])
+ ) {
+ sections[sections.length - 1].items.push(item)
+ } else {
+ sections.push({ items: [item] })
+ }
+ }
+
+ return (
+ <>
+ {sections.map((section, index) => (
+ <Fragment key={section.key ?? index}>
+ {index > 0 && <DropdownMenuSeparator />}
+ <DropdownMenuGroup>
+ {section.title && <DropdownMenuLabel>{section.title}</DropdownMenuLabel>}
+ <SectionItems
+ items={section.items.filter((item): item is LemonMenuItem => !!item)}
+ closeOnClick={closeOnClick}
+ />
+ {section.footer}
+ </DropdownMenuGroup>
+ </Fragment>
+ ))}
+ </>
+ )
+}
+
+function SectionItems({ items, closeOnClick }: { items: LemonMenuItem[]; closeOnClick: boolean }): JSX.Element {
+ const exclusive = items.some((item) => 'active' in item && item.active !== undefined)
+ if (!exclusive) {
+ return (
+ <>
+ {items.map((item, index) => (
+ <Entry key={itemKey(item, index)} item={item} closeOnClick={closeOnClick} />
+ ))}
+ </>
+ )
+ }
+ const activeIndex = items.findIndex((item) => 'active' in item && item.active)
+ return (
+ <DropdownMenuRadioGroup value={activeIndex >= 0 ? itemKey(items[activeIndex], activeIndex) : ''}>
+ {items.map((item, index) => (
+ <Entry
+ key={itemKey(item, index)}
+ item={item}
+ closeOnClick={closeOnClick}
+ radioValue={itemKey(item, index)}
+ />
+ ))}
+ </DropdownMenuRadioGroup>
+ )
+}
+
+function Entry({
+ item,
+ closeOnClick,
+ radioValue,
+}: {
+ item: LemonMenuItem
+ closeOnClick: boolean
+ radioValue?: string
+}): JSX.Element {
+ if (isCustom(item)) {
+ return item.label()
+ }
+ const entry: MenuEntry = item
+ const content = (
+ <>
+ {entry.icon}
+ {entry.label}
+ {entry.sideIcon}
+ </>
+ )
+ if (isNode(entry)) {
+ return (
+ <DropdownMenuSub>
+ <DropdownMenuSubTrigger
+ disabled={entry.disabled}
+ disabledReason={entry.disabledReason}
+ tooltip={tooltipText(entry.tooltip)}
+ data-attr={entry['data-attr']}
+ >
+ {content}
+ </DropdownMenuSubTrigger>
+ <DropdownMenuSubContent>
+ <QuillMenuItems items={entry.items} closeOnClick={closeOnClick} />
+ </DropdownMenuSubContent>
+ </DropdownMenuSub>
+ )
+ }
+ const leaf: MenuLeaf = entry
+ if (radioValue !== undefined) {
+ return (
+ <DropdownMenuRadioItem
+ value={radioValue}
+ onClick={leaf.onClick}
+ closeOnClick={closeOnClick}
+ disabled={entry.disabled}
+ disabledReason={entry.disabledReason}
+ tooltip={tooltipText(entry.tooltip)}
+ data-attr={entry['data-attr']}
+ >
+ {content}
+ </DropdownMenuRadioItem>
+ )
+ }
+ return (
+ <DropdownMenuItem
+ onClick={leaf.onClick}
+ closeOnClick={closeOnClick}
+ variant={leaf.status === 'danger' ? 'destructive' : 'default'}
+ disabled={entry.disabled}
+ disabledReason={entry.disabledReason}
+ tooltip={tooltipText(entry.tooltip)}
+ data-attr={entry['data-attr']}
+ {...('to' in entry
+ ? {
+ render: (
+ <LinkPrimitive
+ to={entry.to}
+ target={entry.targetBlank ? '_blank' : undefined}
+ disableClientSideRouting={entry.disableClientSideRouting}
+ />
+ ),
+ }
+ : {})}
+ >
+ {content}
+ </DropdownMenuItem>
+ )
+}
diff --git a/frontend/src/scenes/session-recordings/playlist/ReplayBulkBar.tsx b/frontend/src/scenes/session-recordings/playlist/ReplayBulkBar.tsx
index 2ef73c1247d1..7f83f199d69c 100644
--- a/frontend/src/scenes/session-recordings/playlist/ReplayBulkBar.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/ReplayBulkBar.tsx
@@ -1,15 +1,17 @@
import { useActions, useValues } from 'kea'
-import { IconEllipsis } from '@posthog/icons'
-import { LemonButton } from '@posthog/lemon-ui'
+import { IconEllipsis, IconEye } from '@posthog/icons'
+import { Button, DropdownMenu, DropdownMenuContent, DropdownMenuTrigger } from '@posthog/quill'
-import { LemonMenu, LemonMenuItem, LemonMenuItemLeafCallback } from 'lib/lemon-ui/LemonMenu/LemonMenu'
+import { LemonMenuItem, LemonMenuItemLeafCallback } from 'lib/lemon-ui/LemonMenu/LemonMenu'
import { getAccessControlDisabledReason } from 'lib/utils/accessControlUtils'
import { AccessControlLevel, AccessControlResourceType } from '~/types'
+import { QuillMenuItems } from './QuillMenuItems'
import { sessionRecordingsPlaylistLogic } from './sessionRecordingsPlaylistLogic'
-import { AddToCollectionModal, BulkScanMenuItem, ConfirmDeleteRecordings } from './SessionRecordingsPlaylistSettings'
+import { AddToCollectionModal, ConfirmDeleteRecordings } from './SessionRecordingsPlaylistSettings'
+import { useBulkScanMenuItems } from './useBulkScanMenuItems'
export function ReplayBulkBar({ type, shortId }: { type: 'filters' | 'collection'; shortId?: string }): JSX.Element {
const { selectedRecordingsIds } = useValues(sessionRecordingsPlaylistLogic)
@@ -20,6 +22,7 @@ export function ReplayBulkBar({ type, shortId }: { type: 'filters' | 'collection
handleBulkMarkAsNotViewed,
handleBulkDeleteFromPlaylist,
} = useActions(sessionRecordingsPlaylistLogic)
+ const bulkScan = useBulkScanMenuItems()
const accessControlDisabledReason = getAccessControlDisabledReason(
AccessControlResourceType.SessionRecording,
AccessControlLevel.Editor
@@ -40,7 +43,14 @@ export function ReplayBulkBar({ type, shortId }: { type: 'filters' | 'collection
},
]
: []),
- { key: 'bulk-scan-recordings', label: () => <BulkScanMenuItem />, custom: true },
+ {
+ label: 'Scan these recordings',
+ icon: <IconEye />,
+ items: bulkScan.items,
+ disabledReason: bulkScan.disabledReason,
+ tooltip: bulkScan.tooltip,
+ 'data-attr': 'vision-bulk-scan-recordings',
+ },
]
const primaryItems: LemonMenuItemLeafCallback[] = [
@@ -65,35 +75,38 @@ export function ReplayBulkBar({ type, shortId }: { type: 'filters' | 'collection
<span className="font-semibold px-1 shrink-0">{selectedRecordingsIds.length} selected</span>
<div className="hidden @min-[24rem]/list-header:flex items-center gap-1">
{primaryItems.map((item) => (
- <LemonButton
+ <Button
key={item['data-attr']}
- size="xsmall"
- status={item.status}
+ variant={item.status === 'danger' ? 'destructive-outline' : 'default'}
onClick={item.onClick}
disabledReason={item.disabledReason}
data-attr={item['data-attr']}
>
{item.label}
- </LemonButton>
+ </Button>
))}
- <LemonMenu items={moreItems} placement="bottom-end" buttonSize="xsmall">
- <LemonButton
- size="xsmall"
- icon={<IconEllipsis />}
- aria-label="More actions"
- data-attr="bulk-action-menu"
- />
- </LemonMenu>
+ <DropdownMenu>
+ <DropdownMenuTrigger
+ render={<Button size="icon" aria-label="More actions" data-attr="bulk-action-menu" />}
+ >
+ <IconEllipsis />
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="end">
+ <QuillMenuItems items={moreItems} />
+ </DropdownMenuContent>
+ </DropdownMenu>
</div>
<div className="@min-[24rem]/list-header:hidden">
- <LemonMenu items={[...primaryItems, ...moreItems]} placement="bottom-end" buttonSize="xsmall">
- <LemonButton
- size="xsmall"
- icon={<IconEllipsis />}
- aria-label="Bulk actions"
- data-attr="bulk-action-menu-narrow"
- />
- </LemonMenu>
+ <DropdownMenu>
+ <DropdownMenuTrigger
+ render={<Button size="icon" aria-label="Bulk actions" data-attr="bulk-action-menu-narrow" />}
+ >
+ <IconEllipsis />
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="end">
+ <QuillMenuItems items={[...primaryItems, ...moreItems]} />
+ </DropdownMenuContent>
+ </DropdownMenu>
</div>
<ConfirmDeleteRecordings shortId={shortId} />
<AddToCollectionModal shortId={shortId} />
diff --git a/frontend/src/scenes/session-recordings/playlist/ReplayListHeader.tsx b/frontend/src/scenes/session-recordings/playlist/ReplayListHeader.tsx
index 0eb8c72735d5..adcc77ccbde5 100644
--- a/frontend/src/scenes/session-recordings/playlist/ReplayListHeader.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/ReplayListHeader.tsx
@@ -1,14 +1,22 @@
import { useActions, useValues } from 'kea'
-import { ReactNode, useEffect } from 'react'
+import { useEffect } from 'react'
-import { IconCheckbox, IconChevronDown, IconGear } from '@posthog/icons'
-import { LemonButton, LemonCheckbox, LemonDivider } from '@posthog/lemon-ui'
-
-import { LemonMenu } from 'lib/lemon-ui/LemonMenu/LemonMenu'
-import { Tooltip } from 'lib/lemon-ui/Tooltip'
+import { IconCheckbox, IconChevronDown, IconGear, IconSidebarClose } from '@posthog/icons'
+import {
+ Button,
+ Checkbox,
+ DropdownMenu,
+ DropdownMenuContent,
+ DropdownMenuTrigger,
+ Separator,
+ Tooltip,
+ TooltipContent,
+ TooltipTrigger,
+} from '@posthog/quill'
import { RecordingUniversalFilters } from '~/types'
+import { QuillMenuItems } from './QuillMenuItems'
import { ReplayBulkBar } from './ReplayBulkBar'
import { MAX_SELECTED_RECORDINGS, sessionRecordingsPlaylistLogic } from './sessionRecordingsPlaylistLogic'
import { useWatchSettingsMenuItems, useWatchViewMenuItems, watchSortLabel } from './watchListViewMenuItems'
@@ -16,13 +24,13 @@ import { useWatchSettingsMenuItems, useWatchViewMenuItems, watchSortLabel } from
export function ReplayListHeader({
filters,
setFilters,
- collapseButton,
+ onCollapse,
type = 'filters',
shortId,
}: {
filters: RecordingUniversalFilters
setFilters: (filters: Partial<RecordingUniversalFilters>) => void
- collapseButton: ReactNode
+ onCollapse: () => void
type?: 'filters' | 'collection'
shortId?: string
}): JSX.Element {
@@ -38,7 +46,7 @@ export function ReplayListHeader({
}
const onKeyDown = (event: KeyboardEvent): void => {
// An open dialog or menu owns Escape.
- if (event.key === 'Escape' && !document.querySelector('.LemonModal, .Popover')) {
+ if (event.key === 'Escape' && !document.querySelector('.LemonModal, .Popover, [data-quill-portal]')) {
setSelectMode(false)
}
}
@@ -58,88 +66,91 @@ export function ReplayListHeader({
return (
<div
- className="@container/list-header shrink-0 min-w-0 bg-bg-3000 flex items-center gap-0.5 whitespace-nowrap border-b text-xs"
+ data-quill
+ className="@container/list-header shrink-0 min-w-0 bg-muted text-foreground flex items-center gap-0.5 whitespace-nowrap border-b border-border text-xs"
data-attr="list-header-bar"
>
{selectMode ? (
<>
- <Tooltip
- title={
- selectAllDisabledReason
- ? undefined
- : hasOngoing
- ? 'Select all finished recordings'
- : 'Select all recordings'
- }
- >
- <span className="flex ml-[7px] mr-1">
- <LemonCheckbox
+ <Tooltip disabled={!!selectAllDisabledReason}>
+ <TooltipTrigger render={<span className="flex ml-[7px] mr-1" />}>
+ <Checkbox
disabledReason={selectAllDisabledReason}
checked={allSelected}
- onChange={(checked) =>
+ onCheckedChange={(checked) =>
setSelectedRecordingsIds(checked ? recordings.map((r) => r.id) : [])
}
- stopPropagation
data-attr="select-all-recordings"
aria-label="Select all recordings"
/>
- </span>
+ </TooltipTrigger>
+ <TooltipContent>
+ {hasOngoing ? 'Select all finished recordings' : 'Select all recordings'}
+ </TooltipContent>
</Tooltip>
{selectedRecordingsIds.length > 0 ? (
<ReplayBulkBar type={type} shortId={shortId} />
) : (
- <span className="text-secondary px-1">Select recordings</span>
+ <span className="text-muted-foreground px-1">Select recordings</span>
)}
- <LemonButton
- size="xsmall"
- type="secondary"
+ <Button
+ variant="outline"
className="ml-auto mr-1"
onClick={() => setSelectMode(false)}
tooltip="Done selecting (Esc)"
data-attr="list-select-done"
>
Done
- </LemonButton>
+ </Button>
</>
) : (
<>
- <LemonButton
- size="xsmall"
- icon={<IconCheckbox />}
+ <Button
className="ml-1"
onClick={() => setSelectMode(true)}
disabledReason={recordings.length === 0 ? 'No recordings' : undefined}
data-attr="list-select-mode"
>
+ <IconCheckbox />
Select
- </LemonButton>
+ </Button>
<div className="ml-auto flex items-center gap-0.5">
- <LemonMenu
- items={viewItems}
- placement="bottom-end"
- buttonSize="xsmall"
- closeOnClickInside={false}
- >
- <LemonButton size="xsmall" sideIcon={<IconChevronDown />} data-attr="list-view-menu">
+ <DropdownMenu>
+ <DropdownMenuTrigger render={<Button data-attr="list-view-menu" />}>
{watchSortLabel(listSort.order ?? filters.order)}
- </LemonButton>
- </LemonMenu>
- <LemonMenu
- items={settingsItems}
- placement="bottom-end"
- buttonSize="xsmall"
- closeOnClickInside={false}
+ <IconChevronDown />
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="end">
+ <QuillMenuItems items={viewItems} closeOnClick={false} />
+ </DropdownMenuContent>
+ </DropdownMenu>
+ <DropdownMenu>
+ <DropdownMenuTrigger
+ render={
+ <Button
+ size="icon"
+ tooltip="List settings"
+ aria-label="List settings"
+ data-attr="list-settings-menu"
+ />
+ }
+ >
+ <IconGear />
+ </DropdownMenuTrigger>
+ <DropdownMenuContent align="end">
+ <QuillMenuItems items={settingsItems} closeOnClick={false} />
+ </DropdownMenuContent>
+ </DropdownMenu>
+ <Separator orientation="vertical" className="h-4 mx-0.5" />
+ <Button
+ size="icon"
+ onClick={onCollapse}
+ tooltip="Collapse playlist"
+ aria-label="Collapse playlist"
+ data-attr="collapse-playlist"
>
- <LemonButton
- size="xsmall"
- icon={<IconGear />}
- tooltip="List settings"
- aria-label="List settings"
- data-attr="list-settings-menu"
- />
- </LemonMenu>
- <LemonDivider vertical className="my-1 mx-0.5" />
- {collapseButton}
+ <IconSidebarClose className="rotate-180" />
+ </Button>
</div>
</>
)}
diff --git a/frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx b/frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx
index 07de1a184211..002cee03ea98 100644
--- a/frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx
+++ b/frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx
@@ -1,5 +1,4 @@
import { useActions, useValues } from 'kea'
-import { router } from 'kea-router'
import posthog from 'posthog-js'
import { IconCheck, IconChevronRight, IconEllipsis, IconEye, IconPlus, IconSort, IconTrash } from '@posthog/icons'
@@ -12,14 +11,9 @@ import { LemonMenu, LemonMenuItem, LemonMenuItems } from 'lib/lemon-ui/LemonMenu
import { getAccessControlDisabledReason } from 'lib/utils/accessControlUtils'
import { matchesConfirmationText } from 'lib/utils/confirmationText'
import { sessionRecordingCollectionsLogic } from 'scenes/session-recordings/collections/sessionRecordingCollectionsLogic'
-import { urls } from 'scenes/urls'
import { AccessControlLevel, AccessControlResourceType, RecordingUniversalFilters } from '~/types'
-import { bulkScanLogic } from 'products/replay_vision/frontend/logics/bulkScanLogic'
-import { visionQuotaLogic } from 'products/replay_vision/frontend/logics/visionQuotaLogic'
-import { quotaUx } from 'products/replay_vision/frontend/utils/quotaProjection'
-
import {
useAutoplayMenuItems,
useHideRecordingsMenuItems,
@@ -33,6 +27,7 @@ import {
preferredRecordingsSortStorage,
sessionRecordingsPlaylistLogic,
} from './sessionRecordingsPlaylistLogic'
+import { useBulkScanMenuItems } from './useBulkScanMenuItems'
const SortingKeyToLabel = {
start_time: 'Latest',
@@ -480,31 +475,11 @@ export function AddToCollectionModal({ shortId }: { shortId?: string }): JSX.Ele
/** Bulk "Scan these recordings" row whose scanner list opens on hover (a nested `items` menu is click-only). */
export function BulkScanMenuItem(): JSX.Element {
- const { selectedRecordingsIds } = useValues(sessionRecordingsPlaylistLogic)
- const { scanners, scannersLoading, scanning } = useValues(bulkScanLogic)
- const { scanRecordings } = useActions(bulkScanLogic)
- const { quota } = useValues(visionQuotaLogic)
- const { disabledReason: quotaDisabledReason, tooltip: quotaTooltip } = quotaUx(quota)
-
- const submenuItems: LemonMenuItem[] = scannersLoading
- ? [{ label: 'Loading scanners…', disabledReason: 'Loading' }]
- : scanners.length === 0
- ? [
- {
- label: 'No scanners yet — create one',
- onClick: () => router.actions.push(urls.replayVision()),
- 'data-attr': 'vision-bulk-scan-create-scanner',
- },
- ]
- : scanners.map((scanner) => ({
- label: scanner.name,
- onClick: () => scanRecordings(scanner.id, selectedRecordingsIds),
- 'data-attr': 'vision-bulk-scan-scanner-item',
- }))
+ const { items, disabledReason, tooltip } = useBulkScanMenuItems()
return (
<LemonMenu
- items={submenuItems}
+ items={items}
placement="right-start"
trigger="hover"
buttonSize="xsmall"
@@ -517,14 +492,8 @@ export function BulkScanMenuItem(): JSX.Element {
size="xsmall"
icon={<IconEye />}
sideIcon={<IconChevronRight />}
- disabledReason={
- scanning
- ? 'Starting scans…'
- : selectedRecordingsIds.length === 0
- ? 'Select recordings to scan'
- : quotaDisabledReason
- }
- tooltip={quotaTooltip}
+ disabledReason={disabledReason}
+ tooltip={tooltip}
data-attr="vision-bulk-scan-recordings"
>
Scan these recordings
diff --git a/frontend/src/scenes/session-recordings/playlist/useBulkScanMenuItems.ts b/frontend/src/scenes/session-recordings/playlist/useBulkScanMenuItems.ts
new file mode 100644
index 000000000000..fd34f2836378
--- /dev/null
+++ b/frontend/src/scenes/session-recordings/playlist/useBulkScanMenuItems.ts
@@ -0,0 +1,49 @@
+import { useActions, useValues } from 'kea'
+import { router } from 'kea-router'
+
+import { LemonMenuItem } from 'lib/lemon-ui/LemonMenu/LemonMenu'
+import { urls } from 'scenes/urls'
+
+import { bulkScanLogic } from 'products/replay_vision/frontend/logics/bulkScanLogic'
+import { visionQuotaLogic } from 'products/replay_vision/frontend/logics/visionQuotaLogic'
+import { quotaUx } from 'products/replay_vision/frontend/utils/quotaProjection'
+
+import { sessionRecordingsPlaylistLogic } from './sessionRecordingsPlaylistLogic'
+
+export function useBulkScanMenuItems(): {
+ items: LemonMenuItem[]
+ disabledReason: string | undefined
+ tooltip: string | undefined
+} {
+ const { selectedRecordingsIds } = useValues(sessionRecordingsPlaylistLogic)
+ const { scanners, scannersLoading, scanning } = useValues(bulkScanLogic)
+ const { scanRecordings } = useActions(bulkScanLogic)
+ const { quota } = useValues(visionQuotaLogic)
+ const { disabledReason: quotaDisabledReason, tooltip: quotaTooltip } = quotaUx(quota)
+
+ const items: LemonMenuItem[] = scannersLoading
+ ? [{ label: 'Loading scanners…', disabledReason: 'Loading' }]
+ : scanners.length === 0
+ ? [
+ {
+ label: 'No scanners yet — create one',
+ onClick: () => router.actions.push(urls.replayVision()),
+ 'data-attr': 'vision-bulk-scan-create-scanner',
+ },
+ ]
+ : scanners.map((scanner) => ({
+ label: scanner.name,
+ onClick: () => scanRecordings(scanner.id, selectedRecordingsIds),
+ 'data-attr': 'vision-bulk-scan-scanner-item',
+ }))
+
+ return {
+ items,
+ disabledReason: scanning
+ ? 'Starting scans…'
+ : selectedRecordingsIds.length === 0
+ ? 'Select recordings to scan'
+ : quotaDisabledReason,
+ tooltip: quotaTooltip,
+ }
+}