Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(alerts): link the project in native slack alerts (#122438)

Jimmy Zhu11eeef675958
diff --git a/products/alerts_platform/backend/delivery/dispatch.py b/products/alerts_platform/backend/delivery/dispatch.py
index 78515c08dbf5..33768cfc6902 100644
--- a/products/alerts_platform/backend/delivery/dispatch.py
+++ b/products/alerts_platform/backend/delivery/dispatch.py
@@ -24,6 +24,7 @@ from products.alerts_platform.backend.facade.contracts import (
AnnouncedTransition,
EvaluationAnnouncement,
IncidentAction,
+ MessageLink,
)
from products.alerts_platform.backend.logic.platform_reads import alert_snapshot
from products.alerts_platform.backend.temporal.metrics import increment_root_edit_failures, safe_record
@@ -44,6 +45,7 @@ def deliver(
incident_action: IncidentAction | None = None,
source_alert_url: str | None = None,
source_incident_key: str | None = None,
+ project: MessageLink | None = None,
) -> None:
channel_target = transport.channel_target(target)
busy = 0
@@ -84,6 +86,7 @@ def deliver(
source_alert_url=source_alert_url,
overflowed=overflowed,
source_incident_key=source_incident_key,
+ project=project,
),
in_reply_to=claim.handle,
)
diff --git a/products/alerts_platform/backend/delivery/evaluation.py b/products/alerts_platform/backend/delivery/evaluation.py
index ccde6197e4d0..8ec95d3bf56a 100644
--- a/products/alerts_platform/backend/delivery/evaluation.py
+++ b/products/alerts_platform/backend/delivery/evaluation.py
@@ -15,6 +15,7 @@ import structlog
from posthog.dataclasses import frozen
from posthog.models import Team
+from posthog.utils import absolute_uri
from products.alerts_platform.backend.delivery import delivery_paths, episode_paths, legacy_webhook
from products.alerts_platform.backend.delivery.destinations import list_alert_destination_groups
@@ -41,6 +42,7 @@ from products.alerts_platform.backend.facade.contracts import (
EvaluationAnnouncement,
IncidentAction,
LegacyEventEmission,
+ MessageLink,
)
from products.alerts_platform.backend.logic.platform_alert_events import announced_kinds, announcement
@@ -185,6 +187,7 @@ def deliver_evaluation(request: AlertDeliveryRequest) -> DeliveryOutcome:
)
thread_store = DatabaseThreadStore(request.team_id)
+ project = MessageLink(label=team.name, url=absolute_uri(f"/project/{team.id}"))
sent = 0
skipped = 0
busy: list[str] = []
@@ -257,6 +260,7 @@ def deliver_evaluation(request: AlertDeliveryRequest) -> DeliveryOutcome:
source_incident_key=source_incident_key(request.destination_alert_id)
if request.owned_by_platform
else None,
+ project=project,
)
except ThreadBusy as error:
busy.append(str(error))
diff --git a/products/alerts_platform/backend/delivery/message.py b/products/alerts_platform/backend/delivery/message.py
index fbf3f2361351..c5fafab895b7 100644
--- a/products/alerts_platform/backend/delivery/message.py
+++ b/products/alerts_platform/backend/delivery/message.py
@@ -76,6 +76,8 @@ class AlertMessage:
incident_action: IncidentAction | None = None
# The incident key the source's own stack opened incidents under, for a firing the platform took over.
source_incident_key: str | None = None
+ # The project the alert belongs to, which a reader with alerts in several projects needs.
+ project: MessageLink | None = None
@property
def title(self) -> str:
@@ -160,6 +162,7 @@ def build_message(
source_alert_url: str | None = None,
overflowed: int = 0,
source_incident_key: str | None = None,
+ project: MessageLink | None = None,
) -> AlertMessage:
"""The message for one transition.
@@ -209,4 +212,5 @@ def build_message(
slack_elements=description.slack_elements,
incident_action=incident_action,
source_incident_key=source_incident_key,
+ project=project,
)
diff --git a/products/alerts_platform/backend/delivery/slack.py b/products/alerts_platform/backend/delivery/slack.py
index d9c5f2eac06c..984920dbba13 100644
--- a/products/alerts_platform/backend/delivery/slack.py
+++ b/products/alerts_platform/backend/delivery/slack.py
@@ -62,11 +62,16 @@ def blocks_for(message: AlertMessage) -> list[dict[str, Any]]:
blocks: list[dict[str, Any]] = [header_block(message.title)]
if message.details:
blocks.append(section_block(_body(message.details)))
+ elements: list[str] = []
if message.context:
# Context names things a user chose, such as services, so it is escaped like a detail.
# Escaping can grow it fourfold, so the clip comes after it.
- context = " | ".join(escape_slack_mrkdwn(line) for line in message.context)
- blocks.append(context_block(clip_text(context, MAX_CONTEXT_CHARS)))
+ elements.append(clip_text(" | ".join(escape_slack_mrkdwn(line) for line in message.context), MAX_CONTEXT_CHARS))
+ if message.project is not None:
+ # Its own element, so a clipped context line never cuts the link in half.
+ elements.append(f"Project: <{message.project.url}|{escape_slack_mrkdwn(message.project.label)}>")
+ if elements:
+ blocks.append({"type": "context", "elements": [{"type": "mrkdwn", "text": text} for text in elements]})
if message.image is not None:
blocks.append(image_block(message.image.url, message.image.alt_text))
actions = actions_block([SlackButton(text=link.label, url=link.url) for link in message.links])
diff --git a/products/alerts_platform/backend/tests/test_delivery_evaluation.py b/products/alerts_platform/backend/tests/test_delivery_evaluation.py
index 128e2339ee7d..99719dc506d5 100644
--- a/products/alerts_platform/backend/tests/test_delivery_evaluation.py
+++ b/products/alerts_platform/backend/tests/test_delivery_evaluation.py
@@ -10,6 +10,8 @@ from unittest.mock import patch
from parameterized import parameterized
+from posthog.utils import absolute_uri
+
from products.alerts_platform.backend.delivery import delivery_paths, describers, legacy_webhook
from products.alerts_platform.backend.delivery.destinations import list_alert_destination_groups
from products.alerts_platform.backend.delivery.evaluation import LIVE_DELIVERY_FLAG, deliver_evaluation
@@ -28,6 +30,7 @@ from products.alerts_platform.backend.facade.contracts import (
EvaluationAnnouncement,
IncidentAction,
LegacyEventEmission,
+ MessageLink,
SourceKind,
)
from products.alerts_platform.backend.models import PlatformAlertConfiguration
@@ -414,7 +417,7 @@ class TestDeliverEvaluation(APIBaseTest):
assert RecordingTransport.sends == []
assert outcome.sent == 0
- def test_every_message_links_to_the_alert_page_the_request_names(self) -> None:
+ def test_every_message_links_to_the_alert_page_the_request_names_and_to_its_project(self) -> None:
url = "https://app.example.com/project/7/logs/alerts/legacy-1"
with (
@@ -429,7 +432,9 @@ class TestDeliverEvaluation(APIBaseTest):
):
deliver_evaluation(replace(_request(self.team.id), source_alert_url=url))
- assert [m.alert_url for _, m in RecordingTransport.sends] == [url]
+ assert [(m.alert_url, m.project) for _, m in RecordingTransport.sends] == [
+ (url, MessageLink(label=self.team.name, url=absolute_uri(f"/project/{self.team.id}")))
+ ]
def test_an_evaluation_that_announced_nothing_sends_nothing(self) -> None:
outcome = self._run(None, {FIRING_EVENT: [_group(SLACK)]})
diff --git a/products/alerts_platform/backend/tests/test_delivery_slack.py b/products/alerts_platform/backend/tests/test_delivery_slack.py
index c8110b8f3dea..6bbe005b0526 100644
--- a/products/alerts_platform/backend/tests/test_delivery_slack.py
+++ b/products/alerts_platform/backend/tests/test_delivery_slack.py
@@ -59,19 +59,23 @@ class TestSlackBlocks(SimpleTestCase):
assert "*Failed checks:* 3" in section["text"]["text"]
def test_user_text_cannot_speak_as_slack_markup(self) -> None:
- message = alert_message(
- headline="API errors could not be checked",
- details=(MessageDetail(label="Error", value="no column <!channel> in <http://x|table>"),),
- context=("Services: <!channel>",),
+ message = replace(
+ alert_message(
+ headline="API errors could not be checked",
+ details=(MessageDetail(label="Error", value="no column <!channel> in <http://x|table>"),),
+ context=("Services: <!channel>",),
+ ),
+ project=MessageLink(label="Prod <!channel>", url="https://app.example.com/project/2"),
)
blocks = blocks_for(message)
body = blocks[1]["text"]["text"]
- context = blocks[2]["elements"][0]["text"]
+ context, project = (element["text"] for element in blocks[2]["elements"])
- assert "<!channel>" not in body + context
+ assert "<!channel>" not in body + context + project
assert "&lt;!channel&gt;" in body
assert context == "Services: &lt;!channel&gt;"
+ assert project == "Project: <https://app.example.com/project/2|Prod &lt;!channel&gt;>"
def test_escaped_context_stays_inside_what_slack_accepts(self) -> None:
message = alert_message(context=("&" * 300,) * 3)