Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

feat(error-tracking): send assignment notifications without an assigner (#128300)

James Gill1234c2e5a112
diff --git a/posthog/tasks/email.py b/posthog/tasks/email.py
index d4029346c492..75a0148c63f4 100644
--- a/posthog/tasks/email.py
+++ b/posthog/tasks/email.py
@@ -2080,9 +2080,15 @@ def get_users_for_orgs_with_no_ingested_events(
@shared_task(**EMAIL_TASK_KWARGS)
@skip_team_scope_audit
-def send_error_tracking_issue_assigned(assignment_id: str | uuid.UUID, assigner_id: int) -> None:
+def send_error_tracking_issue_assigned(
+ assignment_id: str | uuid.UUID, assigner_id: int | None, assigned_by: str | None = None
+) -> None:
+ """Pass `assigner_id` for a person, or `assigned_by` (e.g. "An assignment rule") for an automatic assignment."""
+ if assigner_id is None and not assigned_by:
+ raise ValueError("assigned_by is required when there is no assigner")
+
assignment = error_tracking_api.get_issue_assignment_for_notification(assignment_id=assignment_id)
- assigner = User.objects.get(pk=assigner_id)
+ assigner = User.objects.get(pk=assigner_id) if assigner_id is not None else None
if not is_email_available(with_absolute_urls=True):
return
@@ -2097,23 +2103,28 @@ def send_error_tracking_issue_assigned(assignment_id: str | uuid.UUID, assigner_
memberships_to_email = [
membership
for membership in memberships_to_email
- if (membership.user_id == assignment.assigned_user_id and membership.user_id != assigner.id)
+ if (membership.user_id == assignment.assigned_user_id and membership.user_id != assigner_id)
]
elif assignment.role_id:
role_user_ids = set(assignment.role_member_user_ids)
memberships_to_email = [
membership
for membership in memberships_to_email
- if (membership.user_id in role_user_ids and membership.user_id != assigner.id)
+ if (membership.user_id in role_user_ids and membership.user_id != assigner_id)
]
- campaign_key: str = f"error_tracking_issue_assigned_{assignment.id}_updated_at_{assignment.created_at.timestamp()}"
+ campaign_key_segment = "" if assigner_id is not None else "automatic_"
+ campaign_key: str = (
+ f"error_tracking_issue_assigned_{campaign_key_segment}{assignment.id}"
+ f"_updated_at_{assignment.created_at.timestamp()}"
+ )
message = EmailMessage(
campaign_key=campaign_key,
subject=f"[Issue]: {assignment.issue.name} assigned to you in project '{team}'",
template_name="error_tracking_issue_assigned",
template_context={
"assigner": assigner,
+ "assigned_by": assigned_by,
"assignment": assignment,
"team": team,
"site_url": settings.SITE_URL,
diff --git a/posthog/templates/email/error_tracking_issue_assigned.html b/posthog/templates/email/error_tracking_issue_assigned.html
index 840e951524ea..e65cfde8c68f 100644
--- a/posthog/templates/email/error_tracking_issue_assigned.html
+++ b/posthog/templates/email/error_tracking_issue_assigned.html
@@ -3,7 +3,7 @@
{% block section %}
<!-- prettier-ignore -->
<p>
- <b>{{ assigner.first_name }}</b> has assigned you an error tracking issue in project <b>{{ team }}</b>.
+ {% if assigner %}<b>{{ assigner.first_name }}</b> has assigned{% else %}{{ assigned_by }} assigned{% endif %} you an error tracking issue in project <b>{{ team }}</b>.
</p>
<p>
<b>Issue:</b> {{ assignment.issue.name }}
diff --git a/products/error_tracking/backend/logic/issue_mutations.py b/products/error_tracking/backend/logic/issue_mutations.py
index ad08eeb3d636..4303261ed00d 100644
--- a/products/error_tracking/backend/logic/issue_mutations.py
+++ b/products/error_tracking/backend/logic/issue_mutations.py
@@ -54,7 +54,7 @@ from products.error_tracking.backend.models import (
ErrorTrackingIssueMergeResult,
sync_issues_to_clickhouse,
)
-from products.error_tracking.backend.notifications import dispatch_issue_assigned_realtime
+from products.error_tracking.backend.notifications import AssignmentActor, dispatch_issue_assigned_realtime
class CohortNotFoundError(Exception):
@@ -598,7 +598,7 @@ def _assign_one(
dispatch_issue_assigned_realtime(
assignment=assignment_after,
assignee=assignee,
- assigner=user,
+ actor=AssignmentActor.from_user(user),
)
transition = prepare_issue_lifecycle_event(
diff --git a/products/error_tracking/backend/notifications.py b/products/error_tracking/backend/notifications.py
index 6d958b855f7f..dc223476257e 100644
--- a/products/error_tracking/backend/notifications.py
+++ b/products/error_tracking/backend/notifications.py
@@ -1,7 +1,8 @@
-from typing import Any
+from typing import Any, Literal
import structlog
+from posthog.dataclasses import frozen
from posthog.models import User
from products.error_tracking.backend.logic import build_issue_permalink_path, get_canonical_fingerprint
@@ -29,16 +30,38 @@ class _AssignerExcludingResolver(RecipientsResolver):
return [uid for uid in users if uid != self._assigner_id]
+@frozen
+class AssignmentActor:
+ label: str
+ user_id: int | None
+
+ def __post_init__(self) -> None:
+ if not self.label:
+ raise ValueError("label is required")
+
+ @property
+ def trigger(self) -> Literal["manual", "automatic"]:
+ return "manual" if self.user_id is not None else "automatic"
+
+ @classmethod
+ def from_user(cls, user: User) -> "AssignmentActor":
+ return cls(label=user.first_name or user.email, user_id=user.id)
+
+ @classmethod
+ def automatic(cls, label: str) -> "AssignmentActor":
+ return cls(label=label, user_id=None)
+
+
def dispatch_issue_assigned_realtime(
*,
assignment: ErrorTrackingIssueAssignment,
assignee: dict[str, Any],
- assigner: User,
+ actor: AssignmentActor,
) -> None:
"""Fire one in-app issue_assigned notification for the new assignee.
- - User assignment: skip if assigner == assignee.
- - Role assignment: target the role; resolver excludes the assigner.
+ - User assignment: skip if the actor is the assignee.
+ - Role assignment: target the role; resolver excludes the acting user.
Never raises — caller's email enqueue must succeed independently.
"""
try:
@@ -47,48 +70,40 @@ def dispatch_issue_assigned_realtime(
team = assignment.team
assert team is not None # team_id is set, so the FK is non-null (Django stubs disagree)
issue = assignment.issue
- title = f"{assigner.first_name or assigner.email} assigned an issue to you"[:100]
+ title = f"{actor.label} assigned an issue to you"[:100]
+ metadata = {"trigger": actor.trigger}
body = (issue.name or "")[:200]
fingerprint = get_canonical_fingerprint(team_id=assignment.team_id, issue_id=issue.id)
source_url = build_issue_permalink_path(project_id=team.project_id, issue_id=issue.id, fingerprint=fingerprint)
if assignee["type"] == "user":
- if int(assignee["id"]) == assigner.id:
+ if int(assignee["id"]) == actor.user_id:
return
- create_notification(
- NotificationData(
- team_id=assignment.team_id,
- notification_type=NotificationType.ISSUE_ASSIGNED,
- priority=Priority.NORMAL,
- title=title,
- body=body,
- target_type=TargetType.USER,
- target_id=str(assignee["id"]),
- resource_type="error_tracking",
- resource_id=str(issue.id),
- source_url=source_url,
- source_type=SourceType.ERROR_TRACKING,
- source_id=str(issue.id),
- )
- )
+ target_type = TargetType.USER
+ resolver = None
elif assignee["type"] == "role":
- create_notification(
- NotificationData(
- team_id=assignment.team_id,
- notification_type=NotificationType.ISSUE_ASSIGNED,
- priority=Priority.NORMAL,
- title=title,
- body=body,
- target_type=TargetType.ROLE,
- target_id=str(assignee["id"]),
- resource_type="error_tracking",
- resource_id=str(issue.id),
- source_url=source_url,
- source_type=SourceType.ERROR_TRACKING,
- source_id=str(issue.id),
- resolver=_AssignerExcludingResolver(assigner_id=assigner.id),
- )
+ target_type = TargetType.ROLE
+ resolver = _AssignerExcludingResolver(assigner_id=actor.user_id) if actor.user_id is not None else None
+ else:
+ return
+ create_notification(
+ NotificationData(
+ team_id=assignment.team_id,
+ notification_type=NotificationType.ISSUE_ASSIGNED,
+ priority=Priority.NORMAL,
+ title=title,
+ body=body,
+ target_type=target_type,
+ target_id=str(assignee["id"]),
+ resource_type="error_tracking",
+ resource_id=str(issue.id),
+ source_url=source_url,
+ source_type=SourceType.ERROR_TRACKING,
+ source_id=str(issue.id),
+ metadata=metadata,
+ resolver=resolver,
)
+ )
except Exception as e:
logger.exception(
"issue_assigned.realtime_failed",
diff --git a/products/error_tracking/backend/test_notifications.py b/products/error_tracking/backend/test_notifications.py
index 97794b861aa6..ac8cedfd179c 100644
--- a/products/error_tracking/backend/test_notifications.py
+++ b/products/error_tracking/backend/test_notifications.py
@@ -1,32 +1,55 @@
+from uuid import UUID
+
+import pytest
from posthog.test.base import BaseTest
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
from django.test import SimpleTestCase
from parameterized import parameterized
from posthog.models import User
+from posthog.models.instance_setting import set_instance_setting
+from posthog.tasks.email import send_error_tracking_issue_assigned
+from posthog.tasks.test.utils_email_tests import mock_email_messages
-from products.access_control.backend.facade.testing import create_role
+from products.access_control.backend.facade.testing import add_role_member, create_role
from products.error_tracking.backend.models import ErrorTrackingIssue, ErrorTrackingIssueAssignment
-from products.error_tracking.backend.notifications import _AssignerExcludingResolver, dispatch_issue_assigned_realtime
+from products.error_tracking.backend.notifications import (
+ AssignmentActor,
+ _AssignerExcludingResolver,
+ dispatch_issue_assigned_realtime,
+)
from products.notifications.backend.facade.enums import TargetType
-class TestDispatchIssueAssignedRealtime(BaseTest):
+class _AssignmentTestBase(BaseTest):
def setUp(self):
super().setUp()
self.assigner = self.user
self.assignee = User.objects.create_and_join(self.organization, "[email protected]", "password")
self.issue = ErrorTrackingIssue.objects.create(team=self.team, name="Some Error", description="boom")
+ def _create_assignment(self, assignee_type: str) -> tuple[ErrorTrackingIssueAssignment, int | UUID]:
+ if assignee_type == "user":
+ assignment = ErrorTrackingIssueAssignment.objects.create(
+ team=self.team, issue=self.issue, user=self.assignee
+ )
+ return assignment, self.assignee.id
+ role_id = create_role(organization_id=self.organization.id, name="Devs")
+ add_role_member(role_id=role_id, user_id=self.assigner.id)
+ add_role_member(role_id=role_id, user_id=self.assignee.id)
+ return ErrorTrackingIssueAssignment.objects.create(team=self.team, issue=self.issue, role_id=role_id), role_id
+
+
+class TestDispatchIssueAssignedRealtime(_AssignmentTestBase):
@patch("products.error_tracking.backend.notifications.create_notification")
def test_user_assignment_dispatches_to_assignee(self, mock_create_notification):
assignment = ErrorTrackingIssueAssignment.objects.create(team=self.team, issue=self.issue, user=self.assignee)
dispatch_issue_assigned_realtime(
assignment=assignment,
assignee={"type": "user", "id": self.assignee.id},
- assigner=self.assigner,
+ actor=AssignmentActor.from_user(self.assigner),
)
mock_create_notification.assert_called_once()
data = mock_create_notification.call_args.args[0]
@@ -34,6 +57,8 @@ class TestDispatchIssueAssignedRealtime(BaseTest):
assert data.target_id == str(self.assignee.id)
assert data.resource_type == "error_tracking"
assert data.resource_id == str(self.issue.id)
+ assert data.title == f"{self.assigner.email} assigned an issue to you"
+ assert data.metadata == {"trigger": "manual"}
@patch("products.error_tracking.backend.notifications.create_notification")
def test_user_self_assignment_does_not_dispatch(self, mock_create_notification):
@@ -41,7 +66,7 @@ class TestDispatchIssueAssignedRealtime(BaseTest):
dispatch_issue_assigned_realtime(
assignment=assignment,
assignee={"type": "user", "id": self.assigner.id},
- assigner=self.assigner,
+ actor=AssignmentActor.from_user(self.assigner),
)
mock_create_notification.assert_not_called()
@@ -52,7 +77,7 @@ class TestDispatchIssueAssignedRealtime(BaseTest):
dispatch_issue_assigned_realtime(
assignment=assignment,
assignee={"type": "role", "id": role_id},
- assigner=self.assigner,
+ actor=AssignmentActor.from_user(self.assigner),
)
mock_create_notification.assert_called_once()
data = mock_create_notification.call_args.args[0]
@@ -61,16 +86,38 @@ class TestDispatchIssueAssignedRealtime(BaseTest):
assert isinstance(data.resolver, _AssignerExcludingResolver)
assert data.resolver._assigner_id == self.assigner.id
+ @parameterized.expand([("user",), ("role",)])
+ @patch("products.error_tracking.backend.notifications.create_notification")
+ def test_automatic_assignment_dispatches_without_assigner(self, assignee_type, mock_create_notification):
+ assignment, assignee_id = self._create_assignment(assignee_type)
+ dispatch_issue_assigned_realtime(
+ assignment=assignment,
+ assignee={"type": assignee_type, "id": assignee_id},
+ actor=AssignmentActor.automatic("An assignment rule"),
+ )
+ mock_create_notification.assert_called_once()
+ data = mock_create_notification.call_args.args[0]
+ assert data.target_id == str(assignee_id)
+ assert data.title == "An assignment rule assigned an issue to you"
+ assert data.metadata == {"trigger": "automatic"}
+ assert data.resolver is None
+
@patch("products.error_tracking.backend.notifications.create_notification", side_effect=RuntimeError("boom"))
def test_dispatch_failure_is_swallowed(self, _mock_create_notification):
assignment = ErrorTrackingIssueAssignment.objects.create(team=self.team, issue=self.issue, user=self.assignee)
dispatch_issue_assigned_realtime(
assignment=assignment,
assignee={"type": "user", "id": self.assignee.id},
- assigner=self.assigner,
+ actor=AssignmentActor.from_user(self.assigner),
)
+class TestAssignmentActor(SimpleTestCase):
+ def test_rejects_empty_label(self):
+ with pytest.raises(ValueError):
+ AssignmentActor.automatic("")
+
+
class TestAssignerExcludingResolver(SimpleTestCase):
@parameterized.expand(
[
@@ -85,3 +132,53 @@ class TestAssignerExcludingResolver(SimpleTestCase):
resolver = _AssignerExcludingResolver(assigner_id=assigner_id)
result = resolver.resolve(TargetType.ROLE, "1", team_id=1)
assert result == expected
+
+
+@patch("posthog.tasks.email.EmailMessage")
+class TestSendIssueAssignedEmail(_AssignmentTestBase):
+ @classmethod
+ def setUpTestData(cls):
+ super().setUpTestData()
+ set_instance_setting("EMAIL_HOST", "fake_host")
+ set_instance_setting("EMAIL_ENABLED", True)
+
+ def setUp(self):
+ super().setUp()
+ self.assigner.first_name = "Alice"
+ self.assigner.save()
+
+ @parameterized.expand(
+ [
+ ("manual_user", "user", False, ["assignee"]),
+ ("automatic_user", "user", True, ["assignee"]),
+ ("manual_role_excludes_assigner", "role", False, ["assignee"]),
+ ("automatic_role_excludes_nobody", "role", True, ["assignee", "assigner"]),
+ ]
+ )
+ def test_sends_to_assignee(self, MockEmailMessage: MagicMock, _name, assignee_type, automatic, expected_recipients):
+ mocked_email_messages = mock_email_messages(MockEmailMessage)
+ assignment, _ = self._create_assignment(assignee_type)
+
+ if automatic:
+ send_error_tracking_issue_assigned(assignment.id, None, assigned_by="An assignment rule")
+ else:
+ send_error_tracking_issue_assigned(assignment.id, self.assigner.id)
+
+ assert len(mocked_email_messages) == 1
+ message = mocked_email_messages[0]
+ emails = {"assignee": self.assignee.email, "assigner": self.assigner.email}
+ assert sorted(to["raw_email"] for to in message.to) == sorted(emails[key] for key in expected_recipients)
+ if automatic:
+ assert "An assignment rule assigned you" in message.html_body
+ assert message.campaign_key.startswith(f"error_tracking_issue_assigned_automatic_{assignment.id}_")
+ else:
+ assert "Alice</b> has assigned you" in message.html_body
+ assert message.campaign_key.startswith(f"error_tracking_issue_assigned_{assignment.id}_")
+
+ def test_rejects_missing_assigner_and_label(self, MockEmailMessage: MagicMock):
+ assignment, _ = self._create_assignment("user")
+
+ with pytest.raises(ValueError):
+ send_error_tracking_issue_assigned(assignment.id, None)
+
+ MockEmailMessage.assert_not_called()