Skip to content

:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.

fix(workflows): stop the trigger reporting runs that never start (#123472)

Meikel Ratz1298456c7395
diff --git a/products/workflows/frontend/Workflows/hogflows/HogFlowManualTriggerButton.tsx b/products/workflows/frontend/Workflows/hogflows/HogFlowManualTriggerButton.tsx
index 57c341e8e66d..85ee8f6d856a 100644
--- a/products/workflows/frontend/Workflows/hogflows/HogFlowManualTriggerButton.tsx
+++ b/products/workflows/frontend/Workflows/hogflows/HogFlowManualTriggerButton.tsx
@@ -159,22 +159,15 @@ const TriggerPopover = ({
export const HogFlowManualTriggerButton = (props: WorkflowLogicProps = {}): JSX.Element => {
const logic = hogFlowManualTriggerButtonLogic(props)
- const { workflow, hasUnsavedChanges } = useValues(workflowLogic(props))
+ const { manualTriggerDisabledReason } = useValues(workflowLogic(props))
const { popoverVisible } = useValues(logic)
const { setPopoverVisible } = useActions(logic)
const todayRailNav = useFeatureFlag('TODAY_RAIL_NAV')
- const triggerDisabledReason =
- workflow?.status !== 'active'
- ? 'Must enable workflow to use trigger'
- : hasUnsavedChanges
- ? 'Save changes first'
- : undefined
-
const triggerButton = todayRailNav ? (
<Button
variant="primary"
- disabledReason={triggerDisabledReason}
+ disabledReason={manualTriggerDisabledReason}
tooltip="Triggers workflow immediately"
onClick={() => setPopoverVisible(!popoverVisible)}
>
@@ -185,13 +178,7 @@ export const HogFlowManualTriggerButton = (props: WorkflowLogicProps = {}): JSX.
<LemonButton
type="primary"
size="small"
- disabledReason={
- workflow?.status !== 'active'
- ? 'Must enable workflow to use trigger'
- : hasUnsavedChanges
- ? 'Save changes first'
- : undefined
- }
+ disabledReason={manualTriggerDisabledReason}
sideIcon={<IconChevronDown className={`transition-transform ${popoverVisible ? 'rotate-180' : ''}`} />}
tooltip="Triggers workflow immediately"
onClick={() => setPopoverVisible(!popoverVisible)}
diff --git a/products/workflows/frontend/Workflows/workflowLogic.autosave.test.ts b/products/workflows/frontend/Workflows/workflowLogic.autosave.test.ts
index b09fc8ebe5f3..54580a686406 100644
--- a/products/workflows/frontend/Workflows/workflowLogic.autosave.test.ts
+++ b/products/workflows/frontend/Workflows/workflowLogic.autosave.test.ts
@@ -1,6 +1,8 @@
import { expectLogic } from 'kea-test-utils'
import posthog from 'posthog-js'
+import { lemonToast } from '@posthog/lemon-ui'
+
import { useMocks } from '~/mocks/jest'
import { initKeaTests } from '~/test/init'
@@ -770,6 +772,57 @@ describe('workflowLogic auto-save', () => {
})
})
+ describe('manual trigger on an active workflow', () => {
+ const activeWorkflow = (draft?: Record<string, any>): HogFlow =>
+ makeWorkflow({
+ status: 'active',
+ trigger: { type: 'schedule' } as HogFlow['trigger'],
+ ...(draft ? { draft, draft_updated_at: '2026-05-01T00:01:00.000Z' } : {}),
+ })
+
+ const mountLoaded = async (): Promise<void> => {
+ initKeaTests()
+ logic = workflowLogic({ id: WORKFLOW_ID })
+ logic.mount()
+ await expectLogic(logic).toDispatchActions(['loadWorkflowSuccess'])
+ }
+
+ it('blocks the trigger while only the draft carries the new trigger type', async () => {
+ const staged = activeWorkflow({ trigger: { type: 'manual', filters: {} }, actions: [], edges: [] })
+ useMocks({ get: { '/api/environments/:team_id/hog_flows/:id/': staged } })
+ await mountLoaded()
+
+ expect(logic.values.manualTriggerDisabledReason).toBe(
+ 'Publish your draft first. The live workflow still uses its published trigger.'
+ )
+ })
+
+ it('allows the trigger when the draft leaves the trigger alone', async () => {
+ const staged = activeWorkflow({ name: 'Renamed', actions: [], edges: [] })
+ useMocks({ get: { '/api/environments/:team_id/hog_flows/:id/': staged } })
+ await mountLoaded()
+
+ expect(logic.values.manualTriggerDisabledReason).toBeUndefined()
+ })
+
+ it('reports a refused trigger instead of claiming the workflow ran', async () => {
+ useMocks({
+ get: { '/api/environments/:team_id/hog_flows/:id/': activeWorkflow() },
+ post: { '/public/webhooks/:id': () => [404, {}] },
+ })
+ await mountLoaded()
+ const errorToast = jest.spyOn(lemonToast, 'error')
+ const successToast = jest.spyOn(lemonToast, 'success')
+
+ await expectLogic(logic, () => {
+ logic.actions.triggerManualWorkflow({})
+ }).toFinishAllListeners()
+
+ expect(successToast).not.toHaveBeenCalled()
+ expect(errorToast).toHaveBeenCalled()
+ })
+ })
+
describe('draft actions on an active workflow', () => {
const staged = makeWorkflow({
status: 'active',
diff --git a/products/workflows/frontend/Workflows/workflowLogic.ts b/products/workflows/frontend/Workflows/workflowLogic.ts
index f1e0a23ab948..786c973d290d 100644
--- a/products/workflows/frontend/Workflows/workflowLogic.ts
+++ b/products/workflows/frontend/Workflows/workflowLogic.ts
@@ -305,6 +305,7 @@ export interface workflowLogicValues {
isWorkflowValid: boolean
lastSavedAt: string | null
logicProps: WorkflowLogicProps
+ manualTriggerDisabledReason: string | undefined
originalWorkflow: HogFlow | null
originalWorkflowLoading: boolean
pendingSchedule:
@@ -3207,6 +3208,11 @@ export interface workflowLogicMeta {
draftActionPending: 'discard' | 'publish' | null
) => string | undefined
statusToggleDisabledReason: (workflow: HogFlow, hasUnsavedChanges: boolean) => string | undefined
+ manualTriggerDisabledReason: (
+ workflow: HogFlow,
+ originalWorkflow: HogFlow | null,
+ hasUnsavedChanges: boolean
+ ) => string | undefined
}
}
@@ -4215,6 +4221,24 @@ export const workflowLogic = kea<workflowLogicType>([
return undefined
},
],
+
+ manualTriggerDisabledReason: [
+ (s) => [s.workflow, s.originalWorkflow, s.hasUnsavedChanges],
+ (workflow: HogFlow, originalWorkflow: HogFlow | null, hasUnsavedChanges: boolean): string | undefined => {
+ if (workflow?.status !== 'active') {
+ return 'Must enable workflow to use trigger'
+ }
+ if (hasUnsavedChanges) {
+ return 'Save changes first'
+ }
+ // A run uses the published trigger, so a trigger that lives only in the draft
+ // starts nothing.
+ if (originalWorkflow?.draft && originalWorkflow.trigger?.type !== workflow?.trigger?.type) {
+ return 'Publish your draft first. The live workflow still uses its published trigger.'
+ }
+ return undefined
+ },
+ ],
}),
listeners(({ actions, values, props, cache }) => ({
setScheduleStartsAtFromPicker: ({ pickerDate }) => {
@@ -4769,7 +4793,7 @@ export const workflowLogic = kea<workflowLogicType>([
lemonToast.info('Triggering workflow...')
try {
- await fetch(webhookUrl, {
+ const response = await fetch(webhookUrl, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
@@ -4781,6 +4805,11 @@ export const workflowLogic = kea<workflowLogicType>([
credentials: 'omit',
})
+ // fetch rejects only on a network failure, so a refused webhook resolves here too.
+ if (!response.ok) {
+ throw new Error(`the webhook returned ${response.status}`)
+ }
+
lemonToast.success('Workflow triggered', {
button: {
label: 'View logs',