:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
refactor(insights): move chart display options next to ChartFilter (#126860)
Paul D'Ambra131a756b9acd
diff --git a/frontend/bin/layer-baseline.txt b/frontend/bin/layer-baseline.txtindex de5af16643a1..a287d532e029 100644--- a/frontend/bin/layer-baseline.txt+++ b/frontend/bin/layer-baseline.txt@@ -196,8 +196,6 @@ frontend/src/lib/components/Cards/TextCard/textCardModalLogic.ts -> products/dasfrontend/src/lib/components/ChartFilter/ChartFilter.tsx -> frontend/src/scenes/insights/insightLogic.tsxfrontend/src/lib/components/ChartFilter/ChartFilter.tsx -> frontend/src/scenes/insights/insightVizDataLogic.tsfrontend/src/lib/components/ChartFilter/ChartFilter.tsx -> frontend/src/scenes/insights/utils/queryUtils.ts-frontend/src/lib/components/ChartFilter/ChartFilter.tsx -> products/product_analytics/frontend/insights/chartAlternatives/ChartDisplayIcon.tsx-frontend/src/lib/components/ChartFilter/ChartFilter.tsx -> products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions.tsfrontend/src/lib/components/CyclotronJob/CyclotronJobInputs.tsx -> frontend/src/scenes/hog-functions/email-templater/EmailTemplater.tsxfrontend/src/lib/components/CyclotronJob/CyclotronJobInputsValidation.ts -> frontend/src/scenes/hog-functions/email-templater/types.tsfrontend/src/lib/components/DateFilter/openJumpToTimestampModal.tsx -> frontend/src/scenes/activity/explore/defaults.tsdiff --git a/products/product_analytics/frontend/insights/chartAlternatives/ChartDisplayIcon.tsx b/frontend/src/lib/components/ChartFilter/ChartDisplayIcon.tsxsimilarity index 100%rename from products/product_analytics/frontend/insights/chartAlternatives/ChartDisplayIcon.tsxrename to frontend/src/lib/components/ChartFilter/ChartDisplayIcon.tsxdiff --git a/frontend/src/lib/components/ChartFilter/ChartFilter.tsx b/frontend/src/lib/components/ChartFilter/ChartFilter.tsxindex 5029b6f5b792..f67dea03a60a 100644--- a/frontend/src/lib/components/ChartFilter/ChartFilter.tsx+++ b/frontend/src/lib/components/ChartFilter/ChartFilter.tsx@@ -2,6 +2,9 @@ import { useActions, useValues } from 'kea'import { LemonSelect, LemonSelectOption, LemonSelectOptions } from '@posthog/lemon-ui'+import { ChartDisplayIcon } from 'lib/components/ChartFilter/ChartDisplayIcon'+import type { ChartDisplayOption } from 'lib/components/ChartFilter/chartDisplayOptions'+import { getChartDisplayOptions } from 'lib/components/ChartFilter/chartDisplayOptions'import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { insightLogic } from 'scenes/insights/insightLogic'@@ -11,10 +14,6 @@ import { isBoxPlotMissingProperty } from 'scenes/insights/utils/queryUtils'import type { TrendsQuery } from '~/queries/schema/schema-general'import { ChartDisplayType } from '~/types'-import { ChartDisplayIcon } from 'products/product_analytics/frontend/insights/chartAlternatives/ChartDisplayIcon'-import type { ChartDisplayOption } from 'products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions'-import { getChartDisplayOptions } from 'products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions'-function ChartFilterOptionLabel(props: { label: string; description?: string }): JSX.Element {return (<div className="flex flex-col gap-[2px]">diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions.test.ts b/frontend/src/lib/components/ChartFilter/chartDisplayOptions.test.tssimilarity index 100%rename from products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions.test.tsrename to frontend/src/lib/components/ChartFilter/chartDisplayOptions.test.tsdiff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions.ts b/frontend/src/lib/components/ChartFilter/chartDisplayOptions.tssimilarity index 100%rename from products/product_analytics/frontend/insights/chartAlternatives/chartDisplayOptions.tsrename to frontend/src/lib/components/ChartFilter/chartDisplayOptions.tsdiff --git a/products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives.tsx b/products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives.tsxindex a09d25689304..fbb5274b9b19 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives.tsx+++ b/products/product_analytics/frontend/insights/chartAlternatives/ChartAlternatives.tsx@@ -4,11 +4,11 @@ import { useRef } from 'react'import { LemonButton, Popover } from '@posthog/lemon-ui'import { ChartFilter } from 'lib/components/ChartFilter'+import { ChartDisplayIcon } from 'lib/components/ChartFilter/ChartDisplayIcon'import type { InsightLogicProps } from '~/types'import { chartAlternativesLogic } from './chartAlternativesLogic'-import { ChartDisplayIcon } from './ChartDisplayIcon'import { ChartGallery } from './ChartGallery'import { chartPreviewsLogic } from './chartPreviewsLogic'diff --git a/products/product_analytics/frontend/insights/chartAlternatives/ChartPreviewTile.tsx b/products/product_analytics/frontend/insights/chartAlternatives/ChartPreviewTile.tsxindex 7de57276616c..76f9a42f485d 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/ChartPreviewTile.tsx+++ b/products/product_analytics/frontend/insights/chartAlternatives/ChartPreviewTile.tsx@@ -2,11 +2,11 @@ import clsx from 'clsx'import { IconInfo } from '@posthog/icons'+import { ChartDisplayIcon } from 'lib/components/ChartFilter/ChartDisplayIcon'import { Tooltip } from 'lib/lemon-ui/Tooltip'import { ChartDisplayType } from '~/types'-import { ChartDisplayIcon } from './ChartDisplayIcon'import { ChartPreviewCanvas } from './ChartPreviewCanvas'import type { ChartPreview } from './chartPreviewsLogic'diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.tsindex 4ee0b14d9ccb..dc3e15792fb2 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartAlternativesLogic.ts@@ -1,6 +1,12 @@import { MakeLogicType, actions, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import posthog from 'posthog-js'+import {+ applyChartDisplay,+ getChartDisplayOptions,+ hasTrendsFormula,+} from 'lib/components/ChartFilter/chartDisplayOptions'+import type { ChartDisplayOption, ChartDisplayOptionGroup } from 'lib/components/ChartFilter/chartDisplayOptions'import { FEATURE_FLAGS } from 'lib/constants'import { featureFlagLogic } from 'lib/logic/featureFlagLogic'import { insightDataLogic } from 'scenes/insights/insightDataLogic'@@ -29,8 +35,6 @@ import type {WebOverviewQuery,WebStatsTableQuery,} from '../../../../../frontend/src/queries/schema/schema-general'-import { applyChartDisplay, getChartDisplayOptions, hasTrendsFormula } from './chartDisplayOptions'-import type { ChartDisplayOption, ChartDisplayOptionGroup } from './chartDisplayOptions'import { getChartAlternatives } from './chartRecommendations'export type ChartAlternativeSource = 'gallery' | 'preview' | 'recommended'diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewData.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewData.tsindex 840136b1ec15..5f449ab39c0c 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewData.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewData.ts@@ -1,10 +1,10 @@+import { breakdownProperties, hasTrendsFormula } from 'lib/components/ChartFilter/chartDisplayOptions'import { getResultOrder, getResultSeries } from 'scenes/insights/utils/resultSeries'import type { AnyResponseType, TrendsQuery } from '~/queries/schema/schema-general'import { ChartDisplayType, type TrendResult } from '~/types'import { hasTrendsChartData } from '../shared/hasTrendsChartData'-import { breakdownProperties, hasTrendsFormula } from './chartDisplayOptions'import { sampleBoxPlotRows, sampleCalendarHeatmapRows, sampleWorldMapRows } from './chartPreviewSamples'export interface ChartPreviewData {diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.tsindex cbd8613f7c5b..493b3c6a4226 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartPreviewsLogic.ts@@ -1,6 +1,8 @@import { MakeLogicType, actions, afterMount, connect, kea, key, listeners, path, props, reducers, selectors } from 'kea'import posthog from 'posthog-js'+import { applyChartDisplay } from 'lib/components/ChartFilter/chartDisplayOptions'+import type { ChartDisplayOption, ChartDisplayOptionGroup } from 'lib/components/ChartFilter/chartDisplayOptions'import { insightVizDataLogic } from 'scenes/insights/insightVizDataLogic'import { keyForInsightLogicProps } from 'scenes/insights/sharedUtils'@@ -10,8 +12,6 @@ import { ChartDisplayType } from '~/types'import type { ChartAlternativesLogicProps } from './chartAlternativesLogic'import { chartAlternativesLogic } from './chartAlternativesLogic'-import { applyChartDisplay } from './chartDisplayOptions'-import type { ChartDisplayOption, ChartDisplayOptionGroup } from './chartDisplayOptions'import { RAW_TIME_SERIES_DISPLAYS, deriveChartPreview, hasPreviewData } from './chartPreviewData'export interface ChartPreview {diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.test.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.test.tsindex 925a11b8d07e..f2242e6a56f4 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.test.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.test.ts@@ -1,8 +1,9 @@+import { getChartDisplayOptions } from 'lib/components/ChartFilter/chartDisplayOptions'+import { NodeKind } from '~/queries/schema/schema-general'import type { TrendsQuery } from '~/queries/schema/schema-general'import { BaseMathType, ChartDisplayType, PropertyFilterType, PropertyMathType, PropertyOperator } from '~/types'-import { getChartDisplayOptions } from './chartDisplayOptions'import { getChartAlternatives } from './chartRecommendations'function makeTrendsQuery(overrides: Partial<TrendsQuery> = {}): TrendsQuery {diff --git a/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.ts b/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.tsindex 2acd2b79cd98..876e6a5d5a15 100644--- a/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.ts+++ b/products/product_analytics/frontend/insights/chartAlternatives/chartRecommendations.ts@@ -1,3 +1,9 @@+import {+ breakdownProperties,+ hasTrendsFormula,+ isCountryProperty,+} from 'lib/components/ChartFilter/chartDisplayOptions'+import type { ChartDisplayOption, ChartDisplayOptionGroup } from 'lib/components/ChartFilter/chartDisplayOptions'import { convertPropertyGroupToProperties } from 'lib/components/PropertyFilters/utils'import { DISPLAY_TYPES_TO_CATEGORIES, NON_BREAKDOWN_DISPLAY_TYPES, PART_OF_WHOLE_DISPLAY_TYPES } from 'lib/constants'import { isPropertyValueMath } from 'scenes/insights/filters/ActionFilter/ActionFilterRow/mathUtils'@@ -7,9 +13,6 @@ import { hasBreakdownFilter } from '~/queries/utils'import { ChartDisplayCategory, ChartDisplayType, PropertyMathType } from '~/types'import type { AnyPropertyFilter } from '~/types'-import { breakdownProperties, hasTrendsFormula, isCountryProperty } from './chartDisplayOptions'-import type { ChartDisplayOption, ChartDisplayOptionGroup } from './chartDisplayOptions'-const DEFAULT_RECOMMENDATION_ORDER = [ChartDisplayType.Metric,ChartDisplayType.ActionsUnstackedBar,