:hedgehog: PostHog is the leading platform for building self-driving products. Our developer tools – AI observability, analytics, session replay, flags, experiments, error tracking, logs, and more – capture all the context agents need to diagnose problems, uncover opportunities, and ship fixes. Steer it all from Slack, web, desktop, or the MCP.
Python ab-testingai-analyticsanalyticscdpdata-warehouseexperimentsfeature-flagsjavascriptproduct-analyticspythonreactsession-replaysurveystypescriptweb-analytics
fix(replay): pass the requested limit to collection recordings (#125456)
Tue Haulund1817372bb26f
diff --git a/posthog/session_recordings/session_recording_playlist_api.py b/posthog/session_recordings/session_recording_playlist_api.pyindex d24325064034..5e05c76c69f9 100644--- a/posthog/session_recordings/session_recording_playlist_api.py+++ b/posthog/session_recordings/session_recording_playlist_api.py@@ -1023,7 +1023,7 @@ class SessionRecordingPlaylistViewSet(# For collections, create a minimal query with only session_idsif playlist.type == SessionRecordingPlaylist.PlaylistType.COLLECTION:- query = RecordingsQuery(session_ids=playlist_items, date_from="-1y", date_to=None)+ query = RecordingsQuery(session_ids=playlist_items, date_from="-1y", date_to=None, limit=limit)else:data_dict = query_as_params_to_dict(request.GET.dict())query = RecordingsQuery.model_validate(data_dict)diff --git a/posthog/session_recordings/test/test_session_recording_playlist.py b/posthog/session_recordings/test/test_session_recording_playlist.pyindex 80e45b2b0733..d3f48fe5c6aa 100644--- a/posthog/session_recordings/test/test_session_recording_playlist.py+++ b/posthog/session_recordings/test/test_session_recording_playlist.py@@ -889,6 +889,34 @@ class TestSessionRecordingPlaylist(APIBaseTest, QueryMatchingTest):assert response.status_code == status.HTTP_200_OKassert {x["id"] for x in response.json()["results"]} == {recent_session}+ def test_collection_recordings_respect_requested_limit(self) -> None:+ playlist = SessionRecordingPlaylist.objects.create(+ team=self.team, name="collection", created_by=self.user, type="collection"+ )++ sessions_newest_first = [f"collection-limit-{i}-{uuid4()}" for i in range(3)]+ three_days_ago = (datetime.now() - timedelta(days=3)).replace(tzinfo=UTC)++ for hours_earlier, session_id in enumerate(sessions_newest_first):+ timestamp = three_days_ago - timedelta(hours=hours_earlier)+ produce_replay_summary(+ team_id=self.team.id,+ session_id=session_id,+ distinct_id="123",+ first_timestamp=timestamp,+ last_timestamp=timestamp,+ )+ self.client.post(+ f"/api/projects/{self.team.id}/session_recording_playlists/{playlist.short_id}/recordings/{session_id}"+ )++ response = self.client.get(+ f"/api/projects/{self.team.id}/session_recording_playlists/{playlist.short_id}/recordings",+ data={"limit": 2},+ )+ assert response.status_code == status.HTTP_200_OK+ assert {x["id"] for x in response.json()["results"]} == set(sessions_newest_first[:2])+@parameterized.expand([("narrow_window_excludes", "-1d", False),